I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high. This looks about right to me with the few fonts I have around. I'm attaching an example html file as well. PS Might be good to go through that area of the code one day to see what opportunities there are to make it clearer...
On Sat, Feb 07, 2009 at 05:01:12AM +0000, corvid wrote:
I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high.
This looks about right to me with the few fonts I have around.
Maybe one could determine the line width based on the xHeight member of the font? Just an idea. Cheers, Johannes
Johannes wrote:
On Sat, Feb 07, 2009 at 05:01:12AM +0000, corvid wrote:
I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high.
This looks about right to me with the few fonts I have around.
Maybe one could determine the line width based on the xHeight member of the font? Just an idea.
Ah, good. 'diff' was sort of compensating for what sup and sub do to ascent and descent, but imperfectly -- as you probably noticed. Here's a new patch.
On Sat, Feb 07, 2009 at 03:57:13PM +0000, corvid wrote:
Johannes wrote:
On Sat, Feb 07, 2009 at 05:01:12AM +0000, corvid wrote:
I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high.
This looks about right to me with the few fonts I have around.
Maybe one could determine the line width based on the xHeight member of the font? Just an idea.
Ah, good. 'diff' was sort of compensating for what sup and sub do to ascent and descent, but imperfectly -- as you probably noticed.
Here's a new patch.
BTW, the new patch was the committed one. -- Cheers Jorge.-
On Sat, Feb 07, 2009 at 05:01:12AM +0000, corvid wrote:
I was thinking that large text with a thin line through it looks odd. Turns out that there was also a problem with <sup> causing the <s> line to be too high.
This looks about right to me with the few fonts I have around.
I'm attaching an example html file as well.
Committed. -- Cheers Jorge.-
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de