Jorge Arellano Cid wrote:
Hi Frank,
I just noticed the newes keyboard navigation patch in the mailing list. Please tell me if this problems were fixed or if a should wait the next version before aiming to a merge:
These problems are gone. I have completely overhauled the internals so that focus always is in sync with the rest of Dillo. Which just happened to fix the problem Sebastian noticed... I'd say, wait a week or so to see if any issues crop up. If all seems OK commit the patch. [ LIST: please give keyboard navigation, on either version of the patch, a workout. This needs some testing if it is to be part of mainstream Dillo. Try it in frame sites, try navigatin between frames with Tab/Shift-Tab, try the keyboard bindings, etc. ] By the way, the patch also contains a fix to a problem with dpid/Makefile.am (which did not honour DESTDIR on installation, messing up make install for non-root users). Let me know when you apply this, because it will affect the tab/frame/kbnav patch s well. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote:
[ LIST: please give keyboard navigation, on either version of the patch, a workout. This needs some testing if it is to be part of mainstream Dillo. Try it in frame sites, try navigatin between frames with Tab/Shift-Tab, try the keyboard bindings, etc. ]
With tab/frame/keynav patch v14, I've been able to get segfaults pretty easily just by moving between links. Here are some sample sites: http://memepool.com (there is a long link on the current page that causes problems) http://notlong.com/links/ (the links in the table appear to be problematic) http://cruel.com (a link about halfway down the current page) http://vikings.com (one of the first links in the main frame) Also, here is an example of a site where the algorithm for determining the direction of the next link breaks down: http://linkfilter.net At the end of each post there are a set of icons which get selected in a non-intuitive order. Paul
Paul Pelzl wrote:
With tab/frame/keynav patch v14, I've been able to get segfaults pretty
easily just by moving between links. Here are some sample sites:
http://memepool.com (there is a long link on the current page that causes problems) http://notlong.com/links/ (the links in the table appear to be problematic) http://cruel.com (a link about halfway down the current page) http://vikings.com (one of the first links in the main frame)
Also, here is an example of a site where the algorithm for determining the direction of the next link breaks down: http://linkfilter.net At the end of each post there are a set of icons which get selected in a non-intuitive order.
Paul
I'll look into these problems... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Paul Pelzl wrote:
On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote:
[ LIST: please give keyboard navigation, on either version of the patch, a workout. This needs some testing if it is to be part of mainstream Dillo. Try it in frame sites, try navigatin between frames with Tab/Shift-Tab, try the keyboard bindings, etc. ]
With tab/frame/keynav patch v14, I've been able to get segfaults pretty easily just by moving between links. Here are some sample sites:
http://memepool.com (there is a long link on the current page that causes problems)
Fixed, was caused by Dw_page_construct_iterator() always returning iterators with mask=DW_CONTENT_ALL. This caused links which contain breaks (<br>) to segfault. I changed Dw_page_construct_iterator() to allow the caller to set a mask.
http://notlong.com/links/ (the links in the table appear to be problematic)
I see what you mean, but this is not that easy to fix. Links are sorted on y.x order using the coordinates for the first word in the link. If you look at the table, you'll notice that 'makeashorterlink.com' starts half a line above all the other links in the table row, while 'ek.dk' starts half a line after the others. This causes those links to appear in this order: makeashorterlink (link DOWN)-> one of the links to the left of it (link DOWN)-> ek.dk I'll see if I can find a simple solution to this problem (use a median coordinate? use a coordinate range?), but I do not think this will be fixed in the next patch.
http://cruel.com (a link about halfway down the current page)
Same problem as memepool.com, fixed
http://vikings.com (one of the first links in the main frame)
Same problem as memepool.com, fixed
Also, here is an example of a site where the algorithm for determining the direction of the next link breaks down: http://linkfilter.net At the end of each post there are a set of icons which get selected in a non-intuitive order.
More or less the same problem as notlong.com, but a slighly different cause. The author of the page did not use width/height tags on one of the icon links (the Stats link), this makes Dillo render the links's alt-text half a line lower. This causes the link shuffle effect you noticed. I might be able to fix this one though by adding another focusable_allocate for images. Might be fixed in next patch. Thanks fo the feedback... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
On Wed, Nov 12, 2003 at 11:00:58AM +0100, Frank de Lange wrote:
http://notlong.com/links/ (the links in the table appear to be problematic)
I see what you mean, but this is not that easy to fix. Links are sorted on y.x order using the coordinates for the first word in the link. If you look at the table, you'll notice that 'makeashorterlink.com' starts half a line above all the other links in the table row, while 'ek.dk' starts half a line after the others. This causes those links to appear in this order:
makeashorterlink (link DOWN)-> one of the links to the left of it (link DOWN)-> ek.dk
I'll see if I can find a simple solution to this problem (use a median coordinate? use a coordinate range?), but I do not think this will be fixed in the next patch.
I think you misunderstand... I ran into a segfault as soon as I hit one of the links in the table. Are you unable to reproduce? Paul
Paul Pelzl wrote:
On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote:
[ LIST: please give keyboard navigation, on either version of the patch, a workout. This needs some testing if it is to be part of mainstream Dillo. Try it in frame sites, try navigatin between frames with Tab/Shift-Tab, try the keyboard bindings, etc. ]
With tab/frame/keynav patch v14, I've been able to get segfaults pretty easily just by moving between links. Here are some sample sites:
http://memepool.com (there is a long link on the current page that causes problems) http://notlong.com/links/ (the links in the table appear to be problematic) http://cruel.com (a link about halfway down the current page) http://vikings.com (one of the first links in the main frame)
Also, here is an example of a site where the algorithm for determining the direction of the next link breaks down: http://linkfilter.net At the end of each post there are a set of icons which get selected in a non-intuitive order.
OK, I fixed this issue as well, by ignoring the individual word size for link allocation. This page now works as you'd expect it to, I'll see if the fix does not adversely affect other sites. If it works out OK consider this issue closed. Cheers//Frank [ who has some time on his hands to fix things at the moment... Anyone looking for an accomplished free software hacker in Västra Götaland, Sweden? ] -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Hi
[ LIST: please give keyboard navigation, on either version of the patch, a workout. This needs some testing if it is to be part of mainstream Dillo. Try it in frame sites, try navigatin between frames with Tab/Shift-Tab, try the keyboard bindings, etc. ]
Here comes a bit of feedback. I haven't found anything new (only cut-n-paste and the history) but only some user issues : - I know this has been discussed before, but the use of Ctrl-Shift-L versus Ctrl-L confuses me almost every time I want to enter a URL manually. I slowly get used to it - damn old habits :-) ... but my point is : how many other users will be confused by this ? Eventually, this will not matter, because all shortcuts can be customized, IIRC. - One thing I love about dillo is/was that it did not open up new windows when the author deemed it necesarry. Now, on some stupid pages I get window after window, just because the author does know nothing about good web design. I realize that it's the strict adherence to the _blank target. I read on the HTML Standard, and I found two points : - they are all "should" rules (6.16). The client should do this and that. - in the Target semantics (16.3.2) the standard allows for the client to override the target. so, IMHO, I would treat _blank (and probably every unknown target) just like _top, unless the user allows dillo via a preference option (in fact I already did this in my personal version of the frames version ;-) ...). This is the same argument as above : keep the current behaviour. Oh, and since I use the same argument twice : I am not saying that new behaviour is bad, just that thinking about keeping the old does not hurt either. Otherwise : so many more pages work now much more pleasantly with the frames support : thanks ! :) Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198
Andreas Schweitzer wrote:
- I know this has been discussed before, but the use of Ctrl-Shift-L versus Ctrl-L confuses me almost every time I want to enter a URL manually. I slowly get used to it - damn old habits :-) ... but my point is : how many other users will be confused by this ? Eventually, this will not matter, because all shortcuts can be customized, IIRC.
I will probably revert back to CTRL-L for link open, CTRL-U for 'focus location bar' (which does the same when popup_dialogs=NO), and use something else for view source (thereby confusing people who are used to Mozilla et al...).
- One thing I love about dillo is/was that it did not open up new windows when the author deemed it necesarry. Now, on some stupid pages I get window after window, just because the author does know nothing about good web design. I realize that it's the strict adherence to the _blank target.
I'll add a preference for that, so it minimizes the number of new pages it opens. Thanks for the feedback! Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
participants (3)
-
Andreas Schweitzer -
Frank de Lange -
Paul Pelzl