why is SELECT a block container in Tags[]?
Why is SELECT a block container rather than an inline container in Tags[]?
On Sat, May 31, 2008 at 03:26:50PM +0000, corvid wrote:
Why is SELECT a block container rather than an inline container in Tags[]?
Most probably by mistake! Given that the DTD says: <!ELEMENT SELECT - - (OPTGROUP|OPTION)+ -- option selector --> [...] <!ELEMENT OPTGROUP - - (OPTION)+ -- option group --> [...] <!ELEMENT OPTION - O (#PCDATA) -- selectable choice --> it looks like inline container would fit better. (and stop some segfaults Justus detected). -- Cheers Jorge.-
Jorge wrote:
On Sat, May 31, 2008 at 03:26:50PM +0000, corvid wrote:
Why is SELECT a block container rather than an inline container in Tags[]?
Most probably by mistake!
Given that the DTD says:
<!ELEMENT SELECT - - (OPTGROUP|OPTION)+ -- option selector --> [...] <!ELEMENT OPTGROUP - - (OPTION)+ -- option group --> [...] <!ELEMENT OPTION - O (#PCDATA) -- selectable choice -->
it looks like inline container would fit better. (and stop some segfaults Justus detected).
Well, it would still provide him with new segfaults for inline stuff like <form> <select> <font color=red>segfault</font> </select> </form>
On Sat, May 31, 2008 at 07:02:02PM +0000, corvid wrote:
Jorge wrote:
On Sat, May 31, 2008 at 03:26:50PM +0000, corvid wrote:
Why is SELECT a block container rather than an inline container in Tags[]?
Most probably by mistake!
Given that the DTD says:
<!ELEMENT SELECT - - (OPTGROUP|OPTION)+ -- option selector --> [...] <!ELEMENT OPTGROUP - - (OPTION)+ -- option group --> [...] <!ELEMENT OPTION - O (#PCDATA) -- selectable choice -->
it looks like inline container would fit better. (and stop some segfaults Justus detected).
Well, it would still provide him with new segfaults for inline stuff like
<form> <select> <font color=red>segfault</font> </select> </form>
BTW, patch committed (now SELECT is an inline container). With regard to further segfaults, quoting myself:
SELECT can be closed in Html_stack_cleanup_at_open(). SELECT can contain OPTGROUP and OPTION.
It would be good to consider the other cases before making a patch.
After Justus sends us a set of segfault cases (with the fuzzy technique) we can try to tackle a general solution. -- Cheers Jorge.-
Jorge wrote:
On Sat, May 31, 2008 at 07:02:02PM +0000, corvid wrote:
Jorge wrote:
On Sat, May 31, 2008 at 03:26:50PM +0000, corvid wrote:
Why is SELECT a block container rather than an inline container in Tags[]?
Most probably by mistake!
Given that the DTD says:
<!ELEMENT SELECT - - (OPTGROUP|OPTION)+ -- option selector --> [...] <!ELEMENT OPTGROUP - - (OPTION)+ -- option group --> [...] <!ELEMENT OPTION - O (#PCDATA) -- selectable choice -->
it looks like inline container would fit better. (and stop some segfaults Justus detected).
Well, it would still provide him with new segfaults for inline stuff like
<form> <select> <font color=red>segfault</font> </select> </form>
BTW, patch committed (now SELECT is an inline container).
Now dillo can't deal with multiple <option>s without </option> in between, e.g., http://www.dillo.org/bugtrack/Dquery.html
On Sun, Jun 01, 2008 at 08:16:49PM +0000, corvid wrote:
Jorge wrote:
On Sat, May 31, 2008 at 07:02:02PM +0000, corvid wrote:
Jorge wrote:
On Sat, May 31, 2008 at 03:26:50PM +0000, corvid wrote:
Why is SELECT a block container rather than an inline container in Tags[]?
Most probably by mistake!
Given that the DTD says:
<!ELEMENT SELECT - - (OPTGROUP|OPTION)+ -- option selector --> [...] <!ELEMENT OPTGROUP - - (OPTION)+ -- option group --> [...] <!ELEMENT OPTION - O (#PCDATA) -- selectable choice -->
it looks like inline container would fit better. (and stop some segfaults Justus detected).
Well, it would still provide him with new segfaults for inline stuff like
<form> <select> <font color=red>segfault</font> </select> </form>
BTW, patch committed (now SELECT is an inline container).
Now dillo can't deal with multiple <option>s without </option> in between, e.g., http://www.dillo.org/bugtrack/Dquery.html
Oh, yes. Patch committed (funny rendering sometimes, no segfault with the above example). It looks simpler to have SELECT as a block container, but I prefer this simple patch because it _is_ an inline container. The decision on what to do with unallowed elements is yet to be made (ignore & warn or close the open container for instance). -- Cheers Jorge.-
Jorge wrote:
On Sat, May 31, 2008 at 07:02:02PM +0000, corvid wrote:
<form> <select> <font color=red>segfault</font> </select> </form>
Patch committed (funny rendering sometimes, no segfault with the above example).
Justus got that sort of segfault because he must have standard_widget_colors set.
participants (2)
-
corvid＠lavabit.com -
jcid＠dillo.org