tests that should not be case-sensitive
I don't want to do anything about this until we get the big patch committed, but I just looked through the str(n)cmp calls in dillo, and I found: - a bunch of cases where we test url strings with the scheme included. - hostname tests in dns.c. I don't know that code at all, though. Is there any reason why it has to treat the hostnames that way? - generic font-family names in styleengine.cc. CSS 2.1 says: "All CSS syntax is case-insensitive within the ASCII range (i.e., [a-z] and [A-Z] are equivalent), except for parts that are not under the control of CSS. For example, the case-sensitivity of values of the HTML attributes "id" and "class", of font names, and of URIs lies outside the scope of this specification. Note in particular that element names are case-insensitive in HTML, but case-sensitive in XML." ...although I know "@charset" has to be lowercase, so this might not be the ultimate answer, but I didn't see anything suggesting otherwise.
Hi, On Wed, Nov 09, 2011 at 02:46:00AM +0000, corvid wrote:
I don't want to do anything about this until we get the big patch committed, but I just looked through the str(n)cmp calls in dillo, and I found:
[...] - hostname tests in dns.c. I don't know that code at all, though. Is there any reason why it has to treat the hostnames that way?
If you mean treating them as case sensitive, no, I don't remember a special reason (although there's a 10% chance or so of it being for a purpose that I forgot). We can try the other way and check if anything breaks. -- Cheers Jorge.-
On Wed, Nov 09, 2011 at 08:01:55AM -0300, Jorge Arellano Cid wrote:
Hi,
On Wed, Nov 09, 2011 at 02:46:00AM +0000, corvid wrote:
I don't want to do anything about this until we get the big patch committed, but I just looked through the str(n)cmp calls in dillo, and I found:
[...] - hostname tests in dns.c. I don't know that code at all, though. Is there any reason why it has to treat the hostnames that way?
If you mean treating them as case sensitive, no, I don't remember a special reason (although there's a 10% chance or so of it being for a purpose that I forgot).
Same here.
We can try the other way and check if anything breaks.
Ack. Cheers, Johannes
On Wed, Nov 09, 2011 at 02:46:00AM +0000, corvid wrote:
I don't want to do anything about this until we get the big patch committed, but I just looked through the str(n)cmp calls in dillo, and I found:
- a bunch of cases where we test url strings with the scheme included.
- hostname tests in dns.c. I don't know that code at all, though. Is there any reason why it has to treat the hostnames that way?
- generic font-family names in styleengine.cc. CSS 2.1 says: "All CSS syntax is case-insensitive within the ASCII range (i.e., [a-z] and [A-Z] are equivalent), except for parts that are not under the control of CSS. For example, the case-sensitivity of values of the HTML attributes "id" and "class", of font names, and of URIs lies outside the scope of this specification. Note in particular that element names are case-insensitive in HTML, but case-sensitive in XML." ...although I know "@charset" has to be lowercase, so this might not be the ultimate answer, but I didn't see anything suggesting otherwise.
Right. Firefox also seems to accept font-family:MONOSPACE Cheers, Johannes
I wrote:
- a bunch of cases where we test url strings with the scheme included.
This seems to work all right for me, anyway. As for whether it really makes sense to test for dpi scheme in some of the DPIs, or whether I should care about URL_AUTHORITY anywhere, I'm not certain...
participants (4)
-
corvid@lavabit.com
-
jcid@dillo.org
-
Johannes.Hofmann@gmx.de
-
johannes.hofmann@gmx.de