patch: MSG* macros (Re: patch: default home dir)
Jorge wrote:
On Fri, May 15, 2009 at 11:06:33PM +0000, corvid wrote:
BTW, is there a reason why MSG_HTTP doesn't have an "if (prefs.show_msg)"?
Not much of a reason. IIRC sometime ago I regarded those as "more important", or at least they should be visible before searching bugs from the parser and up.
And is there a reason why only MSG gets a fflush?
Most probably in a debugging session, important messages were beong buffered and so the flush.
I'd say yes, let's have the fflush and prefs.show_msg act on all of them. Patch is welcomed! :)
I'm sending this to the list in case I'm doing something clumsy or dangerous. It's working for me, anyway.
I wrote:
+#define MSG(...) MSG_INNARDS(, __VA_ARGS__)
Even though the gnu cpp info page made it ever so clear that this was just fine -- without saying anything about it being an extension -- I see some discussion around on the web that makes it seem either undefined or wrong in C90, all right in C99, and I'm not sure about C++. In any case, the sensible thing to do would be to stick a "" in there and be done with it.
participants (1)
-
corvid＠lavabit.com