Hi, On Sat, Jan 19, 2008 at 02:47:43AM +0000, place wrote:
It caused stripes along the sides of images with vspace and hspace.
The line numbers of the patch are off because my image.cc is somewhat hacked up, but who cares for a one-liner...
diff -pur dw2/dw/image.cc dw2-cur/dw/image.cc --- dw2/dw/image.cc 2007-12-24 06:17:14.000000000 +0000 +++ dw2-cur/dw/image.cc 2008-01-19 02:18:15.000000000 +0000 @@ -263,7 +263,7 @@ void Image::drawRow (int row)
buffer->getRowArea (row, &area); if (area.width && area.height) - queueDrawArea (area.x + getStyle()->boxOffsetY (), + queueDrawArea (area.x + getStyle()->boxOffsetX (), area.y + getStyle()->boxOffsetY (), area.width, area.height); }
Committed. Now that you're images, would you mind giving a look to these anomalies? http://www.dillo.org/test/img/ 1.- n1 renders a right column with old background (over dialup). 2.- n2 makes space inside the link, not outside, and renders different image size the first time (e.g. when from local harddisk); after back and forward size changes. 3.- n3 is obviously wrong! ;) -- Cheers Jorge.-
Jorge wrote:
Now that you're images, would you mind giving a look to these anomalies?
Ah, the ancient programming principle that The one who touched it last owns it. I have met with this before :) And a sobering thought, now, glancing at the changelog...
http://www.dillo.org/test/img/
1.- n1 renders a right column with old background (over dialup).
I couldn't tell what this one was supposed to be doing wrong.
2.- n2 makes space inside the link, not outside, and renders different image size the first time (e.g. when from local harddisk); after back and forward size changes. 3.- n3 is obviously wrong! ;)
I don't really know what is going on with allocation and requisition and all of this drawing business, but I did find that after - requisition->width += getStyle()->boxDiffHeight (); + requisition->width += getStyle()->boxDiffWidth (); in my Image::sizeRequestImpl -- which didn't seem to change anything, but sure _sounds_ sensible, and diff -pur dw2/dw/textblock.cc dw2-cur/dw/textblock.cc --- dw2/dw/textblock.cc 2007-12-20 20:02:20.000000000 +0000 +++ dw2-cur/dw/textblock.cc 2008-01-19 18:31:26.000000000 +0000 @@ -339,12 +339,12 @@ void Textblock::sizeAllocateImpl (core:: childAllocation.y = lineYOffsetCanvasAllocation (line, allocation) + (line->ascent - word->size.ascent) - - word->content.widget->getStyle()->margin.top; +; // - word->content.widget->getStyle()->margin.top; childAllocation.width = word->size.width; childAllocation.ascent = word->size.ascent - + word->content.widget->getStyle()->margin.top; +; // + word->content.widget->getStyle()->margin.top; childAllocation.descent = word->size.descent - + word->content.widget->getStyle()->margin.bottom; +; // + word->content.widget->getStyle()->margin.bottom; word->content.widget->sizeAllocate (&childAllocation); break; the problem went away for those cases, at least. But as for whether it's supposed to be like this or the margins should be included and something else is supposed to be subtracting them somewhere, I have no idea. I was led in this direction by finding that allocation.y was -95 somewhere in image.cc with n3, which just sounded wrong.
participants (2)
-
jcid＠dillo.org -
place＠gobigwest.com