I committed a safe fix for libpng-1.4, but it means that configure.in currently has: dnl Check if the user hasn't set the variable $PNG_CONFIG if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng14-config` if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng12-config` fi if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng-config` fi if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng10-config` fi fi and case $png_version in 1.4.*) AC_MSG_RESULT([$png_version (newer version)]) ;; 1.2.*) AC_MSG_RESULT([$png_version (newer version)]) ;; 1.0.*) AC_MSG_RESULT([$png_version (older version)]) ;; *) AC_MSG_RESULT([ERROR]) ;; esac I would strongly prefer to rip out most of that `which` stuff and just look for libpng-config. Does anyone know that this would be a bad idea? Whatever libpng-config is symlinked to is presumably what the user wants us to use...
On Fri, Feb 19, 2010 at 09:41:54PM +0000, corvid wrote:
I committed a safe fix for libpng-1.4, but it means that configure.in currently has:
dnl Check if the user hasn't set the variable $PNG_CONFIG if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng14-config` if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng12-config` fi if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng-config` fi if test -z "$PNG_CONFIG"; then PNG_CONFIG=`which libpng10-config` fi fi
and case $png_version in 1.4.*) AC_MSG_RESULT([$png_version (newer version)]) ;; 1.2.*) AC_MSG_RESULT([$png_version (newer version)]) ;; 1.0.*) AC_MSG_RESULT([$png_version (older version)]) ;; *) AC_MSG_RESULT([ERROR]) ;; esac
I would strongly prefer to rip out most of that `which` stuff and just look for libpng-config. Does anyone know that this would be a bad idea? Whatever libpng-config is symlinked to is presumably what the user wants us to use...
AFAIR this has been hard to get working for all cases. Libpng is quite tricky on different platforms. Beware of the sleeping dragon! -- Cheers Jorge.-
Jorge wrote:
On Fri, Feb 19, 2010 at 09:41:54PM +0000, corvid wrote:
I would strongly prefer to rip out most of that `which` stuff and just look for libpng-config. Does anyone know that this would be a bad idea? Whatever libpng-config is symlinked to is presumably what the user wants us to use...
AFAIR this has been hard to get working for all cases. Libpng is quite tricky on different platforms.
Beware of the sleeping dragon!
Do you remember any details? I poked around in good old cvs and the list archives, and there wasn't really any information preserved.
On Fri, Feb 19, 2010 at 09:55:14PM +0000, corvid wrote:
Jorge wrote:
On Fri, Feb 19, 2010 at 09:41:54PM +0000, corvid wrote:
I would strongly prefer to rip out most of that `which` stuff and just look for libpng-config. Does anyone know that this would be a bad idea? Whatever libpng-config is symlinked to is presumably what the user wants us to use...
AFAIR this has been hard to get working for all cases. Libpng is quite tricky on different platforms.
Beware of the sleeping dragon!
Do you remember any details? I poked around in good old cvs and the list archives, and there wasn't really any information preserved.
I remember some OSes had the new version of libpng but no libpng-config. Other systems had both versions of libpng installed and an environment variable helped to choose which one to link against. Ah, almost forgot, different systems had different names for libpng-config (hence the which statements). If you want to try a different approach to png detection, people usually start complaining once the patch is committed, or later at release time. :) -- Cheers Jorge.-
participants (2)
-
corvid＠lavabit.com -
jcid＠dillo.org