[patch]: fix leak in a_Cookies_get_query()
This patch stops a_Cookies_get_query() leaking. However, I'm a little puzzled by the logic here. Why does a_Cookies_get_query() return a "Cookies2" header even if the cookies DPI returns nothing? Can't it just return NULL or an empty string? Wouldn't that be cleaner? Regards, Jeremy Henty
Jeremy wrote:
This patch stops a_Cookies_get_query() leaking. However, I'm a little puzzled by the logic here. Why does a_Cookies_get_query() return a "Cookies2" header even if the cookies DPI returns nothing? Can't it just return NULL or an empty string? Wouldn't that be cleaner?
We return it if we are willing to accept cookies from the server. It indicates that dillo accepts the newer-style cookies. If we don't really want any cookies from them anyway, we return an empty string.
On Thu, Feb 05, 2009 at 08:12:25PM +0000, corvid wrote:
Jeremy wrote:
Why does a_Cookies_get_query() return a "Cookies2" header even if the cookies DPI returns nothing? [...]
We return it if we are willing to accept cookies from the server. It indicates that dillo accepts the newer-style cookies. If we don't really want any cookies from them anyway, we return an empty string.
OK, thanks for the explanation. Jeremy Henty
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
onepoint＠starurchin.org