Two bugs in the Dillo GUI (both Mac and ubuntu)
Back in June, reza wrote:
4. This one is more of a feature request. Like most Mac applications, the shortcuts should work with Command key instead of control key. (I know it's low priority, and I might give it a shot myself later on).
I'm wondering whether it would be helpful to mention in keysrc that meta = command, or would that already be known by (or at least exceedingly obvious to) everyone using osx? BTW, 1.3 has #ifdef __APPLE__ # define FL_COMMAND FL_META ///< An alias for FL_CTRL on WIN32 and X11, or FL_META on MacOS X # define FL_CONTROL FL_CTRL ///< An alias for FL_META on WIN32 and X11, or FL_CTRL on MacOS X #else # define FL_COMMAND FL_CTRL ///< An alias for FL_CTRL on WIN32 and X11, or FL_META on MacOS X # define FL_CONTROL FL_META ///< An alias for FL_META on WIN32 and X11, or FL_CTRL on MacOS X #endif // __APPLE__ although I don't think this can do us any good in our circumstances.
I wrote:
Back in June, reza wrote:
4. This one is more of a feature request. Like most Mac applications, the shortcuts should work with Command key instead of control key. (I know it's low priority, and I might give it a shot myself later on).
I'm wondering whether it would be helpful to mention in keysrc that meta = command, or would that already be known by (or at least exceedingly obvious to) everyone using osx?
By the way, the only mention of FL_META in Fl_x.cxx is # ifdef __sgi // get the meta key off PC keyboards: if (fl_key_vector[18]&0x18) Fl::e_state |= FL_META; # endif I'd assumed that, for FLTK under X, Meta was a synonym for Alt, or maybe the windows keys or something (which I don't have).
I wrote:
By the way, the only mention of FL_META in Fl_x.cxx is
# ifdef __sgi // get the meta key off PC keyboards: if (fl_key_vector[18]&0x18) Fl::e_state |= FL_META; # endif
I'd assumed that, for FLTK under X, Meta was a synonym for Alt, or maybe the windows keys or something (which I don't have).
Can anyone with windows keys verify that they don't set FL_META? There _is_ code for: // For the first few years, there wasn't a good consensus on what the // Windows keys should be mapped to for X11. So we need to help out a // bit and map all variants to the same FLTK key... switch (keysym) { case XK_Meta_L: case XK_Hyper_L: case XK_Super_L: keysym = FL_Meta_L; break; case XK_Meta_R: case XK_Hyper_R: case XK_Super_R: keysym = FL_Meta_R; break; } and maybe there's something going on somewhere that I haven't noticed. I ask because perhaps we'll want to open an STR to get FL_META set.
I wrote:
Can anyone with windows keys verify that they don't set FL_META? There _is_ code for:
// For the first few years, there wasn't a good consensus on what the // Windows keys should be mapped to for X11. So we need to help out a // bit and map all variants to the same FLTK key... switch (keysym) { case XK_Meta_L: case XK_Hyper_L: case XK_Super_L: keysym = FL_Meta_L; break; case XK_Meta_R: case XK_Hyper_R: case XK_Super_R: keysym = FL_Meta_R; break; }
and maybe there's something going on somewhere that I haven't noticed. I ask because perhaps we'll want to open an STR to get FL_META set.
I think I see what happens. On X (well, x.org, anyway), it apparently comes through for free as the Mod4Mask bit in XButtonEvent.state, so expecting to see the word 'meta' somewhere was no good.
participants (1)
-
corvid＠lavabit.com