On Thu, Jul 03, 2008 at 04:14:31PM +0200, Johannes Hofmann wrote:

On Wed, Jul 02, 2008 at 07:14:31PM -0400, Jorge Arellano Cid wrote:

...

On Wed, Jul 02, 2008 at 10:38:51PM +0200, Johannes Hofmann wrote:

...

Hi,

attached patch uses delete[] for deleting arrays as required by C++.

Committed.

Hey, a quick test showed memory usage reduction!

Ah nice. Didn't notice that.

But it's quite significative! Around 12% reduction on VSZ and 13% on RSS. And the combined effect of all the memory reduction patches has come to reduce around 50% on RSS and 28% on VSZ in dillo2. Furthermore, when comparing dillo2 with dillo1, dillo2 uses near 45% less memory than dillo1. These are interesting figures. Below is an updated table of the huge page memory usage test case: ----------- Bck/Fwd test %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 9672 4144 pts/10 S+ 09:37 0:00 ./dillo-fltk.19Jun bare 0.2 10376 4756 pts/10 S+ 09:37 0:00 ./dillo-fltk.19Jun dir list 6.9 176176 144776 pts/10 S+ 09:37 0:02 ./dillo-fltk.19Jun huge page 5.4 123556 113216 pts/10 S+ 09:37 0:02 ./dillo-fltk.19Jun back 7.0 176176 146240 pts/10 S+ 09:37 0:05 ./dillo-fltk.19Jun forward 5.6 127020 117720 pts/10 S+ 09:37 0:05 ./dillo-fltk.19Jun back 7.0 176172 146240 pts/10 S+ 09:37 0:07 ./dillo-fltk.19Jun forward 5.6 127016 117716 pts/10 S+ 09:37 0:08 ./dillo-fltk.19Jun back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 9672 4140 pts/10 S+ 09:26 0:00 ./dillo-fltk.21Jun bare 0.2 10376 4760 pts/10 S+ 09:26 0:00 ./dillo-fltk.21Jun dir list 5.9 147904 123988 pts/10 S+ 09:31 0:02 ./dillo-fltk.21Jun huge page 4.9 111668 101944 pts/10 S+ 09:31 0:02 ./dillo-fltk.21Jun back 6.0 147780 124792 pts/10 S+ 09:31 0:05 ./dillo-fltk.21Jun forward 5.0 115008 105780 pts/10 S+ 09:31 0:05 ./dillo-fltk.21Jun back 6.0 147780 124856 pts/10 S+ 09:31 0:07 ./dillo-fltk.21Jun forward 5.1 115008 105844 pts/10 S+ 09:31 0:07 ./dillo-fltk.21Jun back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 9676 4084 pts/10 S+ 11:16 0:00 ./dillo-fltk bare 0.2 10464 4768 pts/10 S+ 11:17 0:00 ./dillo-fltk dir list 5.4 136960 112920 pts/10 S+ 11:17 0:04 ./dillo-fltk huge page 4.3 100724 90864 pts/10 S+ 11:17 0:04 ./dillo-fltk back 5.4 136952 113756 pts/10 S+ 11:17 0:09 ./dillo-fltk forward 4.5 104180 94744 pts/10 S+ 11:17 0:09 ./dillo-fltk back 5.4 136888 113776 pts/10 S+ 11:17 0:13 ./dillo-fltk forward 4.5 104116 94764 pts/10 S+ 11:17 0:14 ./dillo-fltk back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.2 9676 4156 pts/13 S+ 14:57 0:00 ./dillo-fltk.03Jul bare 0.2 10300 4588 pts/13 S+ 14:57 0:00 ./dillo-fltk.03Jul dir list 5.0 114852 104808 pts/13 S+ 14:57 0:02 ./dillo-fltk.03Jul huge page 3.9 92196 82840 pts/13 S+ 14:57 0:02 ./dillo-fltk.03Jul back 5.1 117348 107284 pts/13 S+ 14:57 0:04 ./dillo-fltk.03Jul forward 3.9 92260 82972 pts/13 S+ 14:57 0:05 ./dillo-fltk.03Jul back 5.1 117364 107300 pts/13 S+ 14:57 0:07 ./dillo-fltk.03Jul forward 3.9 92260 82972 pts/13 S+ 14:57 0:07 ./dillo-fltk.03Jul back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 8408 3524 pts/10 S+ 10:59 0:00 ./dillo1 bare 0.1 24788 3564 pts/10 S+ 11:01 0:00 ./dillo1 dir list 8.7 226996 182220 pts/10 S+ 11:01 0:07 ./dillo1 huge page 6.8 165880 141792 pts/10 S+ 11:01 0:09 ./dillo1 back 8.8 226952 184176 pts/10 S+ 11:01 0:17 ./dillo1 forward 6.9 166264 144024 pts/10 S+ 11:01 0:18 ./dillo1 back 8.8 226968 184216 pts/10 S+ 11:01 0:26 ./dillo1 forward 6.9 166264 144060 pts/10 S+ 11:01 0:27 ./dillo1 back -- Cheers Jorge.-