Dear Dillo developers, I use the "view page source" function from the right-click popup menu very often and so I created a key binding for this (see attached patch). Since I find this very handy, please consider this patch for the repository. Kind regards, Alex
Alexander wrote:
I use the "view page source" function from the right-click popup menu very often and so I created a key binding for this (see attached patch). Since I find this very handy, please consider this patch for the repository.
This would be good to have. I was thinking that the key check might fit more naturally in UI::handle() rather than CustTabs::handle(), but I see that ui.cc doesn't currently know anything about nav or history, so now I'm not sure...
On Wed, Sep 19, 2012 at 09:06:22PM +0000, corvid wrote:
I was thinking that the key check might fit more naturally in UI::handle() rather than CustTabs::handle(), but I see that ui.cc doesn't currently know anything about nav or history, so now I'm not sure...
If it is not fundamental a design decision to leave ui.cc blind for the nav and the history, one can include nav.h and history.h in ui.cc and move the key check there (see attached patch). Best, Alex
On Wed, Sep 19, 2012 at 09:06:22PM +0000, corvid wrote:
Alexander wrote:
I use the "view page source" function from the right-click popup menu very often and so I created a key binding for this (see attached patch). Since I find this very handy, please consider this patch for the repository.
This would be good to have.
I'd also like to have that feature. Cheers, Johannes
On Thu, Sep 20, 2012 at 08:45:08PM +0200, Johannes Hofmann wrote:
On Wed, Sep 19, 2012 at 09:06:22PM +0000, corvid wrote:
Alexander wrote:
I use the "view page source" function from the right-click popup menu very often and so I created a key binding for this (see attached patch). Since I find this very handy, please consider this patch for the repository.
This would be good to have.
I'd also like to have that feature.
+1 I also assume that ctrl+u is kind of standard, or at least an unused keystroke combination. As for where the check should go inside the code, just follow the other keybindings. I wrote the GUI and the keycheck code, and AFAIR there were issues with FLTK and they ended being as they are for different reasons. If after reading the code you're still unsure about where it belongs, just let me know to dig in. BTW, as you use viewsource very often, what do you like best for displayed HTML lines, one long scrollable line or wrapping? I tend to prefer wrapping, for readability, but probably you can share a deeper experience. -- Cheers Jorge.-
Jorge Arellano Cid wrote:
BTW, as you use viewsource very often, what do you like best for displayed HTML lines, one long scrollable line or wrapping?
Pardon me for butting in here, but I use view source quite a lot and I would definitely prefer wrapping. (Is wrapping supported at the moment?) Many Web sites ship HTML with absurdly long lines which makes viewing their source practically impossible - horizontal scrolling is very little help when the line is around 50 screen widths long (sadly this is not an exaggeration). Regards, Jeremy Henty
Jeremy wrote:
Jorge Arellano Cid wrote:
BTW, as you use viewsource very often, what do you like best for displayed HTML lines, one long scrollable line or wrapping?
Pardon me for butting in here, but I use view source quite a lot and I would definitely prefer wrapping. (Is wrapping supported at the moment?) Many Web sites ship HTML with absurdly long lines which makes viewing their source practically impossible - horizontal scrolling is very little help when the line is around 50 screen widths long (sadly this is not an exaggeration).
I strongly prefer wrapping as well.
Hi. Jeremy Henty wrote:
Jorge Arellano Cid wrote:
BTW, as you use viewsource very often, what do you like best for displayed HTML lines, one long scrollable line or wrapping?
Pardon me for butting in here, but I use view source quite a lot and I would definitely prefer wrapping. (Is wrapping supported at the moment?) Many Web sites ship HTML with absurdly long lines which makes viewing their source practically impossible - horizontal scrolling is very little help when the line is around 50 screen widths long (sadly this is not an exaggeration).
I also like line wrapping more than scrolling horizontally. When you want to read the HTML code with long lines, it is more convenient to have only one scrolling direction (vertically) instead of two (vertically + horizontally). Best, Alex
Jorge wrote:
On Thu, Sep 20, 2012 at 08:45:08PM +0200, Johannes Hofmann wrote:
On Wed, Sep 19, 2012 at 09:06:22PM +0000, corvid wrote:
Alexander wrote:
I use the "view page source" function from the right-click popup menu very often and so I created a key binding for this (see attached patch). Since I find this very handy, please consider this patch for the repository.
This would be good to have.
I'd also like to have that feature.
+1
Committed.
participants (5)
-
corvid＠lavabit.com -
Hole.destructor＠gmx.de -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
onepoint＠starurchin.org