I've been studying the DPI code (hoping to work on SSL) and I noticed that installing dpidrc is rather hacky. The info page "(automake.info) Scripts" describes a standard way to do this using a template. This is simpler because we only explicitly code the build rule in Makefile.am and automake installs it as normal, so there's no messing around with $(datadir), $(DESTDIR) etc. Also, changes such as making the https dpi into a server rather than a filter will only affect the template and won't require changing Makefile.am. The patch is attached. It creates a new source file dpid/dpidrc.in which must be added to CVS. Regards, Jeremy Henty
On Mon, Oct 27, 2008 at 02:16:50PM +0000, Jeremy Henty wrote:
I've been studying the DPI code (hoping to work on SSL) and I noticed that installing dpidrc is rather hacky. The info page "(automake.info) Scripts" describes a standard way to do this using a template. This is simpler because we only explicitly code the build rule in Makefile.am and automake installs it as normal, so there's no messing around with $(datadir), $(DESTDIR) etc. Also, changes such as making the https dpi into a server rather than a filter will only affect the template and won't require changing Makefile.am.
The patch is attached. It creates a new source file dpid/dpidrc.in which must be added to CVS.
Good! Committed. -- Cheers Jorge.-
participants (2)
-
jcid@dillo.org
-
onepoint@starurchin.org