Splitting html.cc: common functions, part 1
This patch moves some function declarations from html.cc to html_common.hh . It only does *some* of the renaming because the full patch breaks the list's moderation limit. I'll follow up to this message with the rest of the renaming. You may want to batch this patch and the followup together as a single commit. Please comment! Jeremy Henty
<headslap> Here's the patch. The followup to *this* will complete the renaming. Jeremy Henty
The rest of the renaming. Jeremy Henty
Hi Jeremy, On Thu, Jun 05, 2008 at 06:25:33PM +0100, Jeremy Henty wrote:
This patch moves some function declarations from html.cc to html_common.hh . It only does *some* of the renaming because the full patch breaks the list's moderation limit. I'll follow up to this message with the rest of the renaming. You may want to batch this patch and the followup together as a single commit.
Please comment!
With regard to big patches and splitting, please don't burden yourself with splitting. This is just cleanup so please send me one big patch to my email address not dillo-dev. After applying thwe full patchset, I got compiler errors. :( <quote> g++ -DHAVE_CONFIG_H -I. -I.. -DDILLORC_SYS='"/usr/local/etc/dillorc"' -I/usr/local/include -I../../dw-testbed -I/usr/include/libpng12 -I/usr/local/include -I/usr/include/freetype2 -Wno-non-virtual-dtor -g -O2 -Wall -W -Wno-unused-parameter -MT form.o -MD -MP -MF .deps/form.Tpo -c -o form.o form.cc form.cc: In member function 'void DilloHtmlInput::reset()': form.cc:1413: error: jump to case label form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1414: error: jump to case label form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1419: error: jump to case label form.cc:1415: error: crosses initialization of 'dw::core::ui::ToggleButtonResource* tb_r' form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1434: error: jump to case label form.cc:1415: error: crosses initialization of 'dw::core::ui::ToggleButtonResource* tb_r' form.cc:1409: error: crosses initialization of 'dw::core::ui::EntryResource* entryres' form.cc:1449: error: jump to case label [...] </quote> To solve this problem, please send me one big patch with all the changes. I'm not committing anything yet. -- Cheers Jorge.-
compiler errors: I think it's that Jeremy is using gcc3 and not seeing those errors.
On Fri, Jun 06, 2008 at 04:29:02PM +0000, corvid wrote:
compiler errors: I think it's that Jeremy is using gcc3 and not seeing those errors.
Yes, it looks very much like something we have seen before where gcc4 wants the scope of variables initialised in switch statements to be restricted to one branch of the switch. In reset() that's already been done to the case DILLO_HTML_INPUT_FILE: branch lower down. I'll fix up the other branches and send a mega-patch privately. Regards, Jeremy Henty
On Fri, Jun 06, 2008 at 06:53:58PM +0100, Jeremy Henty wrote:
On Fri, Jun 06, 2008 at 04:29:02PM +0000, corvid wrote:
compiler errors: I think it's that Jeremy is using gcc3 and not seeing those errors.
I'll fix up the other branches and send a mega-patch privately.
Done. Thanks to corvid for reminding me that we had seen this before. Are there any gcc flags I could set to stop stuff like this getting through? Regards, Jeremy Henty
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
onepoint＠starurchin.org