[PATCH]: a_Dpiapi_dialog should call a_Dialog_choice3 with 3 parameters
a_Dpiapi_dialog() calls a_Dialog_choice3() with 2 parameters instead of 3. This causes the dialog to pop up a third button with a garbage label, and valgrind reports 'Conditional jump or move depends on uninitialised value(s)' from inside FLTK. Patch attached. This bug slipped through because dpiapi.c does not include dialog.hh to get the prototype of a_Dialog_choice3() . I'm not sure how to fix this: should a C source file be including a C++ header? If not, how else can dpiapi.c get the prototype? Regards, Jeremy Henty
To clarify, this patch is a fix to Christian Kellermann's https patch, so it naturally depends on it. Jeremy Henty
* Jeremy Henty <onepoint@starurchin.org> [080315 13:54]:
a_Dpiapi_dialog() calls a_Dialog_choice3() with 2 parameters instead of 3. This causes the dialog to pop up a third button with a garbage label, and valgrind reports 'Conditional jump or move depends on uninitialised value(s)' from inside FLTK. Patch attached.
This bug slipped through because dpiapi.c does not include dialog.hh to get the prototype of a_Dialog_choice3() . I'm not sure how to fix this: should a C source file be including a C++ header? If not, how else can dpiapi.c get the prototype?
Ah thanks! I add it to step 2 :) In the meantime you need to apply this again to my updated version of step 1. You were faster than me :) Kind regards, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)
On Sat, Mar 15, 2008 at 02:04:32PM +0100, Christian Kellermann wrote:
Ah thanks! I add it to step 2 :) In the meantime you need to apply this again to my updated version of step 1.
OK, here's an updated fix for your updated step 1. Regards, Jeremy Henty
participants (2)
-
Christian.Kellermann＠nefkom.net -
onepoint＠starurchin.org