Re: [Dillo-dev] [PATCH] version 1 of keyboard navigation patch
Glyn Kennington wrote:
I like most of it. But after a very short time, I've found some things
that I think need improving. So, in order of decreasing importance:
1) I've found a bug that will cause dillo to crash:
Go to a page whose first link is in an alt-tagged image. (The one I've been using for this bugreport is www.guardian.co.uk .)
Press the key for `link DOWN'. This will make the image link the current link (status bar reads "http://www.guardian.co.uk/0,6961,,00.html")
Go to another page. This can be by clicking Home, Back etc, typing in another URL, or activating a link on the current page.
Once dillo is about to start rendering the new page, it dies with a segfault. gdb tells me that it's at the end of Dw_image_destroy(): g_free (image->alt_text);
This crash still occurs if I move to the next link (outside the image) before going to a different page.
I have not been able to reproduce this yet, will try again and fix anything I find... But, as stated, it does not happen here... Could have something to do with your next remark? [ LIST: has anyone else seen this? ]
2) Patching problems. I know the email said `use cvs 14/10/2003', but the patch filename includes the string 20031015, so I attempted to patch against my just-updated checkout. This normally wouldn't be a problem over the course of only a day, but today there was some change to the arguments of a_Commands_set_selection which broke the patch. If you could include on your webpage the exact date and time of the CVS checkout, near the link to the patch, it would probably prevent this sort of confusion from happening again.
Hmmm... tricky. I'll add a GMT date/time to the CVS version to be used. The date-string on the patch is autogenerated by my patch scripts, it just tells the date I made a release. It is not necessarily related to the CVS date the patch is based on. Sometimes I make incremental changes to a patch without updating CVS.
3) The TODO mentions more bindings. Do you intend to make Back bindable?
I intend to make everything bindable. That is, everything which can be bound. That is 'the GTK+ way' of doing things... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
On Thu, 16 Oct 2003 13:13:04 +0200 Frank de Lange <frank@unternet.org> wrote:
I have not been able to reproduce this yet, will try again and fix anything I find... But, as stated, it does not happen here... Could have something to do with your next remark?
[ LIST: has anyone else seen this? ]
No, I can't reproduce this. - Victor
Frank de Lange wrote:
[segfault involving links in alt tags] I have not been able to reproduce this yet, will try again and fix anything I find... But, as stated, it does not happen here... Could have something to do with your next remark?
[patches not applying cleanly]
Well, as no-one else seemed affected, I tried again with a couple more timestamps on cvs. I found a tree to which the patch would apply cleanly (no fuzz factor, no offsets), and yes, the bug had disappeared. (My broken version also didn't shade the images when they were selected - a feature I didn't know I was missing.) I'll take a closer look at some of the cvs changes before my broken version, but it's probably nothing serious. Glyn -- glyn.kennington@ox.compsoc.net
participants (3)
-
Frank de Lange
-
Glyn Kennington
-
Victor Sahlstedt