There's a new "scroll_step" option in the example configuration file for 3.1.0-rc1. The comment "Mouse wheel scroll step in pixels" suggests that this only affects the mouse wheel, but it also changes the distance the page moves when the arrow keys are pressed and the overlap of previous page content that's left when you press Page Up/Down. I think that's a little confusing, especially as the value has changed since the default behaviour in 3.0.5 (the old value seems to have been about 25).
Hi, On Sat, Apr 20, 2024 at 01:54:26PM +1000, Kevin Koster wrote:
There's a new "scroll_step" option in the example configuration file for 3.1.0-rc1. The comment "Mouse wheel scroll step in pixels" suggests that this only affects the mouse wheel, but it also changes the distance the page moves when the arrow keys are pressed and the overlap of previous page content that's left when you press Page Up/Down. I think that's a little confusing, especially as the value has changed since the default behaviour in 3.0.5 (the old value seems to have been about 25).
Thanks, I agree. Could you provide a patch? Please consider reviewing the manual on that topic[1], in case some parts need to be clarified too. [1]:https://dillo-browser.github.io/user_help.html#scrolling Best, Rodrigo.
On Sat, 20 Apr 2024 14:19:32 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
On Sat, Apr 20, 2024 at 01:54:26PM +1000, Kevin Koster wrote:
There's a new "scroll_step" option in the example configuration file for 3.1.0-rc1. The comment "Mouse wheel scroll step in pixels" suggests that this only affects the mouse wheel, but it also changes the distance the page moves when the arrow keys are pressed and the overlap of previous page content that's left when you press Page Up/Down. I think that's a little confusing, especially as the value has changed since the default behaviour in 3.0.5 (the old value seems to have been about 25).
Thanks, I agree. Could you provide a patch?
OK, see the attached dillorc_scroll_step_description.patch (applied directly to the file, eg. "patch dillo/dillorc < dillorc_scroll_step_description.patch"). The patch also includes a fix for a misspelling of "differentiates" in a later comment there.
Please consider reviewing the manual on that topic[1], in case some parts need to be clarified too. [1]:https://dillo-browser.github.io/user_help.html#scrolling
I'd only add that a scroll_step is subtracted from the Pg. Up/Down movement, as I've done in the other attached patch (user_help_page_step.patch).
Hi, On Mon, Apr 22, 2024 at 09:38:19AM +1000, Kevin Koster wrote:
Thanks, I agree. Could you provide a patch?
OK, see the attached dillorc_scroll_step_description.patch (applied directly to the file, eg. "patch dillo/dillorc < dillorc_scroll_step_description.patch"). The patch also includes a fix for a misspelling of "differentiates" in a later comment there.
I'd only add that a scroll_step is subtracted from the Pg. Up/Down movement, as I've done in the other attached patch (user_help_page_step.patch).
--- dillo/dillorc 2024-04-21 22:30:16.000000000 +1000 +++ dillo_mod/dillorc 2024-04-21 23:22:36.666672639 +1000 @@ -40,7 +40,10 @@ # Set your default directory for download/save operations #save_dir=/tmp
-# Mouse wheel scroll step in pixels +# Set the increment in pixels that the page is moved up/down with each input +# from the mouse wheel, keyboard arrow keys, or scrollbar arrow buttons. +# Page movement with the Page Up/Down keys is one scroll_step less than the +# height of the visible page area. #scroll_step=100
#------------------------------------------------------------------------- @@ -89,7 +92,7 @@ # If this is set to YES, all CSS size specifications for tables are # adjusted so that all contents can be displayed. This is seperated # from "adjust_min_width" so that it is able to mimic Firefox, which -# differenciates between tables and, say, textblocks (in some cases). +# differentiates between tables and, say, textblocks (in some cases). #adjust_table_min_width=YES
#-------------------------------------------------------------------------
--- dillo/doc/user_help.html 2024-04-21 23:20:19.319997475 +1000 +++ dillo_mod/doc/user_help.html 2024-04-21 23:19:01.916659356 +1000 @@ -177,7 +177,7 @@ <li>Use the <code>Home</code> or <code>End</code> keys to jump to the top or to the end of a page.</li> <li>Use <code>PgUp</code> or <code>PgDn</code> to advance a whole - <em>page</em> (window size).</li> + <em>page</em> (window size) minus one <em>step</em>.</li> <li>Use the arrow keys to move the view a <em>step</em> in that direction.</li> <li>You can also use the <code>Space</code> key as <code>PgDn</code> and
Thanks, I added them in this PR: https://github.com/dillo-browser/dillo/pull/142 Best, Rodrigo.
On Thu, Apr 25, 2024 at 09:52:50PM +0200, Rodrigo Arias wrote:
Thanks, I added them in this PR:
Merged in: https://github.com/dillo-browser/dillo/commit/52110e1ea2a50e91e66bd049811036... Rodrigo.
Hi, On Sat, Apr 20, 2024 at 01:54:26PM +1000, Kevin Koster wrote:
There's a new "scroll_step" option in the example configuration file for 3.1.0-rc1. The comment "Mouse wheel scroll step in pixels" suggests that this only affects the mouse wheel, but it also changes the distance the page moves when the arrow keys are pressed and the overlap of previous page content that's left when you press Page Up/Down. I think that's a little confusing, especially as the value has changed since the default behaviour in 3.0.5 (the old value seems to have been about 25).
This is now controlled independently with the scroll_page_overlap, which by default uses the value 50 px. While the scroll_step controls how much it advances with the arrows, by default 100 pixels. See: https://github.com/dillo-browser/dillo/pull/277 Best, Rodrigo.
Rodrigo Arias wrote:
On Sat, Apr 20, 2024 at 01:54:26PM +1000, Kevin Koster wrote:
There's a new "scroll_step" option in the example configuration file for 3.1.0-rc1. The comment "Mouse wheel scroll step in pixels" suggests that this only affects the mouse wheel, but it also changes the distance the page moves when the arrow keys are pressed and the overlap of previous page content that's left when you press Page Up/Down. I think that's a little confusing, especially as the value has changed since the default behaviour in 3.0.5 (the old value seems to have been about 25).
This is now controlled independently with the scroll_page_overlap, which by default uses the value 50 px. While the scroll_step controls how much it advances with the arrows, by default 100 pixels.
Great work! Much better to have separate settings.
participants (2)
-
Kevin Koster -
Rodrigo Arias