-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints. Jorge, could you update your coding conventions with respect to c++ specific language features? Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0pmoPmwNWhsaZYRAi1VAJwO/e+JWmCoMsjOF/hYuF4X1DUOWwCePB96 +X++Veu0Gyv854m0TxSwI7Q= =rc5Z -----END PGP SIGNATURE-----
Hi Justus, On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hey everyone :)
attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints.
This is really nice! For text search the popup menus are even more annoying than for entering an url. One minor thing. You can make the CheckButton and Input members of Findbar private if you use static methods for the callbacks instead of functions. Cheers, Johannes
On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote:
Hi Justus,
On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hey everyone :)
attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints.
This is really nice! For text search the popup menus are even more annoying than for entering an url.
One minor thing. You can make the CheckButton and Input members of Findbar private if you use static methods for the callbacks instead of functions.
Yes, I agree. -- Cheers Jorge.-
On Thu, May 22, 2008 at 12:32:07PM -0400, Jorge Arellano Cid wrote:
On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote:
Hi Justus,
On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hey everyone :)
attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints.
This is really nice! For text search the popup menus are even more annoying than for entering an url.
One minor thing. You can make the CheckButton and Input members of Findbar private if you use static methods for the callbacks instead of functions.
Yes, I agree.
Patch attached. Cheers, Johannes
On Fri, May 23, 2008 at 07:01:51PM +0200, Johannes Hofmann wrote:
On Thu, May 22, 2008 at 12:32:07PM -0400, Jorge Arellano Cid wrote:
On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote:
Hi Justus,
On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hey everyone :)
attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints.
This is really nice! For text search the popup menus are even more annoying than for entering an url.
One minor thing. You can make the CheckButton and Input members of Findbar private if you use static methods for the callbacks instead of functions.
Yes, I agree.
Patch attached.
Committed. -- Cheers Jorge.-
On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hey everyone :)
Hi there!
attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar.
Nice! Committed with some changes. See below.
There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints.
Ok, the comment says:
/* BUG: this is acting funny * * 1. figure out why the first EscapeKey is only * sent to the input widget if it is focused at the time * 2. ctrl-f ; type foo ; select foo and type bar ; press esc * => foo is inserted into the input box */
Fixed both in the committed version. FLTK2 sends the event to handle() and its return value tells whether the event was handled or not. Here, the input widget was handling the event (and making the selection empty) so there was no need to propagate the event upwards, but when the selected text was already empty (second time) there was nothing to do and the event was propagated upwards. The patch was the same as for the location bar. A custom input widget that handles keys in a slightly different way that the native Input widget. In this case (MyInput) we don't handle the escape key and let FLTK pass it upwards, and thus get the desired effect.
Jorge, could you update your coding conventions with respect to c++ specific language features?
Oh yes. I need to find some time though. I've been giving priority to pending patches. The coding conventions, are clearly out of date. At least the C++ part. In this regard we're currently following dw2's style. Can you write a few rules down and send them to me to update the page. The idea is not to be pedantic on style issues, but to define a common style that we can adhere to. -- Cheers Jorge.-
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote:
On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote:
attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar.
Nice!
Committed with some changes. See below. Corvid spotted two spelling errors. Patch is attached.
There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints.
Ok, the comment says:
/* BUG: this is acting funny * * 1. figure out why the first EscapeKey is only * sent to the input widget if it is focused at the time * 2. ctrl-f ; type foo ; select foo and type bar ; press esc * => foo is inserted into the input box */
Fixed both in the committed version.
FLTK2 sends the event to handle() and its return value tells whether the event was handled or not. Here, the input widget was handling the event (and making the selection empty) so there was no need to propagate the event upwards, but when the selected text was already empty (second time) there was nothing to do and the event was propagated upwards.
The patch was the same as for the location bar. A custom input widget that handles keys in a slightly different way that the native Input widget. In this case (MyInput) we don't handle the escape key and let FLTK pass it upwards, and thus get the desired effect. Thanks for the explanation... It really makes sense, but for some strange reason I assumed that the events bubble the other way around...
Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIN3q9oPmwNWhsaZYRAoBQAKCw/pncNv/vWyN3cVGuGYoH/ZHxdQCcCrJ3 J/S96py9oODzwP24jdg496U= =SCyw -----END PGP SIGNATURE-----
Justus wrote:
Corvid spotted two spelling errors. Patch is attached.
(I thought he was going to be the next one touching findbar.cc, so I thought I could keep list traffic down. Sorry.) Anyway...
- _MSG("findbar NewInput: catched EscapeKey\n"); + _MSG("findbar NewInput: cought EscapeKey\n");
..it's "caught".
Justus wrote:
Corvid spotted two spelling errors. Patch is attached.
(I thought he was going to be the next one touching findbar.cc, so I thought I could keep list traffic down. Sorry.) Anyway...
- _MSG("findbar NewInput: catched EscapeKey\n"); + _MSG("findbar NewInput: cought EscapeKey\n");
..it's "caught". Damn! Is there a free syntax and api aware spell checker around? I found some non free software for this purpose, and {i,a}spell has way too many false positives... oh well, maybe I should just avoid complicated things
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 corvid wrote: like spell checking when I'm tired :) Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIN820oPmwNWhsaZYRAsKBAKCv1sSxuX45TmKn0K7NIl9zjHeveACfWxQH iC6P9GKWOuXsNopM5HzUUqE= =WPvC -----END PGP SIGNATURE-----
On Sat, May 24, 2008 at 03:34:38AM +0000, corvid wrote:
Justus wrote:
Corvid spotted two spelling errors. Patch is attached.
(I thought he was going to be the next one touching findbar.cc, so I thought I could keep list traffic down. Sorry.) Anyway...
- _MSG("findbar NewInput: catched EscapeKey\n"); + _MSG("findbar NewInput: cought EscapeKey\n");
..it's "caught".
Committed. BTW, corvidspell works great for me! :-) -- Cheers Jorge.-
participants (4)
-
4winter＠informatik.uni-hamburg.de -
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de