[patch]: html.cc: remove MSG_HTML and rename Html_msg() to DilloHtml::message()
Self-explanatory, I hope. This is a useful bit of yak-shaving to prepare for more refactoring of form handling code. The reasons for removing MSG_HTML are: * It doesn't belong in msg.h since it can only work when used in http.cc . * It's a UI function not a debugging function like the other MSG_* so it's misleading for it to look similar to the MSG_* macros. * Using it has no advantage over simply calling the function that it wraps. * It's fragile because it requires html to be in scope and have the right value. Regards, Jeremy Henty
On Fri, May 30, 2008 at 07:30:49PM +0100, Jeremy Henty wrote:
Self-explanatory, I hope. This is a useful bit of yak-shaving to prepare for more refactoring of form handling code. The reasons for removing MSG_HTML are:
* It doesn't belong in msg.h since it can only work when used in http.cc .
OK.
* It's a UI function not a debugging function like the other MSG_* so it's misleading for it to look similar to the MSG_* macros.
OK.
* Using it has no advantage over simply calling the function that it wraps.
Yes it has. The macro is shorter and mnemonic.
* It's fragile because it requires html to be in scope and have the right value.
Easily detected at compile time. A mixed patch was committed. Left the method in DilloHtml and made a macro in html.cc. You should be able to continue from here. -- Cheers Jorge.-
participants (2)
-
jcid＠dillo.org -
onepoint＠starurchin.org