Dialog_user_password_cb() should not use VOIDP2INT, because the (void *) argument was originally an (int *), not an int or long. This bug makes the dialog always call its callback even when the user presses the Cancel button. As a result it is futile to cancel the Basic Authentication dialog: the page reloads and the dialog pops up again. Patch attached. Jeremy Henty
On Sun, Dec 28, 2008 at 07:56:55PM +0000, Jeremy Henty wrote:
Dialog_user_password_cb() should not use VOIDP2INT, because the (void *) argument was originally an (int *), not an int or long. This bug makes the dialog always call its callback even when the user presses the Cancel button. As a result it is futile to cancel the Basic Authentication dialog: the page reloads and the dialog pops up again.
Ooops! Committed with minor modifications and a fix for some unrelated missing INT2VOIDP. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________
participants (2)
-
jcid@dillo.org
-
onepoint@starurchin.org