Keyboard shortcuts & fullscreen button
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The UI constructor creates a button for the fullscreen mode, but it is not added to anything: // Make the full screen button (to be attached to the viewport later) // TODO: attach to the viewport FullScreen = new HighlightButton(0,0,15,15); [...] Any idea why this was postponed? Should it be enabled now? Also I noticed, that the way events are handled is somewhat lax with respect to modifier keys. The code just checks if ctrl is pressed, not if ctrl but none of the other modifiers are pressed. This makes ctrl-l equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is this a bug or a feature? Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILwMvoPmwNWhsaZYRAmHYAJ49XUO6F6mBTG+CbWAzfN5yknkrKgCfQOjB QzlODEtqUdlztUo6tHuluUE= =hCHy -----END PGP SIGNATURE-----
On Sat, May 17, 2008 at 06:09:19PM +0200, Justus Winter wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
The UI constructor creates a button for the fullscreen mode, but it is not added to anything:
// Make the full screen button (to be attached to the viewport later) // TODO: attach to the viewport FullScreen = new HighlightButton(0,0,15,15); [...]
Any idea why this was postponed? Should it be enabled now?
The idea is that there's a gadget in the viewport (i.e. a small button in the lower right corner that shows even when in fullwindow mode). This was to be used to enable/disable full window mode. Now, thinking twice, maybe is not a bad idea to hook a right-click fullscreen to this button. Leaving left-click for fullwindow mode. ...but for that, the gadget code needs to be enabled.
Also I noticed, that the way events are handled is somewhat lax with respect to modifier keys. The code just checks if ctrl is pressed, not if ctrl but none of the other modifiers are pressed. This makes ctrl-l equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is this a bug or a feature?
Bug I think. The UI was coded in a hurry to get it running. Lax parts need polish. -- Cheers Jorge.-
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote:
On Sat, May 17, 2008 at 06:09:19PM +0200, Justus Winter wrote:
Also I noticed, that the way events are handled is somewhat lax with respect to modifier keys. The code just checks if ctrl is pressed, not if ctrl but none of the other modifiers are pressed. This makes ctrl-l equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is this a bug or a feature?
Bug I think.
The UI was coded in a hurry to get it running. Lax parts need polish.
The attached patch addresses modifier issue. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0KVoPmwNWhsaZYRAr9lAJ429TW3JBochKDUiHAZTK1n5gapZwCeOVGg Na+M4LYF8QqFGJfOaIBFkhI= =Xkri -----END PGP SIGNATURE-----
On Tue, May 20, 2008 at 11:28:54PM +0200, Justus Winter wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Jorge Arellano Cid wrote:
On Sat, May 17, 2008 at 06:09:19PM +0200, Justus Winter wrote:
Also I noticed, that the way events are handled is somewhat lax with respect to modifier keys. The code just checks if ctrl is pressed, not if ctrl but none of the other modifiers are pressed. This makes ctrl-l equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is this a bug or a feature?
Bug I think.
The UI was coded in a hurry to get it running. Lax parts need polish.
The attached patch addresses modifier issue.
Committed. -- Cheers Jorge.-
participants (2)
-
4winter＠informatik.uni-hamburg.de -
jcid＠dillo.org