Re: link signal emission from layout?
Jorge wrote:
On Sat, Oct 24, 2009 at 03:48:55PM +0000, corvid wrote:
I never liked all of the connectSignals() for all of the textblocks and images and whatever else in html.cc.
Why not?
So much signal connection for the listitems and the tablecells and everything, and all redundant, since it's all going back to the same receiver in html.
Would you have any opinion about moving the (perhaps increasingly-inaccurately-named) link signal emission to layout?
Could be.
I was just playing with the idea, and, at least after a moment's test :) , it seemed to be working. And, as a bonus, it lets me pop up menus when pressing button 3 below the bottom of page content.
I miss this feature. Also being able to popup a menu over a bare image would be a plus.
Random thought: it would nice if there were a mechanism to change the size of images.
(I left the event emitter alone for the moment, but I think the only thing using it right now is plain.cc. If so, it would be nice to rip that out in any case, even if plain doesn't have "links" exactly...)
I don't know why it's currently done in html.cc, maybe it's just grouping by required functionality, maybe not. If the new approach is simpler and provides the same and more as you pointed, id say: +1.
It's simpler for src/, but the ickiness is preserved for dw/, since what was excised from Widget gets implanted into Layout.
BTW, please move this thread to dillo-dev.
participants (1)
-
corvid@lavabit.com