hey ... New to the list and Dillo! I'm on an Xubuntu 10.10 box. dnormandin@select-man:~$ dillo -v Dillo version 3.0-pre dnormandin@select-man:~$ dillo & [1] 12085 dnormandin@select-man:~$ dillo_dns_init: Here we go! (threaded) Disabling cookies. Nav_open_url: new url='about:splash' [1]+ Segmentation fault dillo dnormandin@select-man:~$ This happened when i clicked on the Settings button in the toolbar. -- Duke Normandin Turner Valley, Alberta, Canada
Hi, On Wed, Apr 27, 2011 at 11:37:44AM -0600, Duke Normandin wrote:
hey ...
New to the list and Dillo!
I'm on an Xubuntu 10.10 box.
dnormandin@select-man:~$ dillo -v Dillo version 3.0-pre
dnormandin@select-man:~$ dillo & [1] 12085 dnormandin@select-man:~$ dillo_dns_init: Here we go! (threaded) Disabling cookies. Nav_open_url: new url='about:splash'
[1]+ Segmentation fault dillo dnormandin@select-man:~$
This happened when i clicked on the Settings button in the toolbar.
Hmmm, it could be the fltk version: $ fltk-config --version 1.3.0 and, _a recent one_. (e.g. fltk-1.3.x-r8592). -- Cheers Jorge.-
On Wed, 27 Apr 2011, Jorge Arellano Cid wrote:
Hi,
On Wed, Apr 27, 2011 at 11:37:44AM -0600, Duke Normandin wrote:
hey ...
New to the list and Dillo!
I'm on an Xubuntu 10.10 box.
dnormandin@select-man:~$ dillo -v Dillo version 3.0-pre
dnormandin@select-man:~$ dillo & [1] 12085 dnormandin@select-man:~$ dillo_dns_init: Here we go! (threaded) Disabling cookies. Nav_open_url: new url='about:splash'
[1]+ Segmentation fault dillo dnormandin@select-man:~$
This happened when i clicked on the Settings button in the toolbar.
Hmmm, it could be the fltk version:
$ fltk-config --version 1.3.0
and, _a recent one_. (e.g. fltk-1.3.x-r8592).
Did you guys build and test with fltk-1.3.x-r8592? -- Duke
On Wed, Apr 27, 2011 at 12:20:52PM -0600, Duke Normandin wrote:
On Wed, 27 Apr 2011, Jorge Arellano Cid wrote:
Hi,
On Wed, Apr 27, 2011 at 11:37:44AM -0600, Duke Normandin wrote:
[...] [1]+ Segmentation fault dillo dnormandin@select-man:~$
This happened when i clicked on the Settings button in the toolbar.
Hmmm, it could be the fltk version:
$ fltk-config --version 1.3.0
and, _a recent one_. (e.g. fltk-1.3.x-r8592).
Did you guys build and test with fltk-1.3.x-r8592?
I did. FWIW the last one (r8617) should also work. -- Cheers Jorge.-
On Wed, 27 Apr 2011, Jorge Arellano Cid wrote:
On Wed, Apr 27, 2011 at 12:20:52PM -0600, Duke Normandin wrote:
On Wed, 27 Apr 2011, Jorge Arellano Cid wrote:
Hi,
On Wed, Apr 27, 2011 at 11:37:44AM -0600, Duke Normandin wrote:
[...] [1]+ Segmentation fault dillo dnormandin@select-man:~$
This happened when i clicked on the Settings button in the toolbar.
Hmmm, it could be the fltk version:
$ fltk-config --version 1.3.0
and, _a recent one_. (e.g. fltk-1.3.x-r8592).
Did you guys build and test with fltk-1.3.x-r8592?
I did. FWIW the last one (r8617) should also work.
Well apparently not! :) r8617 is what I installed! I seems that fltk-config --version doesn't show all the versionning details. Any other ideas? -- Duke
Well apparently not! :) r8617 is what I installed! I seems that fltk-config --version doesn't show all the versionning details.
Any other ideas?
I have been working on what may well be the same problem (quits at about the same point), but I don't get to click on any buttons. ?I can build against FLTK r8617, or the previous 8592, and I get the same problem. ?One of the things making it harder is that the segfault totally trashes the stack, so the backtrace does not seem to be very helpful. ?I have been looking at the following: void a_UIcmd_set_page_title(BrowserWindow *bw, const char *label) 1143{ 1144 const int size = 128; 1145 char title[size]; 1146? ?/* At this point size==-128 (though I have seen it as just junk numbers * as well). Could be anduril462 was on to something perhaps? */ 1147 if (a_UIcmd_get_bw_by_widget(BW2UI(bw)->tabs()->wizard()->value()) == bw) { 1148 // This is the focused bw, set window title 1149 if (snprintf(title, size, "Dillo: %s", label) >= size) { ? ? ? ? ? ? ? ? ? <-- It dies here 1150 uint_t i = MIN(size - 4, 1 + a_Utf8_end_of_char(title, size - 8)); 1151 snprintf(title + i, 4, "..."); 1152 } 1153 BW2UI(bw)->window()->copy_label(title); 1154 BW2UI(bw)->window()->redraw_label(); 1155 } 1156 BW2UI(bw)->tabs()->set_tab_label(BW2UI(bw), label); The lines of note are the comment between 1146-47, and line 1149. ?There is some weirdness going on with the variable 'size', though I suspect this is due to something else destroying the stack. ?I have not had a lot of time to look at this, so that is about all I have. ?BTW, building the latest 1.3 version with -O0 makes the segfault disappear.
On Wed, 27 Apr 2011, Rob S. wrote:
Well apparently not! :) r8617 is what I installed! I seems that fltk-config --version doesn't show all the versionning details.
Any other ideas?
I have been working on what may well be the same problem (quits at about the same point), but I don't get to click on any buttons. I can build against FLTK r8617, or the previous 8592, and I get the same problem. One of the things making it harder is that the segfault totally trashes the stack, so the backtrace does not seem to be very helpful. I have been looking at the following:
[snip the headache] :)
..... BTW, building the latest 1.3 version with -O0 makes the segfault disappear.
I glad to see that I'm not the only one having the problem. I wish that I was a C / C++ programmer - than I could help out. BTW, -O0 is an argument to what? -- Duke
I glad to see that I'm not the only one having the problem. I wish that I was a C / C++ programmer - than I could help out. BTW, -O0 is an argument to what? -- Duke
-O0 is an argument to gcc - it is the optimization level. ?-O0 means no optimization. ?The other options are -O1 through -O3. ?This is set out in the Makefile, the default for Dillo being -O2, IIRC.
On Wed, Apr 27, 2011 at 02:26:01PM -0600, Duke Normandin wrote:
On Wed, 27 Apr 2011, Rob S. wrote: [snip the headache] :)
..... BTW, building the latest 1.3 version with -O0 makes the segfault disappear.
I glad to see that I'm not the only one having the problem. I wish that I was a C / C++ programmer - than I could help out. BTW, -O0 is an argument to what?
To the compiler (gcc). It's an optimization level. If this is the case, it could be a bug in the compiler. -- Cheers Jorge.-
On Wed, 27 Apr 2011, Jorge Arellano Cid wrote:
On Wed, Apr 27, 2011 at 02:26:01PM -0600, Duke Normandin wrote:
On Wed, 27 Apr 2011, Rob S. wrote: [snip the headache] :)
..... BTW, building the latest 1.3 version with -O0 makes the segfault disappear.
I glad to see that I'm not the only one having the problem. I wish that I was a C / C++ programmer - than I could help out. BTW, -O0 is an argument to what?
To the compiler (gcc). It's an optimization level. If this is the case, it could be a bug in the compiler.
Thanks! -- Duke
On Wed, 27 Apr 2011, corvid wrote:
Rob wrote:
BTW, building the latest 1.3 version with -O0 makes the segfault disappear.
Ah! I can reproduce this now with -O2. I'll see what's going on...
Here's some more info from my /var/log/messages Apr 27 14:26:56 select-man kernel: [30821.543758] dillo[12365]: segfault at 923bce6c ip 080d7391 sp bf8408e0 error 4 in dillo[8048000+109000] HTH -- Duke
---------------------------------------- From: corvid@lavabit.com Date: Wed, 27 Apr 2011 20:35:36 +0000 To: dillo-dev@dillo.org Subject: Re: [Dillo-dev] Settings Seg-fault
Does the attached fix it for you?
No, it does not seem to. ?Here is what I am getting - hopefully it is somewhat helpful. ?It consists of: 1) a Program run2) Start gdb with core dump3) Another program run4) A backtrace drs@mintyd ~/tmp/work/dillo-1.3 $ fltk-config --version1.3.0 drs@mintyd ~/tmp/work/dillo-1.3 $ src/dillopaths: Cannot open file '/home/drs/.dillo/keysrc'paths: Using /usr/local/etc/dillo/keysrcdillo_dns_init: Here we go! (threaded)Enabling cookies as from cookiesrc...Nav_open_url: new url='http://www3.sympatico.ca/rsquared/gdb/'Dns_server [0]: www3.sympatico.ca is 67.69.240.127Connecting to 67.69.240.127Segmentation fault (core dumped) drs@mintyd ~/tmp/work/dillo-1.3 $ gdb src/dillo /tmp/coreReading symbols from /home/drs/tmp/work/dillo-1.3/src/dillo...done.[New Thread 5282] warning: Can't read pathname for load map: Input/output error.Reading symbols from /usr/lib/libjpeg.so.62...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libjpeg.so.62Reading symbols from /lib/libpng12.so.0...(no debugging symbols found)...done.Loaded symbols for /lib/libpng12.so.0Reading symbols from /usr/lib/libXext.so.6...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXext.so.6Reading symbols from /usr/lib/libXft.so.2...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXft.so.2Reading symbols from /usr/lib/libfontconfig.so.1...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libfontconfig.so.1Reading symbols from /usr/lib/libXinerama.so.1...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXinerama.so.1Reading symbols from /lib/libpthread.so.0...Reading symbols from /usr/lib/debug/lib/libpthread-2.11.2.so...done.done.Loaded symbols for /lib/libpthread.so.0Reading symbols from /lib/libdl.so.2...Reading symbols from /usr/lib/debug/lib/libdl-2.11.2.so...done.done.Loaded symbols for /lib/libdl.so.2Reading symbols from /usr/lib/libX11.so.6...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libX11.so.6Reading symbols from /usr/lib/libz.so.1...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libz.so.1Reading symbols from /usr/lib/libstdc++.so.6...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libstdc++.so.6Reading symbols from /lib/libm.so.6...Reading symbols from /usr/lib/debug/lib/libm-2.11.2.so...done.done.Loaded symbols for /lib/libm.so.6Reading symbols from /lib/libgcc_s.so.1...(no debugging symbols found)...done.Loaded symbols for /lib/libgcc_s.so.1Reading symbols from /lib/libc.so.6...Reading symbols from /usr/lib/debug/lib/libc-2.11.2.so...done.done.Loaded symbols for /lib/libc.so.6Reading symbols from /usr/lib/libfreetype.so.6...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libfreetype.so.6Reading symbols from /usr/lib/libXrender.so.1...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXrender.so.1Reading symbols from /usr/lib/libexpat.so.1...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libexpat.so.1Reading symbols from /lib64/ld-linux-x86-64.so.2...Reading symbols from /usr/lib/debug/lib/ld-2.11.2.so...done.done.Loaded symbols for /lib64/ld-linux-x86-64.so.2Reading symbols from /usr/lib/libxcb.so.1...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libxcb.so.1Reading symbols from /usr/lib/libXau.so.6...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXau.so.6Reading symbols from /usr/lib/libXdmcp.so.6...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXdmcp.so.6Reading symbols from /lib/libnss_files.so.2...Reading symbols from /usr/lib/debug/lib/libnss_files-2.11.2.so...done.done.Loaded symbols for /lib/libnss_files.so.2Reading symbols from /lib/libnss_dns.so.2...Reading symbols from /usr/lib/debug/lib/libnss_dns-2.11.2.so...done.done.Loaded symbols for /lib/libnss_dns.so.2Reading symbols from /lib/libresolv.so.2...Reading symbols from /usr/lib/debug/lib/libresolv-2.11.2.so...done.done.Loaded symbols for /lib/libresolv.so.2Reading symbols from /usr/lib/libXcursor.so.1...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXcursor.so.1Reading symbols from /usr/lib/libXfixes.so.3...(no debugging symbols found)...done.Loaded symbols for /usr/lib/libXfixes.so.3Core was generated by `src/dillo'.Program terminated with signal 11, Segmentation fault.#0 ?0x00007fa6ef7e990a in __snprintf (s=<value optimized out>, maxlen=<value optimized out>, format=<value optimized out>) at snprintf.c:3939 ? ? ?snprintf.c: No such file or directory.? ? ? ? in snprintf.c(gdb) runStarting program: /home/drs/tmp/work/dillo-1.3/src/dillo?[Thread debugging using libthread_db enabled]paths: Cannot open file '/home/drs/.dillo/keysrc'paths: Using /usr/local/etc/dillo/keysrcdillo_dns_init: Here we go! (threaded)Enabling cookies as from cookiesrc...Nav_open_url: new url='http://www3.sympatico.ca/rsquared/gdb/'[New Thread 0x7ffff4edc700 (LWP 5305)]Dns_server [0]: www3.sympatico.ca is 67.69.240.127[Thread 0x7ffff4edc700 (LWP 5305) exited]Connecting to 67.69.240.127 Program received signal SIGSEGV, Segmentation fault.0x00007ffff5d0990a in __snprintf (s=<value optimized out>, maxlen=<value optimized out>, format=<value optimized out>) at snprintf.c:3939 ? ? ?snprintf.c: No such file or directory.? ? ? ? in snprintf.c (gdb) bt#0 ?0x00007ffff5d0990a in __snprintf (s=<value optimized out>, maxlen=<value optimized out>, format=<value optimized out>) at snprintf.c:39#1 ?0x2e0000000040c8b5 in ?? ()#2 ?0x0074755420002e2e in ?? ()#3 ?0x000000000045d856 in Fl_Widget::redraw_label() ()#4 ?0x000000000047b8cc in Fl_Window::label(char const*, char const*) ()#5 ?0x00007fffffffc140 in ?? ()#6 ?0x0000000000000004 in ?? ()#7 ?0x0000000000422240 in ?? () at html.cc:146#8 ?0x0000000066666667 in ?? ()#9 ?0x000000000040d4b1 in a_UIcmd_set_page_title (bw=0x71db70, label=0x7b72e0 "GDB Tutorial | How To Debug With The GNU GDB Debugger") at uicmd.cc:1156#10 0x0000000000422274 in Html_tag_close_title (html=0x7e94e0, TagIdx=<value optimized out>) at html.cc:1650#11 0x0000000000423453 in Html_tag_cleanup_to_idx (html=0x7e94e0, new_idx=<value optimized out>) at html.cc:1315#12 Html_tag_cleanup_at_close (html=0x7e94e0, new_idx=<value optimized out>) at html.cc:1360#13 0x00000000004259b6 in Html_process_tag (html=0x7e94e0, buf=<value optimized out>, bufsize=<value optimized out>, Eof=0) at html.cc:3553#14 Html_write_raw (html=0x7e94e0, buf=<value optimized out>, bufsize=<value optimized out>, Eof=0) at html.cc:3818#15 0x000000000042665c in DilloHtml::write (this=0x7e94e0, Buf=<value optimized out>, BufSize=<value optimized out>, Eof=<value optimized out>) at html.cc:552#16 0x0000000000416279 in Cache_process_queue (entry=0x7be120) at cache.c:1181#17 0x0000000000413471 in a_Chain_fcb (Op=<value optimized out>, Info=<value optimized out>, Data1=<value optimized out>, Data2=<value optimized out>) at chain.c:113#18 0x000000000043aae8 in Dpi_parse_token (Op=<value optimized out>, Branch=<value optimized out>, Dir=<value optimized out>, Info=<value optimized out>, Data1=<value optimized out>,?? ? Data2=<value optimized out>) at dpi.c:220#19 Dpi_process_dbuf (Op=<value optimized out>, Branch=<value optimized out>, Dir=<value optimized out>, Info=<value optimized out>, Data1=<value optimized out>, Data2=<value optimized out>)? ? at dpi.c:339#20 a_Dpi_ccc (Op=<value optimized out>, Branch=<value optimized out>, Dir=<value optimized out>, Info=<value optimized out>, Data1=<value optimized out>, Data2=<value optimized out>)? ? at dpi.c:735#21 0x0000000000413471 in a_Chain_fcb (Op=<value optimized out>, Info=<value optimized out>, Data1=<value optimized out>, Data2=<value optimized out>) at chain.c:113#22 0x000000000043b177 in a_IO_ccc (Op=2, Branch=<value optimized out>, Dir=1, Info=0x7b9b40, Data1=0x7b9b90, Data2=0x0) at IO.c:425#23 0x000000000043b3a5 in IO_read (io=0x7b9b90) at IO.c:197#24 0x000000000043b485 in IO_callback (io=0x7b9b90) at IO.c:262#25 0x000000000043b507 in IO_fd_read_cb (fd=6, data=<value optimized out>) at IO.c:283#26 0x000000000047b194 in fl_wait(double) ()#27 0x000000000045dcb5 in Fl::wait(double) ()#28 0x000000000045dd29 in Fl::run() ()#29 0x0000000000407f1b in main (argc=<value optimized out>, argv=<value optimized out>) at dillo.cc:431
Rob wrote:
Does the attached fix it for you? No, it does not seem to. ?Here is what I am getting - hopefully it is somewhat helpful. ?It consists of:
That came through as kind of a mess, but I see that you have a cleaner copy at http://cboard.cprogramming.com/tech-board/137344-debugging-problem.html If you go to the Html_tag_close_title stack frame, what do you get for p *html ? Did the port used to work on this particular system? How about the FLTK2 dillo?
That came through as kind of a mess,? Yes - it was not good at all. ?Sorry about that. but I see that you have a cleaner copy at http://cboard.cprogramming.com/tech-board/137344-debugging-problem.html
Glad you found that - I had contemplated just posting a link to that in the first place.
If you go to the Html_tag_close_title stack frame, what do you get for p *html ?
(gdb) frame 10#10 0x0000000000422274 in Html_tag_close_title (html=0x7e9600, TagIdx=<value optimized out>) at html.cc:16501650 ? ? ? ? ?a_UIcmd_set_page_title(html->bw, html->Stash->str);(gdb) p *html$1 = {linkReceiver = {<dw::core::Layout::LinkReceiver> = {<lout::signal::Receiver> = {<lout::object::Object> = {_vptr.Object = 0x4b3830}, emitters = 0x7d1510}, <No data fields>},?? ? html = 0x7e9600}, bw = 0x76b0b0, page_url = 0x7eb430, base_url = 0x7d1f80, dw = 0x7e98b0,?? Start_Buf = 0x7c57d0 "<!DOCTYPE HTML>\n<html>\n<head>\n<title>GDB Tutorial | How To Debug With The GNU GDB Debugger</title>\n<meta name=\"description\" content=\"A comprehensive gdb tutorial with examples and exercises.\"/>\n<meta "..., Start_Ofs = 0, content_type = 0x7eb250 "text/html", charset = 0x0, stop_parser = false, CurrTagOfs = 90, OldTagOfs = 0, OldTagLine = 1,?? DocType = DT_HTML, DocTypeVersion = 5, cssUrls = 0x7ea780, stack = 0x7d6300, styleEngine = 0x7ea5a0, InFlags = 3, Stash = 0x7d6320, StashSpace = false, pre_column = 0,?? PreFirstChar = false, PrevWasCR = false, PrevWasOpenTag = false, InVisitedLink = false, ReqTagClose = false, TagSoup = true, loadCssFromStash = false, Num_HTML = 1 '\001',?? Num_HEAD = 1 '\001', Num_BODY = 0 '\000', Num_TITLE = 1 '\001', attr_data = 0x7eb020, non_css_link_color = -1, non_css_visited_color = -1, visited_color = -1, forms = 0x7eb040,?? inputs_outside_form = 0x7d96e0, links = 0x7d9700, images = 0x7d1e70, maps = {imageMaps = 0x7d1530, currentMap = 0x0}}(gdb)? Woah! ?Cool!
Did the port used to work on this particular system? How about the FLTK2 dillo?
No - this is a new laptop, and I just recently started tinkering with Linux on it. ?Prior to that, I was trying to build Dillo under Cygwin in Windows. ?As for the FLTK2 Dillo, I don't know, as I have not tried it. ?I think I might give that a go, and see.?
Rob wrote:
If you go to the Html_tag_close_title stack frame, what do you get for p *html ?
(gdb) frame 10#10 0x0000000000422274 in Html_tag_close_title (html=0x7e9600, TagIdx=<value optimized out>) at html.cc:16501650 ? ? ? ? ?a_UIcmd_set_page_title(html->bw, html->Stash->str);(gdb) p *html$1 = {linkReceiver = {<dw::core::Layout::LinkReceiver> = {<lout::signal::Receiver> = {<lout::object::Object> = {_vptr.Object = 0x4b3830}, emitters = 0x7d1510}, <No data fields>},?? ? html = 0x7e9600}, bw = 0x76b0b0, page_url = 0x7eb430, base_url = 0x7d1f80, dw = 0x7e98b0,?? Start_Buf = 0x7c57d0 "<!DOCTYPE HTML>\n<html>\n<head>\n<title>GDB Tutorial | How To Debug With The GNU GDB Debugger</title>\n<meta name=\"description\" content=\"A comprehensive gdb tutorial with examples and exercises\"/>\n<meta "..., Start_Ofs = 0, content_type = 0x7eb250 "text/html", charset = 0x0, stop_parser = false, CurrTagOfs = 90, OldTagOfs = 0, OldTagLine = 1,?? DocType = DT_HTML, DocTypeVersion = 5, cssUrls = 0x7ea780, stack = 0x7d6300, styleEngine = 0x7ea5a0, InFlags = 3, Stash = 0x7d6320, StashSpace = false, pre_column = 0,?? PreFirstChar = false, PrevWasCR = false, PrevWasOpenTag = false, InVisitedLink = false, ReqTagClose = false, TagSoup = true, loadCssFromStash = false, Num_HTML = 1 '\001',?? Num_HEAD = 1 '\001', Num_BODY = 0 '\000', Num_TITLE = 1 '\001', attr_data = 0x7eb020, non_css_link_color = -1, non_css_visited_color = -1, visited_color = -1, forms = 0x7eb040,?? inputs_outside_form = 0x7d96e0, links = 0x7d9700, images = 0x7d1e70, maps = {imageMaps = 0x7d1530, currentMap = 0x0}}(gdb)?
Hmm, I was hoping it would look strange inside because the arguments for a_UIcmd_set_page_title(html->bw, html->Stash->str) looked crazy, but it seems that was indeed an effect of the optimization. In a situation like this with optimization on, I would start sticking MSG()s into a_UIcmd_set_page_title() to see the values of variables at different points.
On Wed, Apr 27, 2011 at 07:07:29PM -0400, Rob S. wrote:
[...] Did the port used to work on this particular system? How about the FLTK2 dillo?
No - this is a new laptop, and I just recently started tinkering with Linux on it. ?Prior to that, I was trying to build Dillo under Cygwin in Windows. ?As for the FLTK2 Dillo, I don't know, as I have not tried it. ?I think I might give that a go, and see.?
An easy test is to go back before the menu patch was added: $ hg up -r 041d4979092f $ make|grep : and check how it works. This may tell us whether the problem is somewhere in the code thereafter or elsewhere. The fact that corvid and I can reproduce it with -O2 shows there's actually a bug in our code (and corvid's patch fixes it, at least partially, so I recommend testing with the patch). A not so simple but quite interesting check, would be to build it with another gcc version. FWIW, here I have gcc version 4.4.3. A wild shot is to add a few more: {0,0,0,0,0,0,0,0,0}, in src/menu.cc HTH. -- Cheers Jorge.-
On Wed, Apr 27, 2011 at 08:35:36PM +0000, corvid wrote:
I wrote:
Rob wrote:
BTW, building the latest 1.3 version with -O0 makes the segfault disappear.
Ah! I can reproduce this now with -O2. I'll see what's going on...
I can also reproduce it with -O2.
Does the attached fix it for you?
diff -r 165b50e3f996 src/menu.cc --- a/src/menu.cc Wed Apr 27 19:56:21 2011 +0000 +++ b/src/menu.cc Wed Apr 27 20:34:25 2011 +0000 @@ -671,6 +671,7 @@ FL_MENU_RADIO|FL_MENU_DIVIDER,0,0,0,0}, {"small icons", 0,Menu_panel_change_cb,(void*)10, FL_MENU_TOGGLE,0,0,0,0}, + {0,0,0,0,0,0,0,0,0}, {0,0,0,0,0,0,0,0,0} };
Yes it does! And I also checked that regressing the repo to the version before the submenu patch (e816e06ee901) also "fixes" it. @Rob: would you mind double check the patch is correctly applied on src/menu.cc:674?, then recompile, and also make sure you run the newly compiled dillo and not the system wide one? -- Cheers Jorge.-
On Wed, 27 Apr 2011, Jorge Arellano Cid wrote:
On Wed, Apr 27, 2011 at 08:35:36PM +0000, corvid wrote:
I wrote:
Rob wrote:
BTW, building the latest 1.3 version with -O0 makes the segfault disappear.
Ah! I can reproduce this now with -O2. I'll see what's going on...
I can also reproduce it with -O2.
Does the attached fix it for you?
diff -r 165b50e3f996 src/menu.cc --- a/src/menu.cc Wed Apr 27 19:56:21 2011 +0000 +++ b/src/menu.cc Wed Apr 27 20:34:25 2011 +0000 @@ -671,6 +671,7 @@ FL_MENU_RADIO|FL_MENU_DIVIDER,0,0,0,0}, {"small icons", 0,Menu_panel_change_cb,(void*)10, FL_MENU_TOGGLE,0,0,0,0}, + {0,0,0,0,0,0,0,0,0}, {0,0,0,0,0,0,0,0,0} };
Yes it does!
Patch applied! and all is well. Thank you everyone! Niiice browser! -- Duke
participants (4)
-
corvid@lavabit.com
-
dukeofperl@ml1.net
-
jcid@dillo.org
-
mr_semantics@hotmail.com