Hello, I was using dillo from the OpenBSD ports before, but at the urging of a friend I've tried out the CVS version. Since dillo has threaded DNS queries by default OpenBSD would load the first page and then generally fail to load anything after that (images from other sites on that page, new pages, etc.). The problem lies in the fact that the gethost* calls on OpenBSD-3.3 and -current are not thread safe. Even though threads support has been greatly improved, threaded dns queries are still out (unless you do locking with mutexs, but you already have another framework for dealing with this issue). Attached is a small patch that makes dillo-cvs work on OpenBSD-3.3 and -current. Thank you, -dan ------------%< snip %<----------------------%< snip %<------------ --- src/dns.c.orig Sat Apr 5 20:09:03 2003 +++ src/dns.c Sat Apr 5 20:09:28 2003 @@ -37,7 +37,9 @@ /* * Note: comment the following line for debugging or gprof profiling. */ +#if !defined(__OpenBSD__) #define G_DNS_THREADED +#else /* * Uncomment the following line for libc5 optimization
On Sat, 5 Apr 2003, Dan Weeks wrote:
Hello,
Hi.
I was using dillo from the OpenBSD ports before, but at the urging of a friend I've tried out the CVS version. Since dillo has threaded DNS queries by default OpenBSD would load the first page and then generally fail to load anything after that (images from other sites on that page, new pages, etc.). The problem lies in the fact that the gethost* calls on OpenBSD-3.3 and -current are not thread safe. Even though threads support has been greatly improved, threaded dns queries are still out (unless you do locking with mutexs, but you already have another framework for dealing with this issue). Attached is a small patch that makes dillo-cvs work on OpenBSD-3.3 and -current.
Is this a problem with _all_ OpenBSD? If so, I'd prefer a `./configure --no-dns-threads` option. Because we aim to be POSIX compliant. The other way around is to develop sspecific code for each OS/Platform, but that doesn't promote standards adoption and obscures the code. Cheers Jorge.-
"CP" == "Chris Palmer" <chris@nodewarrior.org>: CP> On Thu, 10 Apr 2003, Jorge Arellano Cid wrote: CP> CP> [Threading problem on OpenBSD] CP> Is this a problem with _all_ OpenBSD? CP> CP> No, it's new. I'm using OBSD 3.1-stable with Dillo and did not have the CP> problem Dan reported.
Indeed this is the case. Threads underwent an overhaul on 3.2-current and what will be the 3.3 release will have this issue. I'd be fine with the configure option as it's probably cleaner and easier to maintain. -dan
On Thu, 10 Apr 2003 12:06:26 -0400 (CLT) Jorge Arellano Cid <jcid@softhome.net> wrote:
Is this a problem with _all_ OpenBSD?
Well, no. It only applies to 3.3 and -current, as he stated. I'm running OpenBSD 3.2 without any problems. 3.3 will be officially released on May 1 though and as the majority of users most likely will upgrade it'll be a problem. - Victor
On Thu, Apr 10, 2003 at 07:27:37PM +0200, Victor Sahlstedt wrote:
On Thu, 10 Apr 2003 12:06:26 -0400 (CLT) Jorge Arellano Cid <jcid@softhome.net> wrote:
Is this a problem with _all_ OpenBSD?
Well, no. It only applies to 3.3 and -current, as he stated. I'm running OpenBSD 3.2 without any problems.
I recall the same for 3.2
3.3 will be officially released on May 1 though and as the majority of users most likely will upgrade it'll be a problem.
Well, yes and no. It will not be a problem for users of the ports version, since the ports version disables threaded DNS lookups. This has to be done since not all architectures are as thread safe as i386 (and now even i386 fails here ;-) ). Thanks to Damien for pointing this out to me some weeks ago ! So, it will only be a problem for OpenBSD users of the CVS version. Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198
participants (5)
-
Andreas Schweitzer -
Chris Palmer -
Dan Weeks -
Jorge Arellano Cid -
Victor Sahlstedt