
I do not have a github account, so I am sending a patch as well as the statements that enabled the patch. They have all been hand-checked. This is what I hope is a low-effort improvement and ahead of the FOSDEM 2025 presentation. Best regards GT

Gevel Tekens <geveltekens@gmail.com> wrote:
I do not have a github account, so I am sending a patch as well as the statements that enabled the patch. They have all been hand-checked. This is what I hope is a low-effort improvement and ahead of the FOSDEM 2025 presentation.
Best regards
GT
Patch looks good from here. One small correction: diff -ruN a/devdoc/lout.doc b/devdoc/lout.doc --- a/devdoc/lout.doc 2025-01-12 17:14:01.000000000 +0100 +++ b/devdoc/lout.doc 2025-01-18 18:46:05.689088602 +0100 @@ -61,7 +61,7 @@ <h2>Debugging</h2> In debug.hh, there are some some useful macros for debugging messages, -see the file for mor informations. +see the file for mor information. ^^

Hi, On Sat, Jan 18, 2025 at 05:48:09PM +0000, Gevel Tekens wrote:
I do not have a github account, so I am sending a patch as well as the statements that enabled the patch. They have all been hand-checked. This is what I hope is a low-effort improvement and ahead of the FOSDEM 2025 presentation.
Thanks! I'll merge it when I have a moment to review the changes. Best, Rodrigo.

Hi, On Sat, Jan 18, 2025 at 05:48:09PM +0000, Gevel Tekens wrote:
I do not have a github account, so I am sending a patch as well as the statements that enabled the patch. They have all been hand-checked. This is what I hope is a low-effort improvement and ahead of the FOSDEM 2025 presentation.
Thanks, they look good. I will merge it with the corrections below:
diff -ruN a/dw/table.cc b/dw/table.cc --- a/dw/table.cc 2025-01-12 17:14:01.000000000 +0100 +++ b/dw/table.cc 2025-01-18 18:46:05.481088753 +0100 @@ -255,7 +255,7 @@ // An alternative would be incremental resizing for tables; this // approach resembles the behaviour before GROWS.
- // TODO Does it still make sence to return -1 when forceValue is + // TODO Does it still make sense, since to return -1 when forceValue is
Only s/sence/sense/ seems enough.
@@ -547,7 +547,7 @@ * (which is used by DwTable!), and * (ii) line1_offset is ignored (line1_offset_eff is set to 0), * when line1_offset plus the width of the first word is - * greater than the the line break witdh. + * greater than the the line break width.
Also s/the the/the/
diff -ruN a/lout/debug_rtfl.hh b/lout/debug_rtfl.hh --- a/lout/debug_rtfl.hh 2025-01-12 17:14:01.000000000 +0100 +++ b/lout/debug_rtfl.hh 2025-01-18 18:46:05.725088575 +0100 @@ -42,7 +42,7 @@
// Prints an RTFL message to stdout. "fmt" contains simple format // characters how to deal with the additional arguments (no "%" -// preceeding, as in printf) or "q" (which additionally +// preceding, proceeding, as in printf) or "q" (which additionally
Just s/preceeding/preceding/ Best, Rodrigo.

On Tue, Feb 04, 2025 at 10:59:14PM +0100, Rodrigo Arias wrote:
Thanks, they look good. I will merge it with the corrections below [...]
Merged: https://github.com/dillo-browser/dillo/commit/6cd133d2f242d36bd48ddea44acd86... Best, Rodrigo.
participants (3)
-
a1ex@dismail.de
-
Gevel Tekens
-
Rodrigo Arias