Hi! I'd like to bring image backgrounds to a (temporary) end; before, I'd like to finish these tasks (see also doxygen documentation): - Configurability: Should there be new options, additional to "load_image"? If yes, there have to be: 1. a new option, "load_background_image", 2. a new entry in the configuration menu, and 3. a new entry in the context menu. The latter will be quite tricky, when applied to single areas for which a background image is assigned to, but an entry "load *ALL* background images" (emphasis mine) should be simple. - Security/privacy (cookies?): I'm not sure whether there is anything left to do. - Displaying image backgrounds at once, not line by line: there is already an hardcoded option, so changing is simple, even make it a user option. "background-attachment" is postponed. Furthermore, other features are missing, which make background images look strange, e. g. that you only see a part of the logo at <http://google.com>. Did I forget something important? Sebastian
Hi Sebastian, On Tue, Nov 19, 2013 at 03:59:01PM +0100, Sebastian Geerken wrote:
Hi!
I'd like to bring image backgrounds to a (temporary) end; before, I'd like to finish these tasks (see also doxygen documentation):
Cool! It looks really nice.
- Configurability: Should there be new options, additional to "load_image"? If yes, there have to be:
1. a new option, "load_background_image", 2. a new entry in the configuration menu, and 3. a new entry in the context menu.
The latter will be quite tricky, when applied to single areas for which a background image is assigned to, but an entry "load *ALL* background images" (emphasis mine) should be simple.
I think there should be an option to switch off background image loading, so that by switching it off one can basically get the current bahavior. Not sure if we need 2. and 3.
- Security/privacy (cookies?): I'm not sure whether there is anything left to do.
It should respect the rules from domainrc, but as far as I tested it does that.
- Displaying image backgrounds at once, not line by line: there is already an hardcoded option, so changing is simple, even make it a user option.
"background-attachment" is postponed. Furthermore, other features are missing, which make background images look strange, e. g. that you only see a part of the logo at <http://google.com>.
Do you know what missing features cause this? Cheers, Johannes
On Di, Nov 19, 2013, Johannes Hofmann wrote:
On Tue, Nov 19, 2013 at 03:59:01PM +0100, Sebastian Geerken wrote:
I'd like to bring image backgrounds to a (temporary) end; before, I'd like to finish these tasks (see also doxygen documentation):
Cool! It looks really nice.
- Configurability: Should there be new options, additional to "load_image"? If yes, there have to be:
1. a new option, "load_background_image", 2. a new entry in the configuration menu, and 3. a new entry in the context menu.
The latter will be quite tricky, when applied to single areas for which a background image is assigned to, but an entry "load *ALL* background images" (emphasis mine) should be simple.
I think there should be an option to switch off background image loading, so that by switching it off one can basically get the current bahavior. Not sure if we need 2. and 3.
I've added 1, and also 2, which was rather simple. Should be enough for now. BTW: I've copied the code from Menu_remote_css_cb, but found out that changing "Use remote CSS" in the tools menu (as well as "Load image backgrounds") is only applied to the current tab, while the change is actually global (which is visible when reloading another tab). That's somewhat confusing.
- Security/privacy (cookies?): I'm not sure whether there is anything left to do.
It should respect the rules from domainrc, but as far as I tested it does that.
OK.
- Displaying image backgrounds at once, not line by line: there is already an hardcoded option, so changing is simple, even make it a user option.
"background-attachment" is postponed. Furthermore, other features are missing, which make background images look strange, e. g. that you only see a part of the logo at <http://google.com>.
Do you know what missing features cause this?
As far as I see, it is the "height" attribute. Often, an area (<div>) is assigned a background image as well as width and height of the image itself. This way, the image (which is regarded as presentation detail) is only defined by CSS, not in HTML. Sebastian
Hi Sebastian, On Tue, Nov 19, 2013 at 03:59:01PM +0100, Sebastian Geerken wrote:
Hi!
I'd like to bring image backgrounds to a (temporary) end; before, I'd like to finish these tasks (see also doxygen documentation):
I'm resuming my work on this issue. Just finished a first read pass among the large changesets in the new repo (68). I've taken some notes and have a few comments from it, and some things to review. Next, I'll review the past emails you sent me focusing on specific things. The question is, is there anything new/obsolete to review or focus here now? -- Cheers Jorge.-
On Do, Nov 21, 2013, Jorge Arellano Cid wrote:
On Tue, Nov 19, 2013 at 03:59:01PM +0100, Sebastian Geerken wrote:
I'd like to bring image backgrounds to a (temporary) end; before, I'd like to finish these tasks (see also doxygen documentation):
I'm resuming my work on this issue. Just finished a first read pass among the large changesets in the new repo (68). I've taken some notes and have a few comments from it, and some things to review.
Good!
Next, I'll review the past emails you sent me focusing on specific things. The question is, is there anything new/obsolete to review or focus here now?
You might also be interested in the following changes: c7a45fe8a24c: Getting toplevel widgets working. (The new function a_Image_new_with_dw does what a_Image_new did before.) f44e841bb521: Extension of the ImgRenderer interface. This is actually incomplete: a_Image_abort (and so ImgRenderer::abort) is not called in some cases, see documentation (html/dw-images-and-backgrounds.html). Does not play an important role, but the "abort" method could be used by image *widgets* to show that retrieving image data has failed (e. g. by a broken image frame). 9b8435e69e84: Stopping cache clients for background image. (Already mentioned in a mail.) Sebastian
Hi! Image backgrounds are now in the main repository, at <http://hg.dillo.org/dillo>. On Tue, Nov 19, 2013, Sebastian Geerken wrote:
- Displaying image backgrounds at once, not line by line: there is already an hardcoded option, so changing is simple, even make it a user option.
Drawing instantly is now the default. To change this, modify "drawBackgroundLineByLine" in "dw/style.cc". Sebastian
participants (3)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
sgeerken＠dillo.org