Hi! As I wrote in a previois post, bookmarks do not work. It seems that bookmarks.dpi crashes: ---------------------------------------------------------------------- $ gdb /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi core GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1 Copyright (C) 2014 Free Software Foundation, Inc. [...] Reading symbols from /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi...done. [New LWP 5661] Core was generated by `/usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi'. Program terminated with signal SIGSEGV, Segmentation fault. #0 Bms_load () at bookmarks.c:745 745 p = strchr(p, ' '); *p = 0; (gdb) l 740 if (buf[0] == 's') { 741 /* get section, url and title */ 742 section = strtol(buf + 1, NULL, 10); 743 p = strchr(buf, ' '); *p = 0; 744 url = ++p; 745 p = strchr(p, ' '); *p = 0; 746 title = ++p; 747 p = strchr(p, '\n'); *p = 0; 748 u_title = Unescape_html_str(title); 749 Bms_add(section, url, u_title); (gdb) p p $1 = 0x1 <error: Cannot access memory at address 0x1> (gdb) bt #0 Bms_load () at bookmarks.c:745 #1 Bms_cond_load () at bookmarks.c:792 #2 Bmsrv_parse_token (Buf=0x1814280 "<cmd='open_url' url='dpi:/bm/' '>", sh=0x1810200) at bookmarks.c:1605 #3 main () at bookmarks.c:1746 ---------------------------------------------------------------------- Sebastian
Hi Sebastian, there is probabely something in your bm.txt that the current code doesn't expect. I tried to make the bookmarks file parser a bit safer (see attached patch). Could you please try if it fixes your case? Cheers, Johannes On Sat, Jan 23, 2016 at 03:08:31PM +0100, Sebastian Geerken wrote:
Hi!
As I wrote in a previois post, bookmarks do not work. It seems that bookmarks.dpi crashes:
---------------------------------------------------------------------- $ gdb /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi core GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1 Copyright (C) 2014 Free Software Foundation, Inc. [...] Reading symbols from /usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi...done. [New LWP 5661] Core was generated by `/usr/local/lib/dillo/dpi/bookmarks/bookmarks.dpi'. Program terminated with signal SIGSEGV, Segmentation fault. #0 Bms_load () at bookmarks.c:745 745 p = strchr(p, ' '); *p = 0; (gdb) l 740 if (buf[0] == 's') { 741 /* get section, url and title */ 742 section = strtol(buf + 1, NULL, 10); 743 p = strchr(buf, ' '); *p = 0; 744 url = ++p; 745 p = strchr(p, ' '); *p = 0; 746 title = ++p; 747 p = strchr(p, '\n'); *p = 0; 748 u_title = Unescape_html_str(title); 749 Bms_add(section, url, u_title); (gdb) p p $1 = 0x1 <error: Cannot access memory at address 0x1> (gdb) bt #0 Bms_load () at bookmarks.c:745 #1 Bms_cond_load () at bookmarks.c:792 #2 Bmsrv_parse_token (Buf=0x1814280 "<cmd='open_url' url='dpi:/bm/' '>", sh=0x1810200) at bookmarks.c:1605 #3 main () at bookmarks.c:1746 ----------------------------------------------------------------------
Sebastian
_______________________________________________ Dillo-dev mailing list Dillo-dev at dillo.org http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev
On So, Jan 24, 2016, Johannes Hofmann wrote:
there is probabely something in your bm.txt that the current code doesn't expect. I tried to make the bookmarks file parser a bit safer (see attached patch). Could you please try if it fixes your case?
Thanks, it worked. First, the list was empty, but as soon as I bookmarked another page, all links were displayed again. (I believe the section line ":s0: ..." got damaged when editing the file directly.) Do you want to commit it to hg.dillo.org? It this case, I'll simply merge it into dillo_grows. Sebastian PS: Still one problem left: cookies.dpi hangs sometimes.
On Mon, Jan 25, 2016 at 12:44:22AM +0100, Sebastian Geerken wrote:
On So, Jan 24, 2016, Johannes Hofmann wrote:
there is probabely something in your bm.txt that the current code doesn't expect. I tried to make the bookmarks file parser a bit safer (see attached patch). Could you please try if it fixes your case?
Thanks, it worked. First, the list was empty, but as soon as I bookmarked another page, all links were displayed again. (I believe the section line ":s0: ..." got damaged when editing the file directly.)
Do you want to commit it to hg.dillo.org? It this case, I'll simply merge it into dillo_grows.
I plan to commit it to the main repository tonight.
Sebastian
PS: Still one problem left: cookies.dpi hangs sometimes. _______________________________________________ Dillo-dev mailing list Dillo-dev at dillo.org http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev
participants (3)
-
Johannes.Hofmann＠gmx.de -
johannes.hofmann＠gmx.de
-
sgeerken＠dillo.org