Hi i save html files in a dir called /html (dillo saves them correctly there 99.99% of the time) i have a dir /html/tmp (dir named tmp in /html) but sometimes and i can't pin down what causes it the file line becomes /tmp and if i try to backspace it just adds more /tmp/tmp/tmp etc so i have to cancel the file save and redo the dialog i can click on tmp and the dir changes to /html/tmp and saving file there is no problem any one experiencing something similar or any ideas?
I see something like this. Selecting all in the text box allows rewriting the whole path. On Monday, 3 June 2024 18:35:03 EDT, pastebin@gmx.com wrote:
Hi
i save html files in a dir called /html (dillo saves them correctly there 99.99% of the time)
i have a dir /html/tmp (dir named tmp in /html)
but sometimes and i can't pin down what causes it the file line becomes /tmp and if i try to backspace it just adds more /tmp/tmp/tmp etc so i have to cancel the file save and redo the dialog i can click on tmp and the dir changes to /html/tmp and saving file there is no problem
any one experiencing something similar or any ideas?
any idea what triggers it? On Mon, 03 Jun 2024 23:02:21 -0400 "Charles E. Lehner" <cel@celehner.com> wrote:
I see something like this. Selecting all in the text box allows rewriting the whole path.
On Monday, 3 June 2024 18:35:03 EDT, pastebin@gmx.com wrote:
Hi
i save html files in a dir called /html (dillo saves them correctly there 99.99% of the time)
i have a dir /html/tmp (dir named tmp in /html)
but sometimes and i can't pin down what causes it the file line becomes /tmp and if i try to backspace it just adds more /tmp/tmp/tmp etc so i have to cancel the file save and redo the dialog i can click on tmp and the dir changes to /html/tmp and saving file there is no problem
any one experiencing something similar or any ideas?
Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi, On Sat, Jun 08, 2024 at 08:24:25AM -0600, pastebin@gmx.com wrote:
any idea what triggers it?
Can you share the output of (with dillo opened): % ls -ld /html /html/tmp % ps -fC dillo Which version of Dillo and FLTK do you have? Cannot reproduce with Dillo 3.1.1 and FLTK 1.3.9. I'm thinking it may be related to file access permissions, which user are you running Dillo with? If you can reproduce it systematically you may be able to send us a trace with strace: % dillo & % strace -f -o trace.log -p $! ... Reproduce the problem and Ctrl+C % gzip trace.log Then send trace.log.gz, which should contain any file system access error there. Rodrigo.
Hi On Sat, 8 Jun 2024 16:49:45 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
Hi,
On Sat, Jun 08, 2024 at 08:24:25AM -0600, pastebin@gmx.com wrote:
any idea what triggers it? <- Charles and what do you see duplicated ?
Can you share the output of (with dillo opened):
it doesn't happen very ofter and i can't cause it to happen - next time it occurs i will send the strace and a png of it i was 'happy' to see that Charles also saw it happen and wanted to know what he had duplicated in place of my /tmp/tmp/tmp etc
% ls -ld /html /html/tmp % ps -fC dillo
Which version of Dillo and FLTK do you have? Cannot reproduce with Dillo 3.1.1 and FLTK 1.3.9.
I'm thinking it may be related to file access permissions,
i'm thinking it has to do with 'accidentally hitting an arrow key before i want to type a file name to save' but nothing is reproducable
which user > are you running Dillo with?
If you can reproduce it systematically you may be able to send us a trace with strace:
% dillo & % strace -f -o trace.log -p $!
i will run this strace from a script from now on - hoping it happens :)
... Reproduce the problem and Ctrl+C % gzip trace.log
Then send trace.log.gz, which should contain any file system access error there.
Rodrigo. _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi, On Sat, Jun 08, 2024 at 10:04:40AM -0600, pastebin@gmx.com wrote:
Which version of Dillo and FLTK do you have? Cannot reproduce with Dillo 3.1.1 and FLTK 1.3.9.
I'm thinking it may be related to file access permissions,
i'm thinking it has to do with 'accidentally hitting an arrow key before i want to type a file name to save' but nothing is reproducable
I reviewed the code and it doesn't seem this is likely to be on Dillo side, as we only call fl_file_chooser() of FLTK: https://github.com/dillo-browser/dillo/blob/e89a2293ebb3331dca46f5edf0108231... Please report your FLTK version, as it may be already solved on 1.3.9 and that could explain why I don't see it. Rodrigo.
Hi, i have fltk-1.3.4-2 installed - i will upgrade to latest fltk-1.3.9 and see what happens question for Charles what version fltk? is it even fltk related? what repetive text do you get repeated? is it a sub dir in your dillo save dir? or a file name? On Sat, 8 Jun 2024 21:31:32 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
Hi,
On Sat, Jun 08, 2024 at 10:04:40AM -0600, pastebin@gmx.com wrote:
Which version of Dillo and FLTK do you have? Cannot reproduce with Dillo 3.1.1 and FLTK 1.3.9.
it isn't reproducible for anything i can do to try to make it happen it hasn't happened yet with 3.1.0 and fltk-1.3.4-2 i will update to dillo-3.1.1 and fltk-1.3.9
I'm thinking it may be related to file access permissions,
i'm thinking it has to do with 'accidentally hitting an arrow key before i want to type a file name to save' but nothing is reproducable
I reviewed the code and it doesn't seem this is likely to be on Dillo side, as we only call fl_file_chooser() of FLTK:
https://github.com/dillo-browser/dillo/blob/e89a2293ebb3331dca46f5edf0108231...
Please report your FLTK version, as it may be already solved on 1.3.9 and that could explain why I don't see it.
Rodrigo. _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi i haven't had this problem since upgrading to fltk-1.3.9 On Sat, 8 Jun 2024 21:31:32 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
Hi,
On Sat, Jun 08, 2024 at 10:04:40AM -0600, pastebin@gmx.com wrote:
Which version of Dillo and FLTK do you have? Cannot reproduce with Dillo 3.1.1 and FLTK 1.3.9.
I'm thinking it may be related to file access permissions,
i'm thinking it has to do with 'accidentally hitting an arrow key before i want to type a file name to save' but nothing is reproducable
I reviewed the code and it doesn't seem this is likely to be on Dillo side, as we only call fl_file_chooser() of FLTK:
https://github.com/dillo-browser/dillo/blob/e89a2293ebb3331dca46f5edf0108231...
Please report your FLTK version, as it may be already solved on 1.3.9 and that could explain why I don't see it.
Rodrigo. _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi i got it to reproduce dillo any url right click mouse -> 'save page as' in the Filename: text box it shows /html/ highlighted in blue /html is my default save dir from dillorc save_dir=/html the i just type r (or any key) and it now shows /tmp/r hitting any key now just dups the /tmp/r on an on if the blue highlight is erased by clicking mouse in text box then it is normal it is the highlighting that is the problem Mon, 3 Jun 2024 16:35:03 -0600 pastebin@gmx.com wrote:
Hi
i save html files in a dir called /html (dillo saves them correctly there 99.99% of the time)
i have a dir /html/tmp (dir named tmp in /html)
but sometimes and i can't pin down what causes it the file line becomes /tmp and if i try to backspace it just adds more /tmp/tmp/tmp etc so i have to cancel the file save and redo the dialog i can click on tmp and the dir changes to /html/tmp and saving file there is no problem
any one experiencing something similar or any ideas? _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi, On Mon, Jul 01, 2024 at 03:31:40PM -0600, pastebin@gmx.com wrote:
Hi
i got it to reproduce
dillo any url
right click mouse -> 'save page as' in the Filename: text box it shows /html/ highlighted in blue
/html is my default save dir from dillorc save_dir=/html
the i just type r (or any key) and it now shows /tmp/r hitting any key now just dups the /tmp/r on an on
if the blue highlight is erased by clicking mouse in text box then it is normal
it is the highlighting that is the problem
Thanks!, I can reproduce it now. This is a FLTK bug, here is a small program that reproduces. I will report it to the FLTK project. /* Build with: g++ test.cpp -o test -lfltk */ #include <cstdlib> #include <unistd.h> #include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/Fl_Button.H> #include <FL/Fl_File_Chooser.H> void cb_file_select(Fl_Widget *o, void *v) { char msg[256]; char *newfile = fl_file_chooser("Choose a file", NULL, NULL); if (newfile != NULL) { sprintf(msg, "You choose %s", newfile); fl_message(msg); } } int main (int argc, char ** argv) { chdir("/tmp"); Fl_Window *window = new Fl_Window(300, 300, 200, 200, "Foo"); Fl_Button *button = new Fl_Button(60, 40, 80, 40, "Select file"); button->callback(cb_file_select); window->end(); window->show(argc, argv); return(Fl::run()); }
This is a FLTK bug, here is a small program that reproduces. I will report it to the FLTK project.
Reported here: https://github.com/fltk/fltk/issues/1004
Hi i'm actually glad you were able to reproduce it - i've got so much custom source on this machine i was afraid it was me :) thanks for your work on this - and thanks for this fltk program On Tue, 2 Jul 2024 20:55:10 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
Hi,
On Mon, Jul 01, 2024 at 03:31:40PM -0600, pastebin@gmx.com wrote:
Hi
i got it to reproduce
dillo any url
right click mouse -> 'save page as' in the Filename: text box it shows /html/ highlighted in blue
/html is my default save dir from dillorc save_dir=/html
the i just type r (or any key) and it now shows /tmp/r hitting any key now just dups the /tmp/r on an on
if the blue highlight is erased by clicking mouse in text box then it is normal
it is the highlighting that is the problem
Thanks!, I can reproduce it now.
This is a FLTK bug, here is a small program that reproduces. I will report it to the FLTK project.
/* Build with: g++ test.cpp -o test -lfltk */ #include <cstdlib> #include <unistd.h>
#include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/Fl_Button.H> #include <FL/Fl_File_Chooser.H>
void cb_file_select(Fl_Widget *o, void *v) { char msg[256]; char *newfile = fl_file_chooser("Choose a file", NULL, NULL);
if (newfile != NULL) { sprintf(msg, "You choose %s", newfile); fl_message(msg); } }
int main (int argc, char ** argv) { chdir("/tmp"); Fl_Window *window = new Fl_Window(300, 300, 200, 200, "Foo");
Fl_Button *button = new Fl_Button(60, 40, 80, 40, "Select file"); button->callback(cb_file_select); window->end();
window->show(argc, argv);
return(Fl::run()); } _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi a little contribution to your code in case someone wants to make a huge statically compiled version of the program :) g++ -O2 test.cpp-static -o test /usr/local/lib/libfltk.a /usr/local/lib/libX11.a /usr/local/lib/libxcb.a /usr/local/lib/libXft.a /usr/local/lib/libfontconfig.a /lib/libdl.a /usr/local/lib/libXfixes.a /usr/local/lib/libXrender.a /usr/local/lib/libXcursor.a /usr/local/lib/libXinerama.a /usr/local/lib/libXext.a /usr/local/lib/libXau.a /usr/local/lib/libXdmcp.a /usr/local/lib/libfreetype.a /usr/local/lib/libexpat.a /usr/local/lib/libXrender.a /usr/local/lib/libX11.a /usr/local/lib/libXfixes.a /usr/local/lib/libpng.a /lib/libz.a /usr/local/lib/libharfbuzz.a /lib/libbz2.a /lib/libpthread.a On Tue, 2 Jul 2024 20:55:10 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
Hi,
On Mon, Jul 01, 2024 at 03:31:40PM -0600, pastebin@gmx.com wrote:
Hi
i got it to reproduce
dillo any url
right click mouse -> 'save page as' in the Filename: text box it shows /html/ highlighted in blue
/html is my default save dir from dillorc save_dir=/html
the i just type r (or any key) and it now shows /tmp/r hitting any key now just dups the /tmp/r on an on
if the blue highlight is erased by clicking mouse in text box then it is normal
it is the highlighting that is the problem
Thanks!, I can reproduce it now.
This is a FLTK bug, here is a small program that reproduces. I will report it to the FLTK project.
/* Build with: g++ test.cpp -o test -lfltk */ #include <cstdlib> #include <unistd.h>
#include <FL/Fl.H> #include <FL/Fl_Window.H> #include <FL/Fl_Button.H> #include <FL/Fl_File_Chooser.H>
void cb_file_select(Fl_Widget *o, void *v) { char msg[256]; char *newfile = fl_file_chooser("Choose a file", NULL, NULL);
if (newfile != NULL) { sprintf(msg, "You choose %s", newfile); fl_message(msg); } }
int main (int argc, char ** argv) { chdir("/tmp"); Fl_Window *window = new Fl_Window(300, 300, 200, 200, "Foo");
Fl_Button *button = new Fl_Button(60, 40, 80, 40, "Select file"); button->callback(cb_file_select); window->end();
window->show(argc, argv);
return(Fl::run()); } _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
On Wed, Jul 03, 2024 at 12:01:47PM -0600, pastebin@gmx.com wrote:
Hi
a little contribution to your code in case someone wants to make a huge statically compiled version of the program :)
g++ -O2 test.cpp-static -o test /usr/local/lib/libfltk.a /usr/local/lib/libX11.a /usr/local/lib/libxcb.a /usr/local/lib/libXft.a /usr/local/lib/libfontconfig.a /lib/libdl.a /usr/local/lib/libXfixes.a /usr/local/lib/libXrender.a /usr/local/lib/libXcursor.a /usr/local/lib/libXinerama.a /usr/local/lib/libXext.a /usr/local/lib/libXau.a /usr/local/lib/libXdmcp.a /usr/local/lib/libfreetype.a /usr/local/lib/libexpat.a /usr/local/lib/libXrender.a /usr/local/lib/libX11.a /usr/local/lib/libXfixes.a /usr/local/lib/libpng.a /lib/libz.a /usr/local/lib/libharfbuzz.a /lib/libbz2.a /lib/libpthread.a
Thanks. A fix was provided by FLTK developer Albrecht Schlosser: https://github.com/fltk/fltk/issues/1004#issuecomment-2209144366 You can take the "branch-1.3" branch which also contains the fix (f34719). $ git clone https://github.com/fltk/fltk $ cd fltk $ git checkout branch-1.3 ... Can you check it solves your issue? They are waiting for confirmation to close the issue on their side. Best, Rodrigo.
Hi with the git clone https://github.com/fltk/fltk i get Cloning into 'fltk'... warning: templates not found in /usr/share/git-core/templates remote: Enumerating objects: 92570, done. remote: Counting objects: 100% (2620/2620), done. remote: Compressing objects: 100% (1123/1123), done. remote: Total 92570 (delta 1721), reused 2113 (delta 1485), pack-reused 89950 Receiving objects: 100% (92570/92570), 42.09 MiB | 1.28 MiB/s, done. Resolving deltas: 100% (75407/75407), done. /usr/src/fltk > cd fltk /usr/src/fltk/fltk > git checkout branch-1.3 branch 'branch-1.3' set up to track 'origin/branch-1.3'. Switched to a new branch 'branch-1.3' autogen.sh configure --enable-shared make make install /usr/local/lib -rw-r--r-- 1 root root 48325 Jul 04 2024 14:21:52 Fl_File_Chooser2.cxx -rw-r--r-- 1 root root 15407 Jul 04 2024 14:21:52 Fl_File_Chooser.cxx -rw-r--r-- 1 root root 15000 Jul 04 2024 14:21:52 Fl_File_Chooser.fl the problem is 2 parts in dillo - switching from the savedir to /tmp dir when first 'd' pressed and then repeating /tmp/d/tmp/d when another 'd' is pressed the fix only fixes the repeat to /tmp/d/tmp/d when a second d is pressed but the changing from savedir to /tmp/d still happens when first d is pressed your program only shows the second part of the problem (and that part is fixed) since it does the chdir("/tmp") itself and not what happens with dillo when the first 'd' is pressed the fix only fixes the repeat not the initial change to /tmp dir from the savedir On Thu, 4 Jul 2024 19:57:59 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
On Wed, Jul 03, 2024 at 12:01:47PM -0600, pastebin@gmx.com wrote:
Hi
a little contribution to your code in case someone wants to make a huge statically compiled version of the program :)
g++ -O2 test.cpp-static -o test /usr/local/lib/libfltk.a /usr/local/lib/libX11.a /usr/local/lib/libxcb.a /usr/local/lib/libXft.a /usr/local/lib/libfontconfig.a /lib/libdl.a /usr/local/lib/libXfixes.a /usr/local/lib/libXrender.a /usr/local/lib/libXcursor.a /usr/local/lib/libXinerama.a /usr/local/lib/libXext.a /usr/local/lib/libXau.a /usr/local/lib/libXdmcp.a /usr/local/lib/libfreetype.a /usr/local/lib/libexpat.a /usr/local/lib/libXrender.a /usr/local/lib/libX11.a /usr/local/lib/libXfixes.a /usr/local/lib/libpng.a /lib/libz.a /usr/local/lib/libharfbuzz.a /lib/libbz2.a /lib/libpthread.a
Thanks.
A fix was provided by FLTK developer Albrecht Schlosser:
https://github.com/fltk/fltk/issues/1004#issuecomment-2209144366
You can take the "branch-1.3" branch which also contains the fix (f34719).
$ git clone https://github.com/fltk/fltk $ cd fltk $ git checkout branch-1.3 ...
Can you check it solves your issue? They are waiting for confirmation to close the issue on their side.
Best, Rodrigo. _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi,
the problem is 2 parts in dillo - switching from the savedir to /tmp dir when first 'd' pressed and then repeating /tmp/d/tmp/d when another 'd' is pressed
the fix only fixes the repeat to /tmp/d/tmp/d when a second d is pressed but the changing from savedir to /tmp/d still happens when first d is pressed
your program only shows the second part of the problem (and that part is fixed) since it does the chdir("/tmp") itself and not what happens with dillo when the first 'd' is pressed
the fix only fixes the repeat not the initial change to /tmp dir from the savedir
This is a "design" decision by FLTK[1], as when a non-/ character is added it is considered as a relative path *to the current directory* which is always set to /tmp in Dillo (regardless of the save_dir) and it gets prefixed. [1]: https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570 One option to work around it is to chdir() to the save_dir, so at least it would make a bit more sense. Another good idea is to switch to the native file chooser which also comes with other niceties (but this problem will continue there if the native file chooser is not available). Rodrigo.
Hi, Thanks Rodrigo for working with Albrecht-S i think this issue is now resolved for me when saving an html 1. if i like the highlightd name given in the Filename: box i just click 'ok' 2. if i want to add more text or suffix to the highlighted name given in the Filename: box i just hit 'end' key (easier then using mouse click in filename box) and enter what i want 3, if i want to enter a completely new name to save in save_dir (problem being dillo enters /tmp now) i don't know if changing rc = chdir("/tmp"); to rc = chdir("/html"); in src/paths.cc is what you meant by your suggestion :
One option to work around it is to chdir() to the save_dir, so at least it would make a bit more sense.
but by doing so now it now puts /html/'firstkeypressed' an i can put the name i want there (i didn't know how to put the save_dir variable there instead of my hardcoded "/html" which would be better) (i get make error ->? save_dir not defined in this scope) so all seems fixed - for me anyway thank Albrecht-S for his work and interesting posts in the https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570 i think the only issue left here is Albrecht-S saying that hitting '/' leaves a '/' there my hitting the '/' key just erases highlight and leaves nothing in the filename box :) On Sat, 6 Jul 2024 14:10:22 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
Hi,
the problem is 2 parts in dillo - switching from the savedir to /tmp dir when first 'd' pressed and then repeating /tmp/d/tmp/d when another 'd' is pressed
the fix only fixes the repeat to /tmp/d/tmp/d when a second d is pressed but the changing from savedir to /tmp/d still happens when first d is pressed
your program only shows the second part of the problem (and that part is fixed) since it does the chdir("/tmp") itself and not what happens with dillo when the first 'd' is pressed
the fix only fixes the repeat not the initial change to /tmp dir from the savedir
This is a "design" decision by FLTK[1], as when a non-/ character is added it is considered as a relative path *to the current directory* which is always set to /tmp in Dillo (regardless of the save_dir) and it gets prefixed.
[1]: https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570
One option to work around it is to chdir() to the save_dir, so at least it would make a bit more sense.
yes i edited src/paths.cc rc = chdir("/html"); // rc = chdir("/tmp");
Another good idea is to switch to the native file chooser which also comes with other niceties (but this problem will continue there if the native file chooser is not available).
what source is the 'native file chooser' in?
Rodrigo. _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi, On Sat, Jul 06, 2024 at 09:56:17AM -0600, pastebin@gmx.com wrote:
Hi,
Thanks Rodrigo for working with Albrecht-S
i think this issue is now resolved for me
when saving an html
1. if i like the highlightd name given in the Filename: box i just click 'ok'
2. if i want to add more text or suffix to the highlighted name given in the Filename: box i just hit 'end' key (easier then using mouse click in filename box) and enter what i want
3, if i want to enter a completely new name to save in save_dir (problem being dillo enters /tmp now)
i don't know if changing rc = chdir("/tmp"); to rc = chdir("/html"); in src/paths.cc is what you meant by your suggestion :
One option to work around it is to chdir() to the save_dir, so at least it would make a bit more sense.
but by doing so now
it now puts /html/'firstkeypressed' an i can put the name i want there (i didn't know how to put the save_dir variable there instead of my hardcoded "/html" which would be better) (i get make error ->? save_dir not defined in this scope)
so all seems fixed - for me anyway
Yeah, that's what I meant, but instead of hard-coding the "/html" we pick it from the preferences as `pref.save_dir` (should be an easy patch).
thank Albrecht-S for his work and interesting posts in the https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570
i think the only issue left here is Albrecht-S saying that hitting '/' leaves a '/' there my hitting the '/' key just erases highlight and leaves nothing in the filename box :)
Yeah, I'll try to find where it is coming from, but I want finish other things first. Best, Rodrigo.
Hi besides changing the rc = chdir("/tmp"); in src/paths.c to rc = chdir("/html"); i also changed the rc = chdir("/tmp"); to rc = chdir("/html"); in dpi/datauri.c and dpi/ftp.c everything seems okay but if these are 'wrong' please let me know On Sun, 7 Jul 2024 19:15:57 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
Hi,
On Sat, Jul 06, 2024 at 09:56:17AM -0600, pastebin@gmx.com wrote:
Hi,
Thanks Rodrigo for working with Albrecht-S
i think this issue is now resolved for me
when saving an html
1. if i like the highlightd name given in the Filename: box i just click 'ok'
2. if i want to add more text or suffix to the highlighted name given in the Filename: box i just hit 'end' key (easier then using mouse click in filename box) and enter what i want
3, if i want to enter a completely new name to save in save_dir (problem being dillo enters /tmp now)
i don't know if changing rc = chdir("/tmp"); to rc = chdir("/html"); in src/paths.cc is what you meant by your suggestion :
One option to work around it is to chdir() to the save_dir, so at least it would make a bit more sense.
but by doing so now
it now puts /html/'firstkeypressed' an i can put the name i want there (i didn't know how to put the save_dir variable there instead of my hardcoded "/html" which would be better) (i get make error ->? save_dir not defined in this scope)
so all seems fixed - for me anyway
Yeah, that's what I meant, but instead of hard-coding the "/html" we pick it from the preferences as `pref.save_dir` (should be an easy patch).
thank Albrecht-S for his work and interesting posts in the https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570
i think the only issue left here is Albrecht-S saying that hitting '/' leaves a '/' there my hitting the '/' key just erases highlight and leaves nothing in the filename box :)
Yeah, I'll try to find where it is coming from, but I want finish other things first.
Best, Rodrigo. _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
Hi it is the highlight that is the problem when removed by clicking in the filename location all is good when any 'key' but '/' is done it puts /tmp/'key' there with '/' it just clears the box and nothing is put there fltk knows about the save_dir because it puts it there in the first place but loses site of it when highlight is cleared and (i guess) default dir '/tmp' is used just not using the hightlight would probably solve the problem cosmetically but not algorithmically wise whoever is putting '/tmp/key' there should put the 'save_dir/key' there instead On Thu, 4 Jul 2024 19:57:59 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
A fix was provided by FLTK developer Albrecht Schlosser:
https://github.com/fltk/fltk/issues/1004#issuecomment-2209144366
You can take the "branch-1.3" branch which also contains the fix (f34719).
$ git clone https://github.com/fltk/fltk $ cd fltk $ git checkout branch-1.3 ...
Can you check it solves your issue? They are waiting for confirmation to close the issue on their side.
Best, Rodrigo. _______________________________________________ Dillo-dev mailing list -- dillo-dev@mailman3.com To unsubscribe send an email to dillo-dev-leave@mailman3.com
participants (3)
-
Charles E. Lehner -
pastebin＠gmx.com -
Rodrigo Arias