Hi'all, The next version (14) of my tab/frame/keyboard navigation patch is ready (see bottom of this message for download instructions). /* ATTENTION */ Version 13 of the patch was missing a line, which made it segfault when clicking on some images. That is fixed in this release. This is the ONLY difference between version 13 and version 14. I sent a small patch to the mailing list which fixes this problem in version 13, if you already downloaded version 13 you can apply that patch instead of downloading version 14. The filenames for version 13 and version 14 are the same, if you are in doubt which version you have run md5sum on the file and compare the result with that in this message. /* and now we continue with our scheduled program */ Keyboard navigation has grown up, it is more or less complete now. There have been many internal changes, leading to a much more robust implementation. Links are now highlighted in a distinct way, with a dashed inverse frame around highlighted text. Link navigation should now be reliable in any direction (up, down, left, right). Scrolling movements are minimized, the code starts looking for links in the currently visible part of the document. The Tab/Shift-Tab keys now really work as advertised, they can also be used to move focus between frames. If something doesn't work they way it should (or the way you *think* it should), I want to know! For more info on keyboard navigation, see the doc/Keyboard_Navigation.txt document (after applying the patch, naturally...). More information on tabs can be found in doc/Browser_Tabs.txt, for frames see doc/Browser_Frames.txt. The mailing list archives are also a good place to look for answers to questions relating to this patch. Tabs, Frames and browser bloat ============================== version: 0.8.0-pre patch: dillo-20031110-tabs.patch.gz unpatched: 295956 bytes patched, no tabs, no frames: 312660 bytes patched, with tabs, no frames: 318964 bytes patched, no tabs, with frames: 329076 bytes patched, with tabs, with frames: 335604 bytes (gcc 3.2.2, binutils 2.13.90.0.18, CFLAGS "-Os") Download instructions ===================== The patch is made against 20031110@10:27 CVS. Do not forget to run ./autogen.sh after applying the patch. You can find the patch on the usual (ad-happy, use an ad-blocking proxy or sane browser) site: http://www.geocities.com/ikbenfrank/ More specifically: Dillo 0.8.0-pre (CVS) ===================== http://www.geocities.com/ikbenfrank/dillo-20031110-tabs.patch.gz size: 100110 bytes (gzipped, as downloaded) 449102 bytes (uncompressed) md5sum: 4e11fbbac0945882f8bdedbd0b0f31ac (gzipped, as downloaded) 95f3d0aa78939fd9105d921665a87072 (uncompressed) As always, check the site for the most recent version Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Am Mon, Nov 10, 2003 at 05:36:59PM +0100 schrieb Frank de Lange und sprach:
Hi'all,
The next version (14) of my tab/frame/keyboard navigation patch is ready (see bottom of this message for download instructions).
Works very well. Here are the only things I noticed: If I have a site with frames and navigate around the history isn't updated properly. If you click back then you are on the site before. An additional history per frame would probably do it. Then you could go back in a frame using the popup menu. Using tabs the copy&paste just with selection is kind of weird. You can't select the directory in the location of a site and copy it to the location of a new tab (cos its the same widget). If you select some text in tab#1 you can't copy it to location#2. The following patch is useful if you have a lot of tabs. You can jump from the last to the first and vice versa (using shortcuts). Greets, Stephan --- commands.c.old 2003-11-10 18:37:54.000000000 +0100 +++ commands.c 2003-11-11 17:44:59.000000000 +0100 @@ -429,14 +429,22 @@ void a_Commands_save_link_callback(GtkWi /* VIEW MENU */ void a_Commands_tab_prev_callback(GtkWidget *widget, gpointer client_data) { - BrowserWindow *bw = (BrowserWindow *) client_data; - gtk_notebook_prev_page(GTK_NOTEBOOK(bw->container)); + BrowserWindow *bw = (BrowserWindow *) client_data; + if (gtk_notebook_get_current_page(GTK_NOTEBOOK(bw->container)) != 0) + gtk_notebook_prev_page(GTK_NOTEBOOK(bw->container)); + else + gtk_notebook_set_page(GTK_NOTEBOOK(bw->container), g_list_length(gtk_container_children(bw->container))-1); } void a_Commands_tab_next_callback(GtkWidget *widget, gpointer client_data) { - BrowserWindow *bw = (BrowserWindow *) client_data; - gtk_notebook_next_page(GTK_NOTEBOOK(bw->container)); + BrowserWindow *bw = (BrowserWindow *) client_data; + GtkNotebook *nb = GTK_NOTEBOOK(bw->container); + if (gtk_notebook_get_current_page(GTK_NOTEBOOK(bw->container)) + != g_list_length(gtk_container_children(bw->container))-1) + gtk_notebook_next_page(nb); + else + gtk_notebook_set_page(GTK_NOTEBOOK(bw->container), 0); } #endif
Stephan Goetter wrote:
If I have a site with frames and navigate around the history isn't updated properly. If you click back then you are on the site before. An additional history per frame would probably do it. Then you could go back in a frame using the popup menu.
I'll test if this is a viable option, and add it if it works out OK.
Using tabs the copy&paste just with selection is kind of weird. You can't select the directory in the location of a site and copy it to the location of a new tab (cos its the same widget). If you select some text in tab#1 you can't copy it to location#2.
Yeah, noticed that as well. I'll see if I can find a cure...
The following patch is useful if you have a lot of tabs. You can jump from the last to the first and vice versa (using shortcuts).
I'll try this, and will add it to the patch if it 'feels' right... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Hi Frank,
The next version (14) of my tab/frame/keyboard navigation patch is ready (see bottom of this message for download instructions).
It seems that I cannot paste selected text from a web page. Selecting something works correctly, but pasting with middle-click to something (xterm, gtk2, url entry), does not work. It works if I revert the patch. (tested on the splash page and also on tabbed pages). ("Copy link" menu works) Cheers, -- Melvin Hadasht
Melvin Hadasht wrote:
Hi Frank,
The next version (14) of my tab/frame/keyboard navigation patch is ready (see bottom of this message for download instructions).
It seems that I cannot paste selected text from a web page. Selecting something works correctly, but pasting with middle-click to something (xterm, gtk2, url entry), does not work. It works if I revert the patch. (tested on the splash page and also on tabbed pages). ("Copy link" menu works)
Cheers,
Yes, I noticed this as well. I did not connect it to my patch first, but it seems to be related. Il look into this for the next version. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
participants (3)
-
Frank de Lange -
Melvin Hadasht -
Stephan Goetter