Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark
On Tue, Jul 01, 2003 at 04:07:21PM -0700, Victor Sahlstedt wrote:
I commented out the stuff in the function preceeding gboolean hide_tabs and it compiled.
Great work by the way, I find non-tabbed browsers hardly usable for every-day-usage and as my window manager of choice is the tabless evilwm it's been a pain uptil now.
Tack!
- Victor
Sigh... I put the wrong version of the patch on the site... the version on the site has the definition in the old place. So, next version is now on the site: http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz 40887 bytes 20dffde9c0e5f2134492e138ee707cdd (as is) 09b454800f1b53bd83428a2b62d3e618 (uncompressed) If the previous version worked for you, there is no need to upgrade as the changes are only 'code-cosmetical'... As always, keep an eye on the site for the latest version. This patch was made against yesterday's CVS (20030701). Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
So, next version is now on the site:
http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz 40887 bytes 20dffde9c0e5f2134492e138ee707cdd (as is) 09b454800f1b53bd83428a2b62d3e618 (uncompressed)
And again on http://www.hs.uni-hamburg.de/~stcd102/dillo-20030701-tabs.patch.gz Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198
On Tue, 1 Jul 2003 16:19:13 +0200 Frank de Lange <frank@localhost.localdomain> wrote:
Sigh... I put the wrong version of the patch on the site... the version on the site has the definition in the old place.
So, next version is now on the site:
http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz 40887 bytes 20dffde9c0e5f2134492e138ee707cdd (as is) 09b454800f1b53bd83428a2b62d3e618 (uncompressed)
This one worked out-of-the-box. I was just about to suggest a few things but I noticed that you'd pretty much covered it all;
Functionality ------------- - focus tab contents on tab switch (so key navigation works correctly without having to first click in the tab pane) - focus location bar on switch to empty tab/new tab - new empty tab should show/focus, even when 'tab load in background' is set - after tab delete, switch to NEXT tab instead of PREVIOUS (like mozilla)
- Victor
participants (3)
-
Andreas Schweitzer -
Frank de Lange -
Victor Sahlstedt