[Dillo-dev]file.dpi patch
Hi, i send a small patch to make the file.dpi a little more intuitive than now. The patch make that when one person write only "file:" in the dillo location bar it show the current working directory, like previous dillo file: handlers, instead to show nothing, like now. I have think all side effects that the changes can have and test it. The patch is for the current cvs, but works in previos dillo versions. Diego Sáenz / DarkSpirit diff -pru dillo-cvs20051106-0.8.5-pre-DIRTY/dpi/file.c dillo-cvs20051106-0.8.5-pre-WORK/dpi/file.c --- dillo-cvs20051106-0.8.5-pre-DIRTY/dpi/file.c 2005-06-12 15:44:52.000000000 +0200 +++ dillo-cvs20051106-0.8.5-pre-WORK/dpi/file.c 2005-06-12 15:47:51.000000000 +0200 @@ -747,14 +747,15 @@ static char *File_normalize_path(const c return NULL; str += 5; - if (*str == '\0') - return NULL; /* Skip slashes */ while (str[0] == '/' && str[1] != '\0' && str[1] == '/') str++; - if (*str == '~') { + if (*str == '\0') { + /* Give CWD if the string is only "file:" */ + basename = g_get_current_dir(); + } else if (*str == '~') { if (str[1] == '\0' || str[1] == '/') { /* Expand 'tilde' to user's home */ basename = g_strdup(g_get_home_dir());
On Sun, Jun 12, 2005 at 04:19:04PM +0200, Diego Sáenz wrote:
Hi, i send a small patch to make the file.dpi a little more intuitive than now. The patch make that when one person write only "file:" in the dillo location bar it show the current working directory, like previous dillo file: handlers, instead to show nothing, like now.
I have think all side effects that the changes can have and test it. The patch is for the current cvs, but works in previos dillo versions.
OK, it's on CVS now and will be on 0.8.5. One question to everybody: I have some code to make the file dpi react to DpiBye. This helps to not have a few orphaned file-dpi processes around, after some time of use (ps aux | grep file.dpi). Has anyone have this problem? Do you think is worth adding this last patch to dillo-0.8.5? -- Cheers Jorge.-
El Tue, 14 Jun 2005 09:19:53 -0400 Jorge Arellano Cid <jcid@dillo.org> escribio: ...
One question to everybody:
I have some code to make the file dpi react to DpiBye. This helps to not have a few orphaned file-dpi processes around, after some time of use (ps aux | grep file.dpi).
Has anyone have this problem? Do you think is worth adding this last patch to dillo-0.8.5?
I have that problem and think that it is worth. While the test of the file.dpi path i needed to kill the file-dpi process all the time after doing dpid stop when i reloaded the file.dpi. Diego Sáenz / DarkSpirit
On Wed, Jun 15, 2005 at 03:41:03PM +0200, Diego Sáenz wrote:
El Tue, 14 Jun 2005 09:19:53 -0400 Jorge Arellano Cid <jcid@dillo.org> escribio:
...
One question to everybody:
I have some code to make the file dpi react to DpiBye. This helps to not have a few orphaned file-dpi processes around, after some time of use (ps aux | grep file.dpi).
Has anyone have this problem? Do you think is worth adding this last patch to dillo-0.8.5?
I have that problem and think that it is worth. While the test of the file.dpi path i needed to kill the file-dpi process all the time after doing dpid stop when i reloaded the file.dpi.
OK. I included the patch! (more on my next post). -- Cheers Jorge.-
participants (2)
-
Diego Sáenz -
Jorge Arellano Cid