[patch] change font size on the fly
Hi, attached patch allows to change the font size form the tools menu. I find this quite handy sometimes. What do you think? Cheers, Johannes
On Thu, Jun 11, 2009 at 03:32:35PM +0000, corvid wrote:
Johannes wrote:
attached patch allows to change the font size form the tools menu. I find this quite handy sometimes. What do you think?
As is, it's handy for developers, although it may be confusing for users. Sometimes it works, sometimes it doesn't. When it doesn't it looks as if nothing happened, but when going to another page, the font factor surprises with a change. e.g. http://www.linuxpackages.net (click larger fonts a few times, then go back).
No objections here. (although I've been content since increasing font_min_size a bit)
As is now, I'd go for a plain explanation of font_min_size and font_factor in the FAQ. I'd prefer to polish the patch until is behaves "as expected" in all cases, but that may involve keeping a per page font_factor. It may take some time... -- Cheers Jorge.-
On Fri, Jun 12, 2009 at 12:47:10PM -0400, Jorge Arellano Cid wrote:
On Thu, Jun 11, 2009 at 03:32:35PM +0000, corvid wrote:
Johannes wrote:
attached patch allows to change the font size form the tools menu. I find this quite handy sometimes. What do you think?
As is, it's handy for developers, although it may be confusing for users. Sometimes it works, sometimes it doesn't. When it doesn't it looks as if nothing happened, but when going to another page, the font factor surprises with a change.
e.g. http://www.linuxpackages.net
(click larger fonts a few times, then go back).
That happens when websites specify fixed font sizes (e.g. 12pt). In that case font_factor does not change it. It only changes font sizes like "small", "medium" ... and font sizes relatively defined to the base font. Here is a related discussion: http://css-discuss.incutio.com/?page=ForceFontSize
No objections here. (although I've been content since increasing font_min_size a bit)
As is now, I'd go for a plain explanation of font_min_size and font_factor in the FAQ.
Ok.
I'd prefer to polish the patch until is behaves "as expected" in all cases, but that may involve keeping a per page font_factor. It may take some time...
Hm, let's check what other browsers do. Cheers, Johannes
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de