Hello all, I've hacked up my html.cc too much to provide a proper patch, but it's just one line. If you add: Html_connect_signals(html, list_item); to Html_tag_open_li() (after the item_style->unref(); seemed like a nice place), then links inside lists will work.
On Sat, Oct 06, 2007 at 02:51:50PM +0000, place wrote:
Hello all,
I've hacked up my html.cc too much to provide a proper patch, but it's just one line. If you add:
Html_connect_signals(html, list_item);
to Html_tag_open_li()
(after the item_style->unref(); seemed like a nice place), then links inside lists will work.
I'll set up a cvs repository ASAP, and start adding the patches there. Please be patient, and thanks you all for the patches, keep the stream flowing! Good patches is what makes a project thrive. BTW, place, what's your name? Or do you want to be credited as "place" in the changelog? ;) -- Cheers Jorge.-
Dear all, first of all I want to express my gratitude to Jorge and Sebastian for pushing Dillo forward despite the numerous difficulties. Thanks a lot!!! For the record: Compilation on Debian Etch worked well. I had to use the "--x-includes" and "--x-libraries" options when configuring FLTK, and the test glpuzzle did not compile. On Sat, Oct 06, 2007 at 02:51:50PM +0000, place wrote:
just one line. If you add:
Html_connect_signals(html, list_item);
to Html_tag_open_li()
(after the item_style->unref(); seemed like a nice place), then links inside lists will work.
Unfortunately, I have to report this patch improves the situation substiantially, but does not solve it completely. It seems that the status line at the bottom is not always updated. When you move the pointer over a link and then, without clicking, move the pointer _upwards_ so that it leaves the link area, the link URL remains in the status line. (Moving in other directions is ok.) Moreover, when you move the pointer across several links, the status line sometimes remains empty even if the pointer is over a link. Cheers, -- Matthias Franz
On Sat, Oct 06, 2007 at 02:51:50PM +0000, place wrote:
just one line. If you add:
Html_connect_signals(html, list_item);
to Html_tag_open_li()
(after the item_style->unref(); seemed like a nice place), then links inside lists will work.
Unfortunately, I have to report this patch improves the situation substiantially, but does not solve it completely. It seems that the status line at the bottom is not always updated. When you move the pointer over a link and then, without clicking, move the pointer _upwards_ so that it leaves the link area, the link URL remains in the status line. (Moving in other directions is ok.) Moreover, when you move the pointer across several links, the status line sometimes remains empty even if the pointer is over a link.
Cheers, -- Matthias Franz
I think when the pointer leaves by going up, it's getting enter/leave events instead of motion events, due to the link going right to the top of the textblock. I'm not positive about that, but this seems to fix the problem for me: --- textblock.cc 2007-10-08 21:27:10.000000000 +0000 +++ textblock.cc.new 2007-10-08 21:27:52.000000000 +0000 @@ -483,10 +483,12 @@ void Textblock::enterNotifyImpl (core::EventCrossing *event) { + hoverLink = -1; } void Textblock::leaveNotifyImpl (core::EventCrossing *event) { + (void) emitLinkEnter (-1, -1, -1); } /**
On Mon, Oct 08, 2007 at 09:08:57PM +0200, Matthias Franz wrote:
Dear all,
first of all I want to express my gratitude to Jorge and Sebastian for pushing Dillo forward despite the numerous difficulties. Thanks a lot!!!
Thanks Matthias for these nice lines. -- Cheers Jorge.-
participants (4)
-
bogus＠does.not.exist.com -
Matthias Franz -
None -
place