[patch] move highlighting data into Textblock
Hi, as promised here comes a patch to move highlighting information from struct Word into Textblock to save memory. I had to change the semantics of the highlighting API slightly (see comments) to ensure that the highlighted part is always contiguous. Here are some measurements (with load_images=NO): Page dillo-fltk patched_dillo-fltk dillo1 firefox ============================================================== splash 7240K 7236K xslt [1] 15016K 14220K freebsd [2] 70264K 58084K mysql [3] 186M 148M 232M 200M Obviously the difference is mostly visible on large pages. And firefox is pretty close regarding memory usage. However it needed more than 3 minutes to load the local mysql page compared to 6 seconds for dillo-fltk! Please look out for possible highlight related regressions. Cheers, Johannes [1] http://www.w3.org/TR/xslt [2] http://www.freebsd.org/doc/en/books/handbook/book.html [3] http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz
On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote:
Hi,
as promised here comes a patch to move highlighting information from struct Word into Textblock to save memory. I had to change the semantics of the highlighting API slightly (see comments) to ensure that the highlighted part is always contiguous.
Here are some measurements (with load_images=NO):
Page dillo-fltk patched_dillo-fltk dillo1 firefox ============================================================== splash 7240K 7236K xslt [1] 15016K 14220K freebsd [2] 70264K 58084K mysql [3] 186M 148M 232M 200M
Obviously the difference is mostly visible on large pages. And firefox is pretty close regarding memory usage. However it needed more than 3 minutes to load the local mysql page compared to 6 seconds for dillo-fltk!
Please look out for possible highlight related regressions.
Nice work! Committed. I made some tests here and it looks OK. Now it's in CVS for more testing. -- Cheers Jorge.-
On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote:
Hi,
as promised here comes a patch to move highlighting information from struct Word into Textblock to save memory. I had to change the semantics of the highlighting API slightly (see comments) to ensure that the highlighted part is always contiguous.
Here are some measurements (with load_images=NO):
Page dillo-fltk patched_dillo-fltk dillo1 firefox ============================================================== splash 7240K 7236K xslt [1] 15016K 14220K freebsd [2] 70264K 58084K mysql [3] 186M 148M 232M 200M
Obviously the difference is mostly visible on large pages. And firefox is pretty close regarding memory usage. However it needed more than 3 minutes to load the local mysql page compared to 6 seconds for dillo-fltk!
Please look out for possible highlight related regressions.
With the same msql page: http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz and HUGE_FILESIZE set to 15MB, search for "yen sign". After the fourth match, strange highlights become to happen. -- Cheers Jorge.-
On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote:
On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote:
Hi,
as promised here comes a patch to move highlighting information from struct Word into Textblock to save memory. I had to change the semantics of the highlighting API slightly (see comments) to ensure that the highlighted part is always contiguous.
Here are some measurements (with load_images=NO):
Page dillo-fltk patched_dillo-fltk dillo1 firefox ============================================================== splash 7240K 7236K xslt [1] 15016K 14220K freebsd [2] 70264K 58084K mysql [3] 186M 148M 232M 200M
Obviously the difference is mostly visible on large pages. And firefox is pretty close regarding memory usage. However it needed more than 3 minutes to load the local mysql page compared to 6 seconds for dillo-fltk!
Please look out for possible highlight related regressions.
With the same msql page:
http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz
and HUGE_FILESIZE set to 15MB, search for "yen sign". After the fourth match, strange highlights become to happen.
I only have the Euro sign on my keyboard :-) Searching for it works fine. Do you know how I can enter the Yen sign? Can you try whether this issue is new with my patch? Cheers, Johannes
-- Cheers Jorge.-
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote:
On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote:
On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote:
Hi,
as promised here comes a patch to move highlighting information from struct Word into Textblock to save memory. I had to change the semantics of the highlighting API slightly (see comments) to ensure that the highlighted part is always contiguous.
Here are some measurements (with load_images=NO):
Page dillo-fltk patched_dillo-fltk dillo1 firefox ============================================================== splash 7240K 7236K xslt [1] 15016K 14220K freebsd [2] 70264K 58084K mysql [3] 186M 148M 232M 200M
Obviously the difference is mostly visible on large pages. And firefox is pretty close regarding memory usage. However it needed more than 3 minutes to load the local mysql page compared to 6 seconds for dillo-fltk!
Please look out for possible highlight related regressions.
With the same msql page:
http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz
and HUGE_FILESIZE set to 15MB, search for "yen sign". After the fourth match, strange highlights become to happen.
I only have the Euro sign on my keyboard :-) Searching for it works fine. Do you know how I can enter the Yen sign?
No, but I'm talking of the string "yen sign" fed to find text! :-)
Can you try whether this issue is new with my patch?
I did. -- Cheers Jorge.-
On Thu, Jun 19, 2008 at 06:28:26PM -0400, Jorge Arellano Cid wrote:
On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote:
On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote:
On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote:
Hi,
as promised here comes a patch to move highlighting information from struct Word into Textblock to save memory. I had to change the semantics of the highlighting API slightly (see comments) to ensure that the highlighted part is always contiguous.
Here are some measurements (with load_images=NO):
Page dillo-fltk patched_dillo-fltk dillo1 firefox ============================================================== splash 7240K 7236K xslt [1] 15016K 14220K freebsd [2] 70264K 58084K mysql [3] 186M 148M 232M 200M
Obviously the difference is mostly visible on large pages. And firefox is pretty close regarding memory usage. However it needed more than 3 minutes to load the local mysql page compared to 6 seconds for dillo-fltk!
Please look out for possible highlight related regressions.
With the same msql page:
http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz
and HUGE_FILESIZE set to 15MB, search for "yen sign". After the fourth match, strange highlights become to happen.
I only have the Euro sign on my keyboard :-) Searching for it works fine. Do you know how I can enter the Yen sign?
No, but I'm talking of the string "yen sign" fed to find text! :-)
Ah, I see :-). I can reproduce it now. I will have a look at it. Cheers, Johannes
Can you try whether this issue is new with my patch?
I did.
-- Cheers Jorge.-
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
Jorge wrote:
On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote:
I only have the Euro sign on my keyboard :-) Searching for it works fine. Do you know how I can enter the Yen sign?
No, but I'm talking of the string "yen sign" fed to find text! :-)
Not entirely on topic, then, but: compose worked well enough for my configuration once I went to fltk::compose() and put the // See if they type the compose prefix key: if (i == RightCtrlKey || i == 0xff20/* Multi-Key */) { compose_state = 1; return true; } ahead of the // Alt+letters are reserved for shortcuts. But alt+foreign letters // has to be allowed, because some key layouts require alt to be held // down in order to type them... if ((e_state & (ALT|META)) && !(ascii & 128)) return false; (my hazy recollection is that Multi_Key turned on META in e_state) Their site wouldn't let me register to bring up the matter, although it probably wouldn't have made any difference anyway (I note that recent talk about 2.0 in fltk.development has a lot of "somebody should" but nobody wants to be that somebody.)
Hi, attached patch fixes the issue here. I had just recently switched the code from using hlStart[layer].index < 0 to hlStart[layer].index > hlEnd[layer].index to indicate that nothing is highlighted. It turned out that I had forgotten to adapt some parts. In addition this patch cleans up some rough edges. Cheers, Johannes On Thu, Jun 19, 2008 at 06:28:26PM -0400, Jorge Arellano Cid wrote:
On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote:
On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote:
On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote:
Hi,
as promised here comes a patch to move highlighting information from struct Word into Textblock to save memory. I had to change the semantics of the highlighting API slightly (see comments) to ensure that the highlighted part is always contiguous.
Here are some measurements (with load_images=NO):
Page dillo-fltk patched_dillo-fltk dillo1 firefox ============================================================== splash 7240K 7236K xslt [1] 15016K 14220K freebsd [2] 70264K 58084K mysql [3] 186M 148M 232M 200M
Obviously the difference is mostly visible on large pages. And firefox is pretty close regarding memory usage. However it needed more than 3 minutes to load the local mysql page compared to 6 seconds for dillo-fltk!
Please look out for possible highlight related regressions.
With the same msql page:
http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz
and HUGE_FILESIZE set to 15MB, search for "yen sign". After the fourth match, strange highlights become to happen.
I only have the Euro sign on my keyboard :-) Searching for it works fine. Do you know how I can enter the Yen sign?
No, but I'm talking of the string "yen sign" fed to find text! :-)
Can you try whether this issue is new with my patch?
I did.
-- Cheers Jorge.-
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
On Fri, Jun 20, 2008 at 04:26:39PM +0200, Johannes Hofmann wrote:
Hi,
attached patch fixes the issue here. I had just recently switched the code from using hlStart[layer].index < 0 to hlStart[layer].index > hlEnd[layer].index to indicate that nothing is highlighted. It turned out that I had forgotten to adapt some parts. In addition this patch cleans up some rough edges.
Committed. -- Cheers Jorge.-
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de