are we officially at feature freeze yet?
It would be nice just to make some fixes and get 3.0 out... Bugs: - moveToWidget(). Jorge has code for this. - downloads dpi string escaping. - UI_TEMPORARILY_SHOW_PANELS Not exactly important: - the panel problems when resizing from very small.
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
are we officially at feature freeze yet?
Not officially, but in a close enough state ;)
It would be nice just to make some fixes and get 3.0 out...
Bugs:
- moveToWidget(). Jorge has code for this.
Yes, and it has worked OK for me. How does it behave in your tests?
- downloads dpi string escaping.
Simple enough. Commit welcomed. ;)
- UI_TEMPORARILY_SHOW_PANELS
What's the problem with it? (i.e. it current functionality looks OK to me, but I may not know the problem).
Not exactly important: - the panel problems when resizing from very small.
and - alt text wrapping (which looks like a nice feature) - remove large panel Maybe Johannes has some items too... -- Cheers Jorge.-
Jorge wrote:
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
- moveToWidget(). Jorge has code for this.
Yes, and it has worked OK for me. How does it behave in your tests?
I haven't really been paying attention to it.
- UI_TEMPORARILY_SHOW_PANELS
What's the problem with it? (i.e. it current functionality looks OK to me, but I may not know the problem).
I hide the panels, and then it's supposed to show them if I press ctrl-L to type in the location bar, isn't it?
On Tue, Jul 26, 2011 at 10:37:40PM +0000, corvid wrote:
Jorge wrote:
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
- moveToWidget(). Jorge has code for this.
Yes, and it has worked OK for me. How does it behave in your tests?
I haven't really been paying attention to it.
- UI_TEMPORARILY_SHOW_PANELS
What's the problem with it? (i.e. it current functionality looks OK to me, but I may not know the problem).
I hide the panels, and then it's supposed to show them if I press ctrl-L to type in the location bar, isn't it?
Oh, now I see! I was testing with Ctrl-F ;-) -- Cheers Jorge.-
Do you think the tabs should have a tooltip indicating that they can be closed with a click? Somehow it's hard for me to remember that that feature exists.
On Tue, Jul 26, 2011 at 11:23:49PM +0000, corvid wrote:
Do you think the tabs should have a tooltip indicating that they can be closed with a click? Somehow it's hard for me to remember that that feature exists.
Yeah, it's probably a good idea. (something like the clear URL button). -- Cheers Jorge.-
On Tue, Jul 26, 2011 at 8:16 PM, Jorge Arellano Cid <jcid@dillo.org> wrote:
On Tue, Jul 26, 2011 at 11:23:49PM +0000, corvid wrote:
Do you think the tabs should have a tooltip indicating that they can be closed with a click? Somehow it's hard for me to remember that that feature exists.
?Yeah, it's probably a good idea. ?(something like the clear URL button).
I'd say just reintroduce the close button alongside click-to-close. That way you're not changing a familiar, intuitive user interface users would expect from other applications, but you've still got a useful shortcut for more advanced users. I remember there was some discussion on Dillo's default keyboard shortcuts a while back. It's the same idea here -- Dillo's way is quite convenient once you get used to it, but it's harder for new users because it breaks with other applications' conventions. I'm personally not a fan of changing familiar interfaces when there's no need. On the one hand, a learning curve might turn off new users, who likely expect Dillo to work like their old browser. On the other hand, it also alienates users used to the old version; that's why I still use GIMP 2.4, because I don't understand the interface in newer versions. ~Benjamin
On Wed, 27 Jul 2011 00:54:45 -0400, corvid <corvid@lavabit.com> wrote:
Benjamin wrote:
I'd say just reintroduce the close button alongside click-to-close.
I would say that a nice patch that does this -- or, better yet, puts one on each tab -- would be accepted with a smile.
I'll try to take a look if I have time (I haven't updated my local copy to dillo-3.0 yet). ~Benjamin
On Tue, Jul 26, 2011 at 10:53:55PM -0400, Benjamin Johnson wrote:
On Tue, Jul 26, 2011 at 8:16 PM, Jorge Arellano Cid <jcid@dillo.org> wrote:
On Tue, Jul 26, 2011 at 11:23:49PM +0000, corvid wrote:
Do you think the tabs should have a tooltip indicating that they can be closed with a click? Somehow it's hard for me to remember that that feature exists.
?Yeah, it's probably a good idea. ?(something like the clear URL button).
I'd say just reintroduce the close button alongside click-to-close. That way you're not changing a familiar, intuitive user interface users would expect from other applications, but you've still got a useful shortcut for more advanced users.
AFAIS, this idea looks like the best trade off so far. Although I'd hoped a tooltip label to be enough hint, the single close button to the right is more obvious, and it can bear a tooltip that lists the other ways to close a tab. The tooltip is effective because almost everything in the panel has one, so at some point the user will explore them. As for one close button per tab label, I'd prefer not to.
[...] Dillo's way is quite convenient once you get used to it, but it's harder for new users because it breaks with other applications' conventions.
-- Cheers Jorge.-
Jorge wrote:
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
- UI_TEMPORARILY_SHOW_PANELS Not exactly important: - the panel problems when resizing from very small.
and
- alt text wrapping (which looks like a nice feature)
- remove large panel
- The findbar input doesn't know about Ctrl-A, etc.
On Wed, Jul 27, 2011 at 06:00:18PM +0000, corvid wrote:
Jorge wrote:
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
- UI_TEMPORARILY_SHOW_PANELS Not exactly important: - the panel problems when resizing from very small.
and
- alt text wrapping (which looks like a nice feature)
- remove large panel
- The findbar input doesn't know about Ctrl-A, etc.
Done. -- Cheers Jorge.-
On Wed, Jul 27, 2011 at 06:00:18PM +0000, corvid wrote:
Jorge wrote:
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
- UI_TEMPORARILY_SHOW_PANELS Not exactly important: - the panel problems when resizing from very small.
and
- alt text wrapping (which looks like a nice feature)
- remove large panel
- The findbar input doesn't know about Ctrl-A, etc.
BTW, does anybody have a working URL for BUG#868? (I had a different one as test case, but it went nil...). -- Cheers Jorge.-
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
It would be nice just to make some fixes and get 3.0 out...
Just committed a patch for one of my pet peeves: "After going back or forward to any page, there were two redraws: one from the origin and another from the scroll position. This patch avoids flicker, and makes rendering 100% faster in this case." A good way to test this is to load a page with a colorful image at its top, then scroll away the image, and go to bookmars (no images here). Then go back and forward with the keyboard; w/o the patch you'll see the image flash before the page is drawn at the scroll position it was left at. So far, I'm very happy with it! :-) -- Cheers Jorge.-
On Fri, Jul 29, 2011 at 03:53:45PM -0400, Jorge Arellano Cid wrote:
On Tue, Jul 26, 2011 at 07:48:18PM +0000, corvid wrote:
It would be nice just to make some fixes and get 3.0 out...
So far we have: [ok] moveToWidget(). Jorge has code for this. [ok] downloads dpi string escaping. [ ] UI_TEMPORARILY_SHOW_PANELS [ ] the panel problems when resizing from very small. [ok] alt text wrapping (which looks like a nice feature). [ok] remove large panel. [ok] https dialog storm (BUG#868). [ok] The findbar input doesn't know about Ctrl+{a,e,d,k}. [ ] something other than "ctab%d" for initial tab label. [ ] single close tab button with tooltip. [ ] segfault with Ctrl-s (web search) I'm working on the last one... -- Cheers Jorge.-
Hi, Now we have: [ok] moveToWidget(). Jorge has code for this. [ok] downloads dpi string escaping. [ ] the panel problems when resizing from very small. [ok] alt text wrapping (which looks like a nice feature). [ok] remove large panel. [ok] https dialog storm (BUG#868). [ok] The findbar input doesn't know about Ctrl+{a,e,d,k}. [ ] something other than "ctab%d" for initial tab label. [ ] single close tab button with tooltip. [ ] valgrind logs (needs case by case detail in this list) [ok] segfault with Ctrl-s (web search) [ok] UI_TEMPORARILY_SHOW_PANELS [ok] leave link into a native FLTK widget [ok] remove pointeronlink(), panelmode_cb_i() Just committed patches for the last three items! -- Cheers Jorge.-
On Mon, Aug 01, 2011 at 04:08:32PM +0000, corvid wrote:
Jorge wrote:
[ok] UI_TEMPORARILY_SHOW_PANELS
Escape isn't hiding the findbar now.
I try here with: Viewport Panels Focus Works -------------------------------------------------------- Empty Hidden Findbar OK Empty Shown Location OK Empty Shown Findbar OK HTML page Shown Findbar OK HTML page Shown Main OK HTML page Shown Location OK HTML page Hidden Findbar OK HTML page Hidden Main OK -------------------------------------------------------- and it works for every listed case. -- Cheers Jorge.-
Jorge wrote:
On Mon, Aug 01, 2011 at 04:08:32PM +0000, corvid wrote:
Jorge wrote:
[ok] UI_TEMPORARILY_SHOW_PANELS
Escape isn't hiding the findbar now.
I try here with:
Viewport Panels Focus Works -------------------------------------------------------- Empty Hidden Findbar OK Empty Shown Location OK Empty Shown Findbar OK
HTML page Shown Findbar OK HTML page Shown Main OK HTML page Shown Location OK HTML page Hidden Findbar OK HTML page Hidden Main OK --------------------------------------------------------
and it works for every listed case.
I made a mistake. Sorry!
On Mon, Aug 01, 2011 at 06:32:06PM +0000, corvid wrote:
Jorge wrote:
On Mon, Aug 01, 2011 at 04:08:32PM +0000, corvid wrote:
Jorge wrote:
[ok] UI_TEMPORARILY_SHOW_PANELS
Escape isn't hiding the findbar now.
I try here with:
Viewport Panels Focus Works -------------------------------------------------------- Empty Hidden Findbar OK Empty Shown Location OK Empty Shown Findbar OK
HTML page Shown Findbar OK HTML page Shown Main OK HTML page Shown Location OK HTML page Hidden Findbar OK HTML page Hidden Main OK --------------------------------------------------------
and it works for every listed case.
I made a mistake. Sorry!
Man, you *scared* me! -- Cheers Jorge.-
Hi, [ok] single close tab button with tooltip. Just committed. -- Cheers Jorge.-
It looks like we're down to: - the panel problems when resizing from very small. - cancel expected url bug http://starurchin.org/dillo/valgrind/6120526f753eba6e5646cbfe382a68d971c39dc... - undeleted windows http://starurchin.org/dillo/valgrind/5125438759603857c01a7368aa40cd64873f5ed...
On Thu, Aug 04, 2011 at 09:06:40PM +0000, corvid wrote:
It looks like we're down to:
- the panel problems when resizing from very small.
I have some code for this, but found another corner case...
- cancel expected url bug http://starurchin.org/dillo/valgrind/6120526f753eba6e5646cbfe382a68d971c39dc...
I gave it a look, but will have to give it a second one ;-)
- undeleted windows http://starurchin.org/dillo/valgrind/5125438759603857c01a7368aa40cd64873f5ed...
Please check this one, it looks like a matter of adding the cleanup code. -- Cheers Jorge.-
On Thu, Aug 04, 2011 at 05:52:48PM +0000, corvid wrote:
Jorge wrote:
[ok] single close tab button with tooltip.
Just committed.
Very unimportant corner case: If the current tab's title is under the close button and you click on the tab title anyway for no reason, it obscures the close button.
Right. Fortunately it's easy to recover by moving the mouse pointer to its location. Probably adding some clipping may avoid the glitch, but it looks not worth ATM given that a real tab overflow handler may be coded in the future. -- Cheers Jorge.-
Hi, It looks like now we have: [ok] moveToWidget(). Jorge has code for this. [ok] downloads dpi string escaping. [ok] alt text wrapping (which looks like a nice feature). [ok] remove large panel. [ok] https dialog storm (BUG#868). [ok] The findbar input doesn't know about Ctrl+{a,e,d,k}. [ok] something other than "ctab%d" for initial tab label. [ok] single close tab button with tooltip. [ok] valgrind logs: close window [ ] valgrind logs: cancel expected url [ ] update the Changelog [ok] segfault with Ctrl-s (web search) [ok] UI_TEMPORARILY_SHOW_PANELS [ok] leave link into a native FLTK widget [ok] remove pointeronlink(), panelmode_cb_i() [ok] the panel problems when resizing from very small. [ok] resize problems when tabs overflow Patches committed for the last two. -- Cheers Jorge.-
Hi, [ok] valgrind logs: cancel expected url Please test current repo. -- Cheers Jorge.-
Hi, [ok] Fixed CustLightButton "light" color deactivation When hiding, or leaving a highlighted button into another tab, the "light" state lingered. This was specially nasty on deactivated buttons as there was no easy way to recover the normal state. e.g. * Keep the mouse over Stop until the page fully loads. * With mouse over Forw, go forward with keyboard until the end. * Mouse over Home, Ctrl-t, mouse click previous tab. * Start loading a page, mouse over Stop, Ctrl-t, wait for the page to fully load, go back to the loading tab * Mouse ove Home, hide panels, move mouse, show panels. * etc. -- Cheers Jorge.-
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
obeythepenguin＠gmail.com