Hi'all, I've removed the Dillo splash screen from src/IO/about.c, and added a new preference 'splash_url' (currently set to '/usr/lib/dillo/dillo.html' by default, this can change). The contents of that file are identical to the current splash screen. I've also added a new pref 'show_splash', which - you guessed it - can be used to suppress the splash screen. Set it to NO, and Dillo will come up with a blank window instead. Dillo is now ca. 11 KB smaller than before. The splash screen loads just as fast. The splash screen can be distributed with Dillo just like the dpi's are. Should it be missing, all that'll happen is that Dillo will complain about not finding the file. No breakage... Seems like an improvement to me. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Hello, Inspired by my idea, or something you were thinking about before? Just curious (everyone that takes a look at about.c should get the idea IMHO).
I've also added a new pref 'show_splash', which - you guessed it - can be used to suppress the splash screen. Set it to NO, and Dillo will come up with a blank window instead.
Don't add unnecessary parameters like show_splash, just use splash_url="" for no splash screen. Greetings, Indan
Indan Zupancic wrote:
Hello,
Inspired by my idea, or something you were thinking about before? Just curious (everyone that takes a look at about.c should get the idea IMHO).
Both. I looked at the file before and felt slightly uneasy. Then you mentioned it, I thought 'what the heck let's try it', and 5 minutes later it worked.
Don't add unnecessary parameters like show_splash, just use splash_url="" for no splash screen.
Hm, that would make it hard for people who have (or for whom someone has) disabled the splash to get it back, as they have to know the url. A simple YES/NO is better and not very intrusive. Be aware of the fact that the prefs have sane defaults, they are not mandatory. Having 'show_splash=NO' in a preference file (or a checkbox in a preference screen/page if you prefer) is easier and more intuitive than setting an URL to an empty string. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Frank: I'm not sure that I understand your point. It would seem that Indan's solution eliminates the need an additional preference setting and still provides fallback to the internal default splash url when splash_url is not explicitly specified as nil, by taking advantage of non-mandatory nature of .dillorc prefs. Why would dillo not revert to an internal default splash_url value when not explicitly specified in .dillorc as nil or a value? In other words, when the override of the splash_url to nil (ie. "splash_url=" ) was deleted or commented out, why would dillo not use its own internal hard-coded default? Thanks for your great work to continue to improve dillo! Arnold On Thu, 13 Nov 2003 07:49:56 +0100 Frank de Lange <frank@unternet.org> wrote:
Indan Zupancic wrote:
Hello,
Inspired by my idea, or something you were thinking about before? Just curious (everyone that takes a look at about.c should get the idea IMHO).
Both. I looked at the file before and felt slightly uneasy. Then you mentioned it, I thought 'what the heck let's try it', and 5 minutes later it worked.
Don't add unnecessary parameters like show_splash, just use splash_url="" for no splash screen.
Hm, that would make it hard for people who have (or for whom someone has) disabled the splash to get it back, as they have to know the url. A simple YES/NO is better and not very intrusive. Be aware of the fact that the prefs have sane defaults, they are not mandatory. Having 'show_splash=NO' in a preference file (or a checkbox in a preference screen/page if you prefer) is easier and more intuitive than setting an URL to an empty string.
Cheers//Frank
Arnold wrote:
Frank: I'm not sure that I understand your point.
It would seem that Indan's solution eliminates the need an additional preference setting and still provides fallback to the internal default splash url when splash_url is not explicitly specified as nil, by taking advantage of non-mandatory nature of .dillorc prefs.
True, I had not thought about that aspect. The splash will only be 'completely' gone if someone removes it from the defaults in prefs.c. My point is that Dillo uses 'show_...' for all user interface elements, so for consistency I have added a show_splash. It would be possible to do without it, though. Point taken :-) Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank@unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]
Hello, No, you misunderstood me Arnold, but that way you also brought new ideas. :) What I meant was that splash_url= or splash_url="" would mean that there is no splash screen at all, while commenting the setting out will give you the default splash screen. This also means it's very easy to get the default back, something both Frank and I overlooked. Show_splash may be more intiutive, but it is so only when it is mentioned in dillorc. One comment above splash_url to tell the user to set it to "" for no splash screen is as easy then. What about a compromis; splash=[NO | url] or something like that? Default is the path to the default splash screen, NO and "" ("" means strlen=0, so splash= is the same) disable it. Also don't forget that whatever option you give, it's much better than the official Dillo that loads it's splash screen ALWAYS, even when you start it with "dillo some_file". Greetings, Indan
participants (3)
-
Arnold -
Frank de Lange -
Indan Zupancic