Hi there! On Wed, 9 Jul 2003, Sebastian Geerken wrote:
Hi Jorge,
there is another bug, which should be fixed before, I'll forward you a mail from Andreas. It can be reproduced quite well with the "slow" CGI program I sent you some time ago, and another example is <http://www.dillo.org/cvs.html>. More on this soon.
Sebastian
So the 0.7.3 release will be held until I have some news about this bug. How to reproduce:
[Andreas wrote:]
Well, I found a recently introduced rendering problem : For example http://bbs.archlinux.org/viewtopic.php?t=771 the 4th post has one line extending to the right, w/o a scroll bar on the bottom. You need to resize the window to get the page re-rendered.
In the meanwhile, I'm working on a bare bones FTP example for dpi... Cheers Jorge.-
Hi, On Thu, Jul 10, 2003 at 01:27:48PM -0400, Jorge Arellano Cid wrote:
So the 0.7.3 release will be held until I have some news about this bug.
How to reproduce:
[Andreas wrote:]
Well, I found a recently introduced rendering problem : For example http://bbs.archlinux.org/viewtopic.php?t=771 the 4th post has one line extending to the right, w/o a scroll bar on the bottom. You need to resize the window to get the page re-rendered.
Just to clarify for everybody else on the list : This probably affects all boards managed with phpBB - and there are lots of them. Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198
On Thu, Jul 10, 2003 at 01:27:48PM -0400, Jorge Arellano Cid wrote:
So the 0.7.3 release will be held until I have some news about this bug.
(Jorge, sorry for the double emails, I meant to send to the list before.) Does this fix it? --- source.cvs/src/dw_page.c 2003-07-12 14:17:12.000000000 -0400 +++ source.fix/src/dw_page.c 2003-07-13 00:16:32.000000000 -0400 @@ -451,7 +451,7 @@ static void Dw_page_get_extremes (DwWidg /* no rewrap necessary -> values in lines are up to date */ line = &page->lines[page->num_lines - 1]; if (page->words[line->first_word].style->nowrap) - extremes->min_width = MAX (line->max_word_min, line->par_min); + extremes->min_width = MAX (line->max_line_width, line->par_min); else extremes->min_width = line->max_word_min; extremes->max_width = MAX (line->max_par_max, line->par_max);
On Sun, Jul 13, Joe Crayne wrote:
Does this fix it?
--- source.cvs/src/dw_page.c 2003-07-12 14:17:12.000000000 -0400 +++ source.fix/src/dw_page.c 2003-07-13 00:16:32.000000000 -0400 @@ -451,7 +451,7 @@ static void Dw_page_get_extremes (DwWidg /* no rewrap necessary -> values in lines are up to date */ line = &page->lines[page->num_lines - 1]; if (page->words[line->first_word].style->nowrap) - extremes->min_width = MAX (line->max_word_min, line->par_min); + extremes->min_width = MAX (line->max_line_width, line->par_min); else extremes->min_width = line->max_word_min; extremes->max_width = MAX (line->max_par_max, line->par_max);
No, you cannot compare minimal widths (line->par_min) with actual widths (line->max_line_width), the problem is another one. I've just committed a fix, I'll summarize it here. The first part is: @@ -450,10 +450,11 @@ static void Dw_page_get_extremes (DwWidg } else if (page->wrap_ref == -1) { /* no rewrap necessary -> values in lines are up to date */ line = &page->lines[page->num_lines - 1]; - if (page->words[line->first_word].style->nowrap) - extremes->min_width = MAX (line->max_word_min, line->par_min); - else - extremes->min_width = line->max_word_min; + /* Historical note: The former distinction between lines with and without + * words[first_word]->nowrap set is no longer necessary, since + * Dw_page_real_word_wrap sets max_word_min to the correct value in any + * case. */ + extremes->min_width = line->max_word_min; extremes->max_width = MAX (line->max_par_max, line->par_max); } else { /* Calculate the extremes, based on the values in the line from Why it is not neccessary anymore, is clear from the second part (simplified): @@ -907,9 +916,15 @@ static void Dw_page_real_word_wrap (DwPa if (!new_par) last_line->par_max += last_space; if (word->style->nowrap) { last_line->par_min += word_extremes.min_width; + /* This may also increase the accumulated minimum word width. */ + last_line->max_word_min = + MAX (last_line->max_word_min, last_line->par_min); + /* NOTE: Most code relies on that all values of nowrap are equal for all + * words within one line. */ } else /* Simple case. */ last_line->max_word_min = MAX (last_line->max_word_min, word_extremes.min_width); Actually, this bug has existed for a longer time, what I assume (but did not investigate further) is that the fixed code was never used before, i.e. instead of handling this case: } else if (page->wrap_ref == -1) { /* no rewrap necessary -> values in lines are up to date */ [...] this case: } else { /* Calculate the extremes, based on the values in the line from where a rewrap is necessary. */ [...] was *always* handled, due to the rewrapping bug I fixed some time ago. So this bug was hid by another one. There is still another bug: At http://bbs.archlinux.org/viewtopic.php?t=771 the text is not rewapped sometimes. I'm working on it. Sebastain
On Sun, Jul 13, Sebastian Geerken wrote:
There is still another bug: At
http://bbs.archlinux.org/viewtopic.php?t=771
the text is not rewapped sometimes. I'm working on it.
This should be fixed now, see changes in Dw_page_rewrap (the rest is only code cleaning and new debug messages). It seems to work well, but it certainly needs some other people to test it. Sebastian
On Wed, Jul 16, 2003 at 10:05:25PM +0200, Sebastian Geerken wrote:
On Sun, Jul 13, Sebastian Geerken wrote:
There is still another bug: At
http://bbs.archlinux.org/viewtopic.php?t=771
the text is not rewapped sometimes. I'm working on it.
This should be fixed now, see changes in Dw_page_rewrap (the rest is only code cleaning and new debug messages). It seems to work well, but it certainly needs some other people to test it.
I just have read my daily dose on that site :-), and have not seen the bug anymore. I also checked another phpBB site and haven't seen the bug there either. On to some more "heavy surfing" :-) Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198
Hi there, I just came across this site: http://lpr.sourceforge.net/ It has some problems rendering the leftmost column. When downloaded at slow speeds it sometimes ends being too wide (twice as much as required, and sometimes less). The interesting point is that if you go back and then forth, it renders OK! (so it has to do with partial renderings). Just hope this BUG is easier to solve. (dillo-0.7.2 has no troubles with it) Cheers Jorge.- PS: This means another delay... :(
On Thu, Jul 17, Jorge Arellano Cid wrote:
I just came across this site:
It has some problems rendering the leftmost column. When downloaded at slow speeds it sometimes ends being too wide (twice as much as required, and sometimes less).
I just committed a fix. Please test it, I'll also look at it again tomorrow. Sebastian
participants (4)
-
Andreas Schweitzer -
Joe Crayne -
Jorge Arellano Cid -
Sebastian Geerken