On Fri, 19 Mar 2004, Jorgen Viksell wrote:

Hi Jorge!

Hi!

Here's a bunch of small patches that have been collecting dust on my hard drive. The only serious bug seems to be the first one in the list, the second might be a crasher too although I'm not sure. Anyway, consider yourself patch-bombed! :-)

patch-realloc: Switch an occurance of realloc() in dpi.c to g_realloc() to prevent possible crash when using g_free() below.

patch-gpointer2int: Use GPOINTER_TO_INT and GINT_TO_POINTER where appropriate.

patch-strbuf: Instead of reversing the list; add strings from the tail to the front of the resulting string.

patch-selection: Remove a copy/paste error.

patch-gcc-warning: Silent a gcc warning! (dereferencing type-punned pointer...)

patch-static: Add static to a couple of functions.

patch-unused: Remove PendingHosts since it seems to be unused. Or is it supposed to do some thing with the list in the future?

patch-html_get_attr: Add a convenience function, Html_get_attr_str(), that copies the resulting value and supplies an alternate value if NULL.

patch-null-checks: Remove unnecessary NULL-checks and NULL initializations.

OK, reviewed and applied! I fixed just some minor details, except for patch-gpointer2int; although it was correct, I prefered to avoid the verbosity of GPOINTER_TO_INT and GINT_TO_POINTER casts, by also removing the need for casting back and forth from the roots! Now it looks and feels a bit cleaner, and after two days of testing it went to the CVS. Now you now guys, the CVS has plenty of cleanups, so giving it some extra testing is required. Cheers Jorge.-