segfault -- callback + closed window?
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image. Got: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 Maybe that's just a part of life with callbacks...
Oh, and I want to make it clear that this has nothing to do with the patch Johannes just made which I haven't applied yet.
Hi, On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
I can reproduce a segfault with or without my close dialog patch.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
Life is hard with callbacks, but I think it's just a bug :-) Cheers, Johannes
Hi, On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch. Does someone remember why it was introduced? Cheers, Johannes
On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote:
Hi,
On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch. Does someone remember why it was introduced?
It comes from dillo1. Committed. BTW, this is exactly what I meant with a UI getting the wrong bw. I think this should be fixed before the release. -- Cheers Jorge.-
On Tue, Sep 30, 2008 at 12:03:57PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote:
Hi,
On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch. Does someone remember why it was introduced?
It comes from dillo1.
Committed.
BTW, this is exactly what I meant with a UI getting the wrong bw. I think this should be fixed before the release.
Update: I have a patch that works in my tree. It gets rid of bw as the window's user_data(). Just allow me some time to test/polish. -- Cheers Jorge.-
On Tue, Sep 30, 2008 at 12:41:21PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 12:03:57PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote:
Hi,
On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch. Does someone remember why it was introduced?
It comes from dillo1.
Committed.
BTW, this is exactly what I meant with a UI getting the wrong bw. I think this should be fixed before the release.
Update: I have a patch that works in my tree. It gets rid of bw as the window's user_data(). Just allow me some time to test/polish.
Cool. Just wanted to start it myself. Cheers, Johannes
On Tue, Sep 30, 2008 at 06:39:44PM +0200, Johannes Hofmann wrote:
On Tue, Sep 30, 2008 at 12:41:21PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 12:03:57PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote:
Hi,
On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch. Does someone remember why it was introduced?
It comes from dillo1.
Committed.
BTW, this is exactly what I meant with a UI getting the wrong bw. I think this should be fixed before the release.
Update: I have a patch that works in my tree. It gets rid of bw as the window's user_data(). Just allow me some time to test/polish.
Cool. Just wanted to start it myself.
Please try the attached patch, not tested, I'm on my way to the airport. -- Cheers Jorge.-
On Tue, Sep 30, 2008 at 03:16:30PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 06:39:44PM +0200, Johannes Hofmann wrote:
On Tue, Sep 30, 2008 at 12:41:21PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 12:03:57PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote:
Hi,
On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch. Does someone remember why it was introduced?
It comes from dillo1.
Committed.
BTW, this is exactly what I meant with a UI getting the wrong bw. I think this should be fixed before the release.
Update: I have a patch that works in my tree. It gets rid of bw as the window's user_data(). Just allow me some time to test/polish.
Cool. Just wanted to start it myself.
Please try the attached patch, not tested, I'm on my way to the airport.
I just committed a more polished version. It gets rid of the ui->vbw(), the user_data() setting on FOCUS event and has a new version of win_cb(). Please give it some good testing. -- Cheers Jorge.-
Johannes wrote:
On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote:
I hit ',' a few times, going back past a page with a big progressive jpeg webcomic, and hit ^Q to close the window while dillo was thinking its way past that image.
Got:
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 16384 (LWP 2782)] 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 575 widget->damage_ |= DAMAGE_CHILD; (gdb) bt #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') at Widget.cxx:575 #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) at ui.cc:1109 #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 #4 0x080e489d in fltk::run () at TabGroup.cxx:116 #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127
Maybe that's just a part of life with callbacks...
I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch.
No more crash for me either. Thanks!
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de