I reload the following, and the link border around the first image disappears. If the problem's in the style attr copying/comparison/etc., I'm failing to see it. I can see that the style has border type of none and border width of 0. I started to try to watch ":link img, :visited img {border: 1px solid}" get applied, but... <html> <body> <a href="whatever.html"> <img src="whatever.jpg"> </a> <button type='submit' name='button'"> <img src="something.jpg" alt="Search"> </button> </body> </html> BTW, Jeremy's valgrind logs have an interesting variety of 1.3 bugs for us now.
On Mon, Aug 01, 2011 at 04:03:32AM +0000, corvid wrote:
I reload the following, and the link border around the first image disappears. If the problem's in the style attr copying/comparison/etc., I'm failing to see it. I can see that the style has border type of none and border width of 0. I started to try to watch ":link img, :visited img {border: 1px solid}" get applied, but...
<html> <body> <a href="whatever.html"> <img src="whatever.jpg"> </a>
<button type='submit' name='button'"> <img src="something.jpg" alt="Search"> </button> </body> </html>
Oh, this is a nasty one! It seems the problem is an optimization in CssSelector::match() together with the fact that we reuse the user agent - and the user - style for all pages. I try to get this fixed soon. Cheers, Johannes
On Mon, Aug 01, 2011 at 11:50:59PM +0200, Johannes Hofmann wrote:
On Mon, Aug 01, 2011 at 04:03:32AM +0000, corvid wrote:
I reload the following, and the link border around the first image disappears. If the problem's in the style attr copying/comparison/etc., I'm failing to see it. I can see that the style has border type of none and border width of 0. I started to try to watch ":link img, :visited img {border: 1px solid}" get applied, but...
<html> <body> <a href="whatever.html"> <img src="whatever.jpg"> </a>
<button type='submit' name='button'"> <img src="something.jpg" alt="Search"> </button> </body> </html>
Oh, this is a nasty one!
It seems the problem is an optimization in CssSelector::match() together with the fact that we reuse the user agent - and the user - style for all pages.
I try to get this fixed soon.
I just committed a fix. Now the user- and the useragent-stylesheets are no longer shared between CssContexts. With attached debug-patch you can test the time needed to recreate them on each page load. For me the times were below 1ms. As a bonus you can now modify your user stylesheet (~/.dillo/style.css) while dillo is running. Cheers, Johannes
participants (3)
-
corvid＠lavabit.com -
Johannes.Hofmann＠gmx.de -
onepoint＠starurchin.org