Hi, attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test. Cheers, Johannes
On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote:
Hi,
attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test.
It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc -- Cheers Jorge.-
On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote:
Hi,
attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test.
It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc
Oh yes. Should be fixed now. Btw. I managed to install the claws mail client including the dillo plugin and it seems to work fine now with dillo2. That's why I just committed the xembed stuff. Cheers, Johannes
On Mon, May 18, 2009 at 11:14:14PM +0200, Johannes Hofmann wrote:
On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote:
Hi,
attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test.
It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc
Oh yes. Should be fixed now. Btw. I managed to install the claws mail client including the dillo plugin and it seems to work fine now with dillo2. That's why I just committed the xembed stuff.
This is very good. I'll have to dig for the sylpheed contact to let them know. Does anybody here know the email? -- Cheers Jorge.-
Jorge wrote:
I'll have to dig for the sylpheed contact to let them know. Does anybody here know the email?
http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-October/005313.html gives paul at claws-mail.org
On Tue, May 19, 2009 at 01:34:56PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 11:14:14PM +0200, Johannes Hofmann wrote:
On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote:
Hi,
attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test.
It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc
Oh yes. Should be fixed now. Btw. I managed to install the claws mail client including the dillo plugin and it seems to work fine now with dillo2. That's why I just committed the xembed stuff.
This is very good.
I'll have to dig for the sylpheed contact to let them know. Does anybody here know the email?
I already contacted them on irc (#claws on freenode). It would be good if this get's some testing as there seems to be some interaction with the WM in use. I now tested it successful on dwm, twm, and fvwm. Also there are probabely more elegant ways to do it, but for now I think it's better than nothing. Cheers, Johannes
On Tue, May 19, 2009 at 08:24:14PM +0200, Johannes Hofmann wrote:
On Tue, May 19, 2009 at 01:34:56PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 11:14:14PM +0200, Johannes Hofmann wrote:
On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote:
Hi,
attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test.
It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc
Oh yes. Should be fixed now. Btw. I managed to install the claws mail client including the dillo plugin and it seems to work fine now with dillo2. That's why I just committed the xembed stuff.
This is very good.
I'll have to dig for the sylpheed contact to let them know. Does anybody here know the email?
I already contacted them on irc (#claws on freenode). It would be good if this get's some testing as there seems to be some interaction with the WM in use. I now tested it successful on dwm, twm, and fvwm. Also there are probabely more elegant ways to do it, but for now I think it's better than nothing.
More testing showed that the current implementation has severe problems. The thing is that the window manager that I use (dwm) is one of the few non-reparenting WMs. Most others reparent new windows and that can create races with the reparentin we do. There also seems to be a problem with keyboard events in that case. Is there anyone on the list with in-depth X11 knowledge who could help with the xembed stuff? Cheers, Johannes
Cheers, Johannes
On Tue, May 26, 2009 at 08:17:53PM +0200, Johannes Hofmann wrote:
On Tue, May 19, 2009 at 08:24:14PM +0200, Johannes Hofmann wrote:
On Tue, May 19, 2009 at 01:34:56PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 11:14:14PM +0200, Johannes Hofmann wrote:
On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote:
Hi,
attached patch tries to implement the missing --xid option that is used to embed dillo into the claws mailer. The right way to do this would probabely be to implement the complete XEMBED protocol which is also mentioned in doc/fltk-problems.doc. However a simple XReparentWindow() seems to work more or less here. Please test.
It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc
Oh yes. Should be fixed now. Btw. I managed to install the claws mail client including the dillo plugin and it seems to work fine now with dillo2. That's why I just committed the xembed stuff.
This is very good.
I'll have to dig for the sylpheed contact to let them know. Does anybody here know the email?
I already contacted them on irc (#claws on freenode). It would be good if this get's some testing as there seems to be some interaction with the WM in use. I now tested it successful on dwm, twm, and fvwm. Also there are probabely more elegant ways to do it, but for now I think it's better than nothing.
More testing showed that the current implementation has severe problems. The thing is that the window manager that I use (dwm) is one of the few non-reparenting WMs. Most others reparent new windows and that can create races with the reparentin we do. There also seems to be a problem with keyboard events in that case. Is there anyone on the list with in-depth X11 knowledge who could help with the xembed stuff?
Not me. I've seen new patches in the repo so I assume this is more or less being improved. Please let me know how it goes. AFAIS the current repo is almost dillo-2.1. I'd freeze here and only accept bug fixes and polish from now. Opinions? -- Cheers Jorge.-
On Wed, May 27, 2009 at 05:25:15PM -0400, Jorge Arellano Cid wrote:
On Tue, May 26, 2009 at 08:17:53PM +0200, Johannes Hofmann wrote:
On Tue, May 19, 2009 at 08:24:14PM +0200, Johannes Hofmann wrote:
On Tue, May 19, 2009 at 01:34:56PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 11:14:14PM +0200, Johannes Hofmann wrote:
On Mon, May 18, 2009 at 01:48:43PM -0400, Jorge Arellano Cid wrote:
On Mon, May 18, 2009 at 01:18:11AM +0200, Johannes Hofmann wrote: > Hi, > > attached patch tries to implement the missing --xid option that is > used to embed dillo into the claws mailer. > The right way to do this would probabely be to implement the > complete XEMBED protocol which is also mentioned in > doc/fltk-problems.doc. > However a simple XReparentWindow() seems to work more or less here. > Please test.
It seems like you forgot to commit xembed.{hh,cc} to the repo. e.g. hg add xembed.hh xembed.cc
Oh yes. Should be fixed now. Btw. I managed to install the claws mail client including the dillo plugin and it seems to work fine now with dillo2. That's why I just committed the xembed stuff.
This is very good.
I'll have to dig for the sylpheed contact to let them know. Does anybody here know the email?
I already contacted them on irc (#claws on freenode). It would be good if this get's some testing as there seems to be some interaction with the WM in use. I now tested it successful on dwm, twm, and fvwm. Also there are probabely more elegant ways to do it, but for now I think it's better than nothing.
More testing showed that the current implementation has severe problems. The thing is that the window manager that I use (dwm) is one of the few non-reparenting WMs. Most others reparent new windows and that can create races with the reparentin we do. There also seems to be a problem with keyboard events in that case. Is there anyone on the list with in-depth X11 knowledge who could help with the xembed stuff?
Not me.
I've seen new patches in the repo so I assume this is more or less being improved. Please let me know how it goes.
I figured out some more how this is supposed to work with xtrace and the testsocket example from gtk2. For me it now works reliably with claws under kde3. An open issue is that claws eats up all key presses it has defined as hotkeys (including 'p' and 'u'), but the same thing happens when I embed the example plugin from gtk instead of dillo.
AFAIS the current repo is almost dillo-2.1. I'd freeze here and only accept bug fixes and polish from now. Opinions?
Ok for me. Cheers, Johannes
Johannes wrote:
On Wed, May 27, 2009 at 05:25:15PM -0400, Jorge Arellano Cid wrote:
AFAIS the current repo is almost dillo-2.1. I'd freeze here and only accept bug fixes and polish from now. Opinions?
Ok for me.
A release sounds good. Of course naturally I think, "I hope my MSG macros count as polishing... I hope my UTF-8 file.c code counts as polishing..." The auth crash that Tim reported is the one thing clearly in the way. Bits of polish that I see in skimming through my mail is the matter of the sysconf dir, and of the keybindings changing and the mystery of KEYS_HIDE_PANELS. And putting together sample style.css and keysrc.
On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote:
Johannes wrote:
On Wed, May 27, 2009 at 05:25:15PM -0400, Jorge Arellano Cid wrote:
AFAIS the current repo is almost dillo-2.1. I'd freeze here and only accept bug fixes and polish from now. Opinions?
Ok for me.
A release sounds good. Of course naturally I think, "I hope my MSG macros count as polishing... I hope my UTF-8 file.c code counts as polishing..."
Send them to me when they're ready.
The auth crash that Tim reported is the one thing clearly in the way.
It'd be good to solve this one.
Bits of polish that I see in skimming through my mail is the matter of the sysconf dir, and of the keybindings changing and the mystery of KEYS_HIDE_PANELS. And putting together sample style.css and keysrc.
Yes. I have other items here, but more on this later. -- Cheers Jorge.-
Jorge wrote:
On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote:
Of course naturally I think, "I hope my MSG macros count as polishing... I hope my UTF-8 file.c code counts as polishing..."
Send them to me when they're ready.
It looks like I sent the UTF-8 one on the 17th, and the MSG macros on the 16th, with another mail on the 18th discovering that, whatever the gnu info text might say, "" is safer than an empty argument.
On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote:
Jorge wrote:
On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote:
Of course naturally I think, "I hope my MSG macros count as polishing... I hope my UTF-8 file.c code counts as polishing..."
Send them to me when they're ready.
It looks like I sent the UTF-8 one on the 17th, and the MSG macros on the 16th, with another mail on the 18th discovering that, whatever the gnu info text might say, "" is safer than an empty argument.
Both committed (thanks for the bump). @all: please compile test. -- Cheers Jorge.-
On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote:
On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote:
Jorge wrote:
On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote:
Of course naturally I think, "I hope my MSG macros count as polishing... I hope my UTF-8 file.c code counts as polishing..."
Send them to me when they're ready.
It looks like I sent the UTF-8 one on the 17th, and the MSG macros on the 16th, with another mail on the 18th discovering that, whatever the gnu info text might say, "" is safer than an empty argument.
Both committed (thanks for the bump).
@all: please compile test.
Is this non_ascci instead of non_ascii in misc.c a typo? Cheers, Johannes PS: Compiles fine here.
Johannes wrote:
On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote:
On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote:
Jorge wrote:
On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote:
Of course naturally I think, "I hope my MSG macros count as polishing... I hope my UTF-8 file.c code counts as polishing..."
Send them to me when they're ready.
It looks like I sent the UTF-8 one on the 17th, and the MSG macros on the 16th, with another mail on the 18th discovering that, whatever the gnu info text might say, "" is safer than an empty argument.
Both committed (thanks for the bump).
@all: please compile test.
Is this non_ascci instead of non_ascii in misc.c a typo?
I've always left it alone when working in that bit of the code (either in misc or in file) under the assumption that it dated back to prehistory and therefore had become 'venerable' somehow, but the cvs log shows it only being introduced in 2006.
On Thu, May 28, 2009 at 09:02:41AM +0200, Johannes Hofmann wrote:
On Wed, May 27, 2009 at 05:25:15PM -0400, Jorge Arellano Cid wrote:
AFAIS the current repo is almost dillo-2.1. I'd freeze here and only accept bug fixes and polish from now. Opinions?
Ok for me.
+1. We really want to ship the CSS support (and all the other goodies we have) in a stable release and there are no show-stopping problems. Regards, Jeremy Henty
participants (4)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
onepoint＠starurchin.org