It picks a charset, but doesn't actually do any translation. I have to decide whether to distort the charset decoder to handle encoding. It's nice to have all of the iconv stuff in one place, but it's not nice to have something that's shaped to decode dbufs reused for just any purpose...
Hi, On Tue, Mar 04, 2008 at 06:47:22AM +0000, place wrote:
It picks a charset, but doesn't actually do any translation.
Committed with minor changes.
I have to decide whether to distort the charset decoder to handle encoding. It's nice to have all of the iconv stuff in one place, but it's not nice to have something that's shaped to decode dbufs reused for just any purpose...
I'm all for clarity. If you need to add a "encode.c" source file, go ahead. If a simple function is enough, let it be. If distortion comes in, something is wrong. :-) -- Cheers Jorge.-
On Tue, Mar 04, 2008 at 03:02:36PM +0000, place wrote:
Jorge wrote:
On Tue, Mar 04, 2008 at 06:47:22AM +0000, place wrote:
It picks a charset, but doesn't actually do any translation.
Committed with minor changes.
But if you dFree(first) ahead of time, won't that be bad for html->formNew(method, action, enc, charset);?
Ooops, yes. Reversed to original. -- Cheers Jorge.-
participants (2)
-
jcid＠dillo.org -
place＠gobigwest.com