Hi there, I reviewed my personal notes on dillo segfaults and all of them but one are fixed now. This is: BUG: http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 /m/151006647731/r/264004847731 Aborts dillo. If you wget that URL to a local file, it's easier to debug because the problem is with a requested image. A negative number is propagated down from image.cc:199 #13 0x0807d083 in dw::Image::sizeAllocateImpl (this=0x81eca98,allocation=0xbfc69fb8) at image.cc:201 (gdb) p *allocation $4 = {x = 366, y = 941, width = 3, ascent = 2, descent = 1} (gdb) p dx $5 = 8 (gdb) p dy $6 = 26607 (gdb) allocation->width - dx = -5. from there width=-5 wreaks havoc. Please someone more seasoned in the (dx,dy) offsets give it a look. -- Cheers Jorge.-
Jorge wrote:
Hi there,
I reviewed my personal notes on dillo segfaults and all of them but one are fixed now. This is:
BUG: http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 /m/151006647731/r/264004847731 Aborts dillo.
I tried it and it crashed. Then I dug up the - requisition->width += getStyle()->boxDiffHeight (); + requisition->width += getStyle()->boxDiffWidth (); in sizeRequestImpl from http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-January/003690.html and it no longer wanted to crash for me.
On Sat, May 17, 2008 at 02:17:55AM +0000, corvid wrote:
Jorge wrote:
Hi there,
I reviewed my personal notes on dillo segfaults and all of them but one are fixed now. This is:
BUG: http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 /m/151006647731/r/264004847731 Aborts dillo.
I tried it and it crashed. Then I dug up the
- requisition->width += getStyle()->boxDiffHeight (); + requisition->width += getStyle()->boxDiffWidth ();
in sizeRequestImpl from http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-January/003690.html and it no longer wanted to crash for me.
Committed, also with the rest of the patch. BTW, when I skip one of these patches, please send me a reminder. I commented the patch to let Sebastian delete/fix the commented-out lines when working there. -- Cheers Jorge.-
participants (2)
-
corvid@lavabit.com
-
jcid@dillo.org