On Saturday 21 February 2004 5:19 am, Andreas Kemnade wrote:

I have tried to update Frank's patch. It is not well tested or cleaned up yet but I simply need to take a deep breath.

Thanks! I tried to do that a week or so ago, but didn't get far enough for it to be useful. The patch you posted works so far here (minus obvious things like the incomplete splash page). I've posted some test RPMs in the usual spot, if anyone's interested.

The patch has one big problem. It is too big. Not that it bloats dillo, but it is hard to review such a big patch. Perhaps it can be split up and then be committed piece by piece. Has anyone ideas how to split it? Perhaps in the DilloDoc/BrowserWindow separation, the kbnav thing and frame support?

Agreed. My suggestion would be to pare it down to just what's needed for frames and tabs. Rip out the kbnav changes, the splash screen changes, and everything else. Once that's done, maybe separate the pieces further just to make the pieces easier to review. Maybe three chunks: the doc/window split, frames support, and tabs support.

So what's the way to get frames into cvs?

I suspect that the smaller and easier-to-review the patch is, the better chance it'll have of getting accepted. (But I'm just an interested end-user and packager, not a core developer, so what do I know?)

I would not like to see Frank's effort lost.

Neither would I! -- Kelson Vibber www.hyperborea.org