Dillo has been neglecting its valgrind cleanliness recently and it turns out the culprit is dw::Table, which resizes its internal vectors without initialising any new values that appear. If you valgrind dillo and immediately close the splash window, valgrind reports 121 "Conditional jump or move depends on uninitialised value" errors! This patch reduces that number to 2! Regards, Jeremy Henty
On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote:
Dillo has been neglecting its valgrind cleanliness recently and it turns out the culprit is dw::Table, which resizes its internal vectors without initialising any new values that appear. If you valgrind dillo and immediately close the splash window, valgrind reports 121 "Conditional jump or move depends on uninitialised value" errors! This patch reduces that number to 2!
AFAIU, this patch covers the symptoms of a BUG that current CVS fixes. Please test current CVS against valgrind. -- Cheers Jorge.-
On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote:
On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote:
Dillo has been neglecting its valgrind cleanliness recently and it turns out the culprit is dw::Table, which resizes its internal vectors without initialising any new values that appear.
AFAIU, this patch covers the symptoms of a BUG that current CVS fixes. Please test current CVS against valgrind.
No change. 121 "Conditional jump..." errors, reduced to 2 by my patch. Jeremy Henty
Hi Jeremy, can you please send the valgrind log? Johannes On Sun, Mar 02, 2008 at 02:43:56PM +0000, Jeremy Henty wrote:
On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote:
On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote:
Dillo has been neglecting its valgrind cleanliness recently and it turns out the culprit is dw::Table, which resizes its internal vectors without initialising any new values that appear.
AFAIU, this patch covers the symptoms of a BUG that current CVS fixes. Please test current CVS against valgrind.
No change. 121 "Conditional jump..." errors, reduced to 2 by my patch.
Jeremy Henty
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
On Sun, Mar 02, 2008 at 02:43:56PM +0000, Jeremy Henty wrote:
On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote:
On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote:
Dillo has been neglecting its valgrind cleanliness recently and it turns out the culprit is dw::Table, which resizes its internal vectors without initialising any new values that appear.
AFAIU, this patch covers the symptoms of a BUG that current CVS fixes. Please test current CVS against valgrind.
No change. 121 "Conditional jump..." errors, reduced to 2 by my patch.
To explain, these errors appear because the code updates the entries of the cumHeight and colWidths vectors with wrapper methods setCumHeight and setColWidth. These wrappers begin by comparing the new value with old one and branching on the result, so you get the "Conditional jump..." errors whenever the old value was not initialized. That means these errors have nothing to do with any of the Table algorithms, they're entirely due to the way the Table code manages the cumHeight and colWidths vectors. Jeremy Henty
On Sun, Mar 02, 2008 at 02:57:14PM +0000, Jeremy Henty wrote:
On Sun, Mar 02, 2008 at 02:43:56PM +0000, Jeremy Henty wrote:
On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote:
On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote:
Dillo has been neglecting its valgrind cleanliness recently and it turns out the culprit is dw::Table, which resizes its internal vectors without initialising any new values that appear.
AFAIU, this patch covers the symptoms of a BUG that current CVS fixes. Please test current CVS against valgrind.
No change. 121 "Conditional jump..." errors, reduced to 2 by my patch.
To explain, these errors appear because the code updates the entries of the cumHeight and colWidths vectors with wrapper methods setCumHeight and setColWidth. These wrappers begin by comparing the new value with old one and branching on the result, so you get the "Conditional jump..." errors whenever the old value was not initialized. That means these errors have nothing to do with any of the Table algorithms, they're entirely due to the way the Table code manages the cumHeight and colWidths vectors.
These wrapper methods were introduced by my redraw patch. I will fix this. Johannes
Jeremy Henty
_______________________________________________ Dillo-dev mailing list Dillo-dev@dillo.org http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
participants (3)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
onepoint＠starurchin.org