[patch] remove asap parameter
Hi Jorge, any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now. Cheers, Johannes
On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote:
Hi Jorge,
any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now.
I read it, made some tests and it looks like the cleanup can even reduce the number of resize calls! Committed. -- Cheers Jorge.-
On Tue, Sep 09, 2008 at 06:26:05PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote:
Hi Jorge,
any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now.
I read it, made some tests and it looks like the cleanup can even reduce the number of resize calls!
Not sure wether I'm happy about that. It should not change anything... I will have a further look. Cheers, Johannes
On Wed, Sep 10, 2008 at 04:21:50PM +0200, Johannes Hofmann wrote:
On Tue, Sep 09, 2008 at 06:26:05PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote:
Hi Jorge,
any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now.
I read it, made some tests and it looks like the cleanup can even reduce the number of resize calls!
Not sure wether I'm happy about that. It should not change anything... I will have a further look.
You'll find: //static int calls = 0; //printf(" Layout::resizeIdle calls = %d\n", ++calls); both in layout.cc and fltkviewbase.cc. That's what I used to test. Note that networking may affect the counters. -- Cheers Jorge.-
On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote:
Hi Jorge,
any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now.
I made a mistake during the dw2 commit, then fixed it, and it looks OK, but please check it. TIA. -- Cheers Jorge.-
On Tue, Sep 09, 2008 at 07:32:14PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote:
Hi Jorge,
any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now.
I made a mistake during the dw2 commit, then fixed it, and it looks OK, but please check it.
Looks good. Just a comment replacing a ifdef'd block is missing. See attached patch. Cheers, Johannes
On Wed, Sep 10, 2008 at 04:20:50PM +0200, Johannes Hofmann wrote:
On Tue, Sep 09, 2008 at 07:32:14PM -0400, Jorge Arellano Cid wrote:
On Tue, Sep 09, 2008 at 06:07:16PM +0200, Johannes Hofmann wrote:
Hi Jorge,
any objections to remove the asap parameter as in attached patch? It has been disabled for quite some time now.
I made a mistake during the dw2 commit, then fixed it, and it looks OK, but please check it.
Looks good. Just a comment replacing a ifdef'd block is missing. See attached patch.
Committed. -- Cheers Jorge.-
participants (2)
-
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de