I've been valgrinding Dillo to see what I find and this one keeps turning up. Some memory is accessed that was freed by a_Cache_set_content_type(). Regards, Jeremy Henty
Jeremy wrote:
==20949== by 0x806065B: a_Cache_process_dbuf (cache.c:865) ==20949== ==20949== Invalid read of size 4 ==20949== at 0x8060E9B: Cache_process_queue (cache.c:1145)
Does this part of it stop complaining if the a_UIcmd_set_page_prog(Client_bw, data->len, 1); in Cache_process_queue() uses Cache_data(entry)->len instead?
On Thu, Jan 22, 2009 at 10:37:41PM +0000, corvid wrote:
Jeremy wrote:
==20949== by 0x806065B: a_Cache_process_dbuf (cache.c:865) ==20949== ==20949== Invalid read of size 4 ==20949== at 0x8060E9B: Cache_process_queue (cache.c:1145)
Does this part of it stop complaining if the a_UIcmd_set_page_prog(Client_bw, data->len, 1); in Cache_process_queue() uses Cache_data(entry)->len instead?
Yes. Patch attached. Regards, Jeremy Henty
Jeremy wrote:
On Thu, Jan 22, 2009 at 10:37:41PM +0000, corvid wrote:
Jeremy wrote:
==20949== by 0x806065B: a_Cache_process_dbuf (cache.c:865) ==20949== ==20949== Invalid read of size 4 ==20949== at 0x8060E9B: Cache_process_queue (cache.c:1145)
Does this part of it stop complaining if the a_UIcmd_set_page_prog(Client_bw, data->len, 1); in Cache_process_queue() uses Cache_data(entry)->len instead?
Yes. Patch attached.
I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.
On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote:
I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.
OK, then ignore my earlier patch. Do you expect this to fix both of the valgrind errors, or just the second one as your previous suggestion did? Regards, Jeremy Henty
Jeremy wrote:
On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote:
I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.
OK, then ignore my earlier patch. Do you expect this to fix both of the valgrind errors, or just the second one as your previous suggestion did?
Just the second one. The other error looks like it's upset that we're trying to look at start and tag after set_content_type made buf go away.
On Fri, Jan 23, 2009 at 07:56:33AM +0000, Jeremy Henty wrote:
On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote:
I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.
OK, then ignore my earlier patch. Do you expect this to fix both of the valgrind errors, or just the second one as your previous suggestion did?
The new patches added expect to fix the remaining. The small patch (2 lines) aims to this problem, and the others are cleanups and logic fixes that hope to avoid future troubles. Please test. -- Cheers Jorge.-
On Fri, Jan 23, 2009 at 05:11:54PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 23, 2009 at 07:56:33AM +0000, Jeremy Henty wrote:
On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote:
I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.
OK, then ignore my earlier patch. Do you expect this to fix both of the valgrind errors, or just the second one as your previous suggestion did?
The new patches added expect to fix the remaining. The small patch (2 lines) aims to this problem, and the others are cleanups and logic fixes that hope to avoid future troubles.
Please test.
The amazon.de crash is fixed. And I don't see any other crashes. Thanks, Johannes
On Sat, Jan 24, 2009 at 10:34:45AM +0100, Hofmann Johannes wrote:
On Fri, Jan 23, 2009 at 05:11:54PM -0300, Jorge Arellano Cid wrote:
On Fri, Jan 23, 2009 at 07:56:33AM +0000, Jeremy Henty wrote:
On Fri, Jan 23, 2009 at 03:13:10AM +0000, corvid wrote:
I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.
OK, then ignore my earlier patch. Do you expect this to fix both of the valgrind errors, or just the second one as your previous suggestion did?
The new patches added expect to fix the remaining. The small patch (2 lines) aims to this problem, and the others are cleanups and logic fixes that hope to avoid future troubles.
Please test.
The amazon.de crash is fixed. And I don't see any other crashes.
Good. (It didn't crash for me, but valgrind complained. Fixing the latter did the trick). -- Cheers Jorge.-
participants (4)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
onepoint＠starurchin.org