Any objection to removing the special case for putting list item markers at the far left even when the text is centered or whatever? I've never liked this weird special case, and I see that Firefox doesn't do it, anyway.
On Sun, Nov 13, 2011 at 01:21:10AM +0000, corvid wrote:
Any objection to removing the special case for putting list item markers at the far left even when the text is centered or whatever? I've never liked this weird special case, and I see that Firefox doesn't do it, anyway.
diff -r 284f9065236f dw/textblock.cc --- a/dw/textblock.cc Sat Nov 12 20:35:34 2011 +0000 +++ b/dw/textblock.cc Sun Nov 13 01:16:11 2011 +0000 @@ -1079,15 +1079,7 @@ if (leftOffset < 0) leftOffset = 0;
- if (hasListitemValue && lastLine == lines->getRef (0)) { - /* List item markers are always on the left. */ - lastLine->leftOffset = 0; - words->getRef(0)->effSpace = words->getRef(0)->origSpace + leftOffset; - //DBG_OBJ_ARRSET_NUM (this, "words.%d.effSpace", 0, - // words->getRef(0)->effSpace); - } else { - lastLine->leftOffset = leftOffset; - } + lastLine->leftOffset = leftOffset; } mustQueueResize = true;
+1 Cheers, Johannes
corvid wrote:
Any objection to removing the special case for putting list item markers at the far left even when the text is centered or whatever? I've never liked this weird special case, and I see that Firefox doesn't do it, anyway.
+1. It looks much nicer the Firefox way. Regards, Jeremy Henty
On Sun, Nov 13, 2011 at 01:21:10AM +0000, corvid wrote:
Any objection to removing the special case for putting list item markers at the far left even when the text is centered or whatever? I've never liked this weird special case, and I see that Firefox doesn't do it, anyway.
+1 -- Cheers Jorge.-
participants (4)
-
corvid@lavabit.com
-
jcid@dillo.org
-
Johannes.Hofmann@gmx.de
-
onepoint@starurchin.org