Get it here: http://www.xs4all.nl/~dorinek/dillo/dillo-ssl.diff.gz It's not as nice and simple as I wanted it to be, thanks to three things: 1) SSL can always read and write, meaning that SSL_write may want to read. 2) Dillo uses two IOData structures per file descriptor. 3) There is no efficient way of (un)registering file descriptor events in GTK. (FLTK has a perfect interface). This three facts contribute a lot to the complexity of the code. There is one known bug, you may try to find it. ;) Dillo will not crash, I made it exit with a message. This patch adds also generic ssl/tls support to Dillo, most work was done in IO.c, http.c has hardly changed. The current way to tell the IO engine that it should use ssl is by giving a negative fd to a_IO_new. This avoids extra interface, is simple, and doesn't clash with anything else. Dillo is about 2K bigger after the patch. It was made against the current cvs, apply it with 'patch -p1 < dillo-ssl.diff' while you're in the dillo dir. Run configure with --disable-ssl if you don't want https... Have fun. p.s. I hate glib ;), it's totally worthless, the most complex piece Dillo uses is a hash table, and glib implements it as a linked list, look in the code yourself if you don't believe me. Since when is ansi c not good enough? Please switch to FLTK. :) p.s.s This mail was sent from webmail with a patched Dillo. :)
Which version does the patch require? I tried against 0.7.3 and got some errors - one in each of IO.c, Url.c and capi.c. Mike On Mon, 27 Oct 2003, Indan Zupancic wrote:
Get it here: http://www.xs4all.nl/~dorinek/dillo/dillo-ssl.diff.gz
It's not as nice and simple as I wanted it to be, thanks to three things:
1) SSL can always read and write, meaning that SSL_write may want to read. 2) Dillo uses two IOData structures per file descriptor. 3) There is no efficient way of (un)registering file descriptor events in GTK. (FLTK has a perfect interface).
This three facts contribute a lot to the complexity of the code.
There is one known bug, you may try to find it. ;) Dillo will not crash, I made it exit with a message.
This patch adds also generic ssl/tls support to Dillo, most work was done in IO.c, http.c has hardly changed. The current way to tell the IO engine that it should use ssl is by giving a negative fd to a_IO_new. This avoids extra interface, is simple, and doesn't clash with anything else.
Dillo is about 2K bigger after the patch. It was made against the current cvs, apply it with 'patch -p1 < dillo-ssl.diff' while you're in the dillo dir. Run configure with --disable-ssl if you don't want https...
Have fun.
p.s. I hate glib ;), it's totally worthless, the most complex piece Dillo uses is a hash table, and glib implements it as a linked list, look in the code yourself if you don't believe me. Since when is ansi c not good enough? Please switch to FLTK. :)
p.s.s This mail was sent from webmail with a patched Dillo. :)
_______________________________________________ Dillo-dev mailing list Dillo-dev@lists.auriga.wearlab.de http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
-- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS
Which version does the patch require? I tried against 0.7.3 and got some errors - one in each of IO.c, Url.c and capi.c.
Quote: "It was made against the current cvs" I guess that's pre 0.8. it shouldn't be much work to get it working with 0.7.3, if you want that then just say, I'll make another patch then. The current cvs version seems very stable, and Frank's patches are also cvs only, so it seems more than logical to me that if you want experimental new features, you use the cvs version. Two things I forgot to mention: If you want a lean and mean Dillo, then comment out or, remove "#define DEBUG_MSG 5" at the top of IO.c, the extra overhead of the spam isn't negligible on my 233 mhz computer (it also makes the https code much bigger). The openssl licence is a "GPL-Incompatible, Free Software Licenses", so it's needed to add an exception that says that DIllo may be linked to the openssl library, see for more info: http://www.gnu.org/philosophy/license-list.html#TOCGPLIncompatibleLicenses
Sorry - apparently I can't read :-( I'll go for the cvs version. Thanks Mike On Mon, 27 Oct 2003, Indan Zupancic wrote:
Which version does the patch require? I tried against 0.7.3 and got some errors - one in each of IO.c, Url.c and capi.c.
Quote: "It was made against the current cvs"
I guess that's pre 0.8.
it shouldn't be much work to get it working with 0.7.3, if you want that then just say, I'll make another patch then. The current cvs version seems very stable, and Frank's patches are also cvs only, so it seems more than logical to me that if you want experimental new features, you use the cvs version.
Two things I forgot to mention:
If you want a lean and mean Dillo, then comment out or, remove "#define DEBUG_MSG 5" at the top of IO.c, the extra overhead of the spam isn't negligible on my 233 mhz computer (it also makes the https code much bigger).
The openssl licence is a "GPL-Incompatible, Free Software Licenses", so it's needed to add an exception that says that DIllo may be linked to the openssl library, see for more info: http://www.gnu.org/philosophy/license-list.html#TOCGPLIncompatibleLicenses
_______________________________________________ Dillo-dev mailing list Dillo-dev@lists.auriga.wearlab.de http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
-- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS
participants (2)
-
Indan Zupancic -
Mike Eriksen