I will try to post this again.... I am having this issue when I get to 'gmake' doing the CVS build. [FreeBSD happy.hopto.org 4.10-RELEASE FreeBSD 4.10-RELEASE #0] interface.c: In function `Interface_make_search_url': interface.c:1350: syntax error before `*' interface.c:1352: `search_url' undeclared (first use in this function) interface.c:1352: (Each undeclared identifier is reported only once interface.c:1352: for each function it appears in.) interface.c:1353: warning: control reaches end of non-void function gmake[3]: *** [interface.o] Error 1 gmake[3]: Leaving directory `/usr/home/petie/dillo/src' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/usr/home/petie/dillo/src' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/home/petie/dillo' gmake: *** [all] Error 2 -- Pete http://milneweb.com http://nomorevirus.com
Pete, This is the problem I reported (and supplied a patch for) under the title "c99 coding style...". You can fix it you self by going to the lines where the erros are reported and moving the declarations to the top of their functions. The one in interface.c (the one giving the error below) includes an initiallization that depends on the state of the fuction at line 1350, so you'll have to split it into a declartaion at the top of the function, and an assignment in the current location. The one in url.c can be solved by moving the sanity check at the top of the function below all the declarations. On Sat, 14 Aug 2004 opus@milneweb.com wrote:
I am having this issue when I get to 'gmake' doing the CVS build. [snip] interface.c: In function `Interface_make_search_url': interface.c:1350: syntax error before `*' interface.c:1352: `search_url' undeclared (first use in this function) interface.c:1352: (Each undeclared identifier is reported only once interface.c:1352: for each function it appears in.) interface.c:1353: warning: control reaches end of non-void function [snip] Pete
The code that is giving you trouble is valid under the new (1999) standard for "c", but invalid under the old (1982? ANSI standard, and under the original K&R compiler). Versions of gcc from 3.0 on accept c99 syntax, but older versions do not. I imagine that Jorge will get around to cleaning it up sooner or later. He has fixed this kind of thing in the past. Good luck, -- -- David McKee -- dmckee@jlab.org -- (757) 269-7492 (Office)
* David McKee (dmckee@jlab.org):
The code that is giving you trouble is valid under the new (1999) standard for "c", but invalid under the old (1982? ANSI standard, and under the original K&R compiler). Versions of gcc from 3.0 on accept c99 syntax, but older versions do not. I imagine that Jorge will get around to cleaning it up sooner or later. He has fixed this kind of thing in the past.
As the current mainainer of the dillo FreeBSD port I hope that the code stays "gcc 2.95 clean" for some time since FreeBSD uses gcc 2.95.4 as the system compiler on the 4.x series and 4.x is likely to stay around for quite a while, even after FreeBSD 5 is declared the "STABLE" development branch.
On Sun, Aug 15, 2004 at 11:25:59AM +0200, Thomas-Martin Seck wrote:
* David McKee (dmckee@jlab.org):
The code that is giving you trouble is valid under the new (1999) standard for "c", but invalid under the old (1982? ANSI standard, and under the original K&R compiler). Versions of gcc from 3.0 on accept c99 syntax, but older versions do not. I imagine that Jorge will get around to cleaning it up sooner or later. He has fixed this kind of thing in the past.
As the current mainainer of the dillo FreeBSD port I hope that the code stays "gcc 2.95 clean" for some time since FreeBSD uses gcc 2.95.4 as the system compiler on the 4.x series and 4.x is likely to stay around for quite a while, even after FreeBSD 5 is declared the "STABLE" development branch.
The original c99 patch introduced a memory leak, so a fixed version was commited. Yes, we do strive for code compatibility, and this kind of report is welcomed. -- Cheers Jorge.-
Jorge Arellano Cid writes:
The original c99 patch introduced a memory leak, so a fixed version was commited.
Yes, we do strive for code compatibility, and this kind of report is welcomed.
-- Cheers Jorge.-
Thank you for fixing this!! -- Pete http://milneweb.com http://nomorevirus.com
participants (4)
-
David McKee
-
Jorge Arellano Cid
-
opus@milneweb.com
-
Thomas-Martin Seck