Hi! I just pulled some change to make <pre> work. Please test it again, even things which have worked recently, so that we can be sure that nothing is broken again. Sebastian
Hi Sebastian, On Mon, Oct 29, 2012 at 08:08:16PM +0100, Sebastian Geerken wrote:
Hi!
I just pulled some change to make <pre> work. Please test it again, even things which have worked recently, so that we can be sure that nothing is broken again.
Works very nice for me! With the following change: diff -r 5e7a06855f37 dw/textblock.hh --- a/dw/textblock.hhMon Oct 29 20:05:20 2012 +0100 +++ b/dw/textblock.hhMon Oct 29 22:23:15 2012 +0100 @@ -552,8 +552,7 @@ { if (style->whiteSpace != core::style::WHITE_SPACE_NOWRAP && style->whiteSpace != core::style::WHITE_SPACE_PRE) - if (word->badnessAndPenalty.lineMustBeBroken()) - word->badnessAndPenalty.setPenalty (0); + word->badnessAndPenalty.setPenalty (0); } void addHyphen(); ideographic characters also seem to work again, but I'm not sure about all the side-effects. furaisanjin, could you please test this? Cheers, Johannes
Hello all. 2012/10/30 Johannes Hofmann <Johannes.Hofmann at gmx.de>:
Works very nice for me! With the following change:
Is this chnage necessary to test ideographic character pages? I just recompiled with changeset 2516:5e7a06855f37 and saw http://www.nhk.or.jp/audio/index.html as I reported last time but I don't see improvement yet. Regards, furaisanjin
On Mon, Oct 29, Johannes Hofmann wrote:
On Mon, Oct 29, 2012 at 08:08:16PM +0100, Sebastian Geerken wrote:
I just pulled some change to make <pre> work. Please test it again, even things which have worked recently, so that we can be sure that nothing is broken again.
Works very nice for me! With the following change:
diff -r 5e7a06855f37 dw/textblock.hh --- a/dw/textblock.hhMon Oct 29 20:05:20 2012 +0100 +++ b/dw/textblock.hhMon Oct 29 22:23:15 2012 +0100 @@ -552,8 +552,7 @@ { if (style->whiteSpace != core::style::WHITE_SPACE_NOWRAP && style->whiteSpace != core::style::WHITE_SPACE_PRE) - if (word->badnessAndPenalty.lineMustBeBroken()) - word->badnessAndPenalty.setPenalty (0); + word->badnessAndPenalty.setPenalty (0); }
void addHyphen();
ideographic characters also seem to work again, but I'm not sure about all the side-effects.
Er ... this patch modifies Textblock::addBreakOption(), which is not used anymore (neither of the two variants), so how can this change anything? Sebastian
On Fri, Nov 02, Sebastian Geerken wrote:
On Mon, Oct 29, Johannes Hofmann wrote:
On Mon, Oct 29, 2012 at 08:08:16PM +0100, Sebastian Geerken wrote:
I just pulled some change to make <pre> work. Please test it again, even things which have worked recently, so that we can be sure that nothing is broken again.
Works very nice for me! With the following change:
diff -r 5e7a06855f37 dw/textblock.hh --- a/dw/textblock.hhMon Oct 29 20:05:20 2012 +0100 +++ b/dw/textblock.hhMon Oct 29 22:23:15 2012 +0100 @@ -552,8 +552,7 @@ { if (style->whiteSpace != core::style::WHITE_SPACE_NOWRAP && style->whiteSpace != core::style::WHITE_SPACE_PRE) - if (word->badnessAndPenalty.lineMustBeBroken()) - word->badnessAndPenalty.setPenalty (0); + word->badnessAndPenalty.setPenalty (0); }
void addHyphen();
ideographic characters also seem to work again, but I'm not sure about all the side-effects.
Er ... this patch modifies Textblock::addBreakOption(), which is not used anymore (neither of the two variants), so how can this change anything?
Sorry, I see it now. Johannes patch is (with some changes) applied. Furaisanjin: are there still issues? Sebastian
2012/11/3 Sebastian Geerken <sgeerken at dillo.org>:
On Fri, Nov 02, Sebastian Geerken wrote:
Johannes patch is (with some changes) applied. Furaisanjin: are there still issues?
Now dillo is much better but still http://news.google.co.jp shows the issue. There are 3 columns in main area but balance of them aren't suitable to fit them on one screen so that horizontal scroll bar appears. Another language page like http://news.google.com/news?ned=uk has same appearance. Regards, furaisanjin
Hi Sebastian, On Fri, Nov 02, 2012 at 04:04:52PM +0100, Sebastian Geerken wrote:
On Fri, Nov 02, Sebastian Geerken wrote: [...] Johannes patch is (with some changes) applied.
I have no problems with the latest patch. The code respects PRE formatted code inserting a horizontal scroll when necessary. FWIW, without this last patch, I had problems with the attached test case. BTW, what will happen with HTML pages that quote full-paragraph-in-one-line emails with PRE? (unfortunately I don't have an example page at hand). -- Cheers Jorge.-
Hi Sebastian, On Mon, Oct 29, 2012 at 08:08:16PM +0100, Sebastian Geerken wrote:
Hi!
I just pulled some change to make <pre> work. Please test it again, even things which have worked recently, so that we can be sure that nothing is broken again.
What should we test? All of whitespace formatting in PRE? Should we use Johannes' patch? -- Cheers Jorge.-
participants (4)
-
furaisanjin＠gmail.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de -
sgeerken＠dillo.org